[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- Hi George and Lincoln I added version and the transactiontype. Of course, it is done in a reusable way, other common descriptors would benefit as well. The transactionType enum stressed me a little bit. I tried several things. At the end, I came to the conclusion that the best approach between all enum type version e.g. transactionType version 1.0, 1.1 and 1.2 are strings. All generated enums already accept strings as arguments, and returns the value as string with the method getXXXXAsString(). I think, this is an acceptable way. I hope:-) Then some thoughts about the missing Properties type. It took me a long time to analyze your solution of the common web app descriptor. One thing I realized that this common descriptor makes only few sub types of the webapp descriptor common. SERVLET, SERVLET_MAPPING and so on. Other subtypes are not defined or part of the common descriptor. So my question is what are the criterias for a common descriptor? And more important, do you need a common type and inside this as well common subtypes? This is the case of the properties type. It is a sub time of the persistence-unit type. I will find a way to make this as well possible. Stay tuned Ralf -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira