7:04 p.m.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Fix For: 1.0.0-alpha-10
Make the Archive type first in the API, as it allows us to introduce defaults for the name
and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:36 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
So in this sense we switch the order of name,type to type,name.
Let's make stepwise progress and @Deprecate the former to delegate to the latter, then
remove in the next release.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Fix For: 1.0.0-alpha-10
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:53 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Dan Allen commented on SHRINKWRAP-163:
--------------------------------------
Sounds good to me.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Fix For: 1.0.0-alpha-10
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:32 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Dan Allen updated SHRINKWRAP-163:
---------------------------------
Attachment: SHRINKWRAP-163-v1.txt
Attached proposed patch.
The specified archive type (e.g., WebArchive) isn't created until after the internal
archive (MemoryMapArchiveImpl), using Assignable#as(Class<T>). This presents a
problem for us since the name of the archive is stored in a final field of the internal
archive. The only way I could figure out how to append a derived extension for the archive
was to wrap the internal archive in the constructor of the specified archive and override
getName(). I'm not sure whether you want to accept this approach, but it does work.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Dan Allen commented on SHRINKWRAP-163:
--------------------------------------
I haven't implemented the ExtensionType idea, though I did create String constants on
each of the specific archive interfaces that hold the extension.
JavaArchive.EXTENSION
EnterpriseArchive.EXTENSION
WebArchive.EXTENSION
ResourceAdapterArchive.EXTENSION
I'm not sure which direction we want to go here. Please advise.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:24 p.m.
New subject: [JBoss JIRA] Assigned: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Dan Allen reassigned SHRINKWRAP-163:
------------------------------------
Assignee: Andrew Lee Rubinger
Assigning to ALR for review.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:53 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
While I can see extension as an input (ie. we don't care about the name of the
archive, only the extension), I guess we don't need to carry this around as a separate
property. ie. I think when users supply "my.jar" as a name, they're
explicitly giving the extension. If they want to give no name, but only an extension, we
can construct a name for them and then suffix the extension.
I don't see any references / use case where archive.getExtension() is required, aside
from in assigning the name.
Cool to remove this from the Archive API and as a field member, and instead only honor
ExtensionType as an input param?
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
Hmm, and here we mandate an extension in the patch:
final String name = delegate.getName().lastIndexOf('.') > 0 ?
delegate.getName() : delegate.getName() + "." + getExtension();
IMO we can't tell users they must have an extension, or we'll default it, etc.
Lemme play a bit. :)
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:41 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Dan Allen commented on SHRINKWRAP-163:
--------------------------------------
Cool to remove this from the Archive API and as a field member, and
instead only honor ExtensionType as an input param?
Sure. The only reason I added that was as a way to push that information into the
ContainerBase. I couldn't think of a way off the top of my head to pass on this
information from the archive impl.
I don't see any references / use case where
archive.getExtension() is required, aside from in assigning the name.
I know that application servers look at the archive extension to decide what to do when it
is passed to deploy() (or put in the hot deploy directory), but since that logic is likely
low level, I doubt the container would consume this information from the archive itself
(instead merely reflecting on the name).
While I can see extension as an input (ie. we don't care about
the name of the archive, only the extension), I guess we don't need to carry this
around as a separate property. ie. I think when users supply "my.jar" as a name,
they're explicitly giving the extension. If they want to give no name, but only an
extension, we can construct a name for them and then suffix the extension.
Right, the idea is to let them think in terms of artifact name (the way that Maven talks
about artifacts) and not have them worry about the extension.
ShrinkWrap.create(WebArchive.class, "stocktrader")
We just do the right thing (in this case stocktrader.war).
Of course, we honor an existing extension in the name for:
a) backwards compatibility
b) it's an easy way to override it if needed
ShrinkWrap.create(JavaArchive.class, "stocks.par") // par would be persistence
archive, though no one uses that extension, user has special case perhaps
I'd like to have ExtensionType, but for that we are going to need an interface/class
to allow for extensibility (not an enum)
ShrinkWrap.create(JavaArchive, "stocktrader", ExtensionType.WAR)
public class ExtensionType
{
static final ExtensionType WAR = new ExtensionType("war");
static final ExtensionType JAR = new ExtensionType("jar");
static final ExtensionType EAR = new ExtensionType("ear");
static final ExtensionType RAR = new ExtensionType("rar");
private final String extension;
public ExtensionType(String extension)
{
this.extension = extension;
}
String getExtension() {
return extension;
}
}
Then, anyone could introduce their own constant:
static final ExtensionType PAR = new ExtensionType("par");
Is that headed in the right direction?
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
I can see the benefit of:
ShrinkWrap.create(JavaArchive, "stocktrader", ExtensionType.WAR)
...but this kind of thing I think could lead to confusion (or taking the wrong action):
ShrinkWrap.create(WebArchive.class, "stocktrader")
In the second form, we'd have to do a String.lastIndexOf(".") thing to see
if the user provided an extension, and then default it to ".war" if not present.
The problem here is if the user supplied a "." as part of the name, and
we'd miss out on giving them the extension.
So IMO this actually means we'd be doing too much by inspecting the given name for an
extension. Is it really of much benefit to be defaulting the extension if a name is
provided? Seems we should do:
ShrinkWrap.create(WebArchive.class); // Makes an archive of unique name in form
"name.war"
ShrinkWrap.create(WebArchive.class, String name); // Uses the supplied name explicitly
ShrinkWrap.create(WebArchive.class, String name, ExtensionType type); // Appends the
extension name to the supplied name
WDYT?
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:04 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
During resolution of this issue, let's change no existing tests at first. They should
continue on the @Deprecated support. Then we can release, remove the deprecation, and
update all.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 a.m.
New subject: [JBoss JIRA] Assigned: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger reassigned SHRINKWRAP-163:
----------------------------------------------
Assignee: Ken Gullaksen (was: Andrew Lee Rubinger)
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Dan Allen commented on SHRINKWRAP-163:
--------------------------------------
Sounds perfect to me. Your proposal is deterministic, which is consistent with the robust
nature of ShrinkWrap. We don't want to allow ShrinkWrap to be guessing at things.
To restate, if the user is supplying a name, they can do any of the following:
ShrinkWrap.create(WebArchive.class, "stocktrader.war")
ShrinkWrap.create(WebArchive.class, "stocktrader" + ExtensionType.WAR) // in
this case, toString() would produce ".war"
ShrinkWrap.create(WebArchive.class, "stocktrader", ExtensionType.WAR)
But for Arquillian, they have the luxury of using:
ShrinkWrap.create(WebArchive.class)
...which is the only case where the extension will be automatically appended.
I agree that we leave the test in place for the @Deprecated methods. We should annotate
the deprecated tests with @Deprecated so that we can find them when the time comes.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:25 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
Consensus FTW. :D
BTW I'd be surprised if we actually end up deprecating tests themselves. Likely
they'll just be refactored to the new APIs when done. Let's review all tests to
be removed together before we strip them (if necessary).
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:27 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-163?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
New method support to be both in:
ShrinkWrap
ArchiveFactory
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Ken Gullaksen commented on SHRINKWRAP-163:
------------------------------------------
In the case of
ShrinkWrap.create(WebArchive.class, "stocktrader.war")
and
ShrinkWrap.create(WebArchive.class, "stocktrader" + ExtensionType.WAR)
should we do any sanity checking on the archiveName string?
i.e. is it a requirement that the name contain an extension?
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:14 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
No checking for the name should be required; only that it's not null. In real life
users can name their files anything they like, and so it must be with SW. :)
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Ken Gullaksen commented on SHRINKWRAP-163:
------------------------------------------
Great :)
Just want to restate Dan Allens question for clarification:
{quote}
The specified archive type (e.g., WebArchive) isn't created until after the internal
archive (MemoryMapArchiveImpl), using Assignable#as(Class<T>). This presents a
problem for us since the name of the archive is stored in a final field of the internal
archive. The only way I could figure out how to append a derived extension for the archive
was to wrap the internal archive in the constructor of the specified archive and override
getName(). I'm not sure whether you want to accept this approach, but it does work.
{quote}
If this is OK, I'll go ahead and implement it like it stands in the patch.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:13 a.m.
New subject: [JBoss JIRA] Work started: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Work on SHRINKWRAP-163 started by Ken Gullaksen.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Ken Gullaksen updated SHRINKWRAP-163:
-------------------------------------
Attachment: SHRINKWRAP-163.patch
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:17 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Ken Gullaksen commented on SHRINKWRAP-163:
------------------------------------------
Attached a patch for review containing what I've got so far. It's missing some doc
and tests that will need to be done before commit.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:52 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger updated SHRINKWRAP-163:
-------------------------------------------
JBoss Forum Reference: http://community.jboss.org/thread/152285
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:19 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Ken Gullaksen updated SHRINKWRAP-163:
-------------------------------------
Attachment: SHRINKWRAP-163-v3.patch
Attached ShrinkWrap-163-v3.patch, Does not include test for user supplying own type
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163-v3.patch,
SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:21 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
Committed Ken's patch with some changes (as noted in the commit message). Ken
let's discuss those when you're next on. :)
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163-v3.patch,
SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:50 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger commented on SHRINKWRAP-163:
------------------------------------------------
Blocking this: it's now not possible for a user to configure new extension mappings.
ExtensionType is locked up to the outside.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163-v3.patch,
SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Ken Gullaksen updated SHRINKWRAP-163:
-------------------------------------
Attachment: SHRINKWRAP-163-v4.patch
Attached SHRINKWRAP-163-v4.patch, with test for user extension
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163-v3.patch,
SHRINKWRAP-163-v4.patch, SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:19 p.m.
New subject: [JBoss JIRA] Resolved: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger resolved SHRINKWRAP-163.
--------------------------------------------
Resolution: Done
This is now done and tested, though the configuration mechanism is going to change.
Address that in another issue so we don't hold up a release.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163-v3.patch,
SHRINKWRAP-163-v4.patch, SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-163) Make archive name optional in ShrinkWrap#create()
[
https://jira.jboss.org/browse/SHRINKWRAP-163?page=com.atlassian.jira.plug...
]
Dan Allen commented on SHRINKWRAP-163:
--------------------------------------
Can I just say...? Awesome.
Make archive name optional in ShrinkWrap#create()
-------------------------------------------------
Key: SHRINKWRAP-163
URL: https://jira.jboss.org/browse/SHRINKWRAP-163
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-9
Reporter: Dan Allen
Assignee: Ken Gullaksen
Fix For: 1.0.0-alpha-10
Attachments: SHRINKWRAP-163-v1.txt, SHRINKWRAP-163-v3.patch,
SHRINKWRAP-163-v4.patch, SHRINKWRAP-163.patch
Make the Archive type first in the API, as it allows us to introduce defaults for the
name and even introduce an extension constant.
ShrinkWrap.create(Class<T> type)
ShrinkWrap.create(Class<T> type, String name)
ShrinkWrap.create(Class<T> type, ExtensionType ext) ***maybe
ShrinkWrap.create(Class<T> type, String name, ExtensionType ext) ***maybe
For the simplest case (Weld SE Arquillian tests for instance), the name would be
defaulted.
ShrinkWrap.create(JavaArchive.class)
The current usage would be flipped
ShrinkWrap.create(JavaArchive.class, "test.jar")
We could consider getting rid of the string-based extension classifier
ShrinkWrap.create(JavaArchive.class, "test", JAR)
Or, if you wanted to specify just an extension (for instance to create a WAR), you could
do:
ShrinkWrap.create(JavaArchive.class, WAR)
To take another angle, maybe the extension can be implied based on the archive type:
JavaArchive = ".jar"
EnterpriseArchive = ".ear"
WebArchive = ".war"
In that case, we can just get back to:
ShrinkWrap.create(WebArchive.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5807
days inactive
5840
days old
shrinkwrap-issues@lists.jboss.org
27 comments
3 participants
participants (3)
-
Andrew Lee Rubinger (JIRA) -
Dan Allen (JIRA)
-
Ken Gullaksen (JIRA)