7:50 p.m.
George Gastaldi created SHRINKRES-91:
----------------------------------------
Summary: Remove JSoup from the dependencies list
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: Andrew Rubinger
Priority: Minor
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:50 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Michal Matloka updated SHRINKRES-91:
------------------------------------
Assignee: Michal Matloka (was: Andrew Rubinger)
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: Michal Matloka
Priority: Minor
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:52 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Michal Matloka updated SHRINKRES-91:
------------------------------------
Assignee: George Gastaldi (was: Michal Matloka)
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:54 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
George Gastaldi updated SHRINKRES-91:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/shrinkwrap/resolver/pull/25
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:06 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Andrew Rubinger updated SHRINKRES-91:
-------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 2.0.0-alpha-6
Resolution: Done
Upstream:
https://github.com/shrinkwrap/resolver/commit/a72cfa95da04ad9c78bae6af5d5...
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Karel Piwko reopened SHRINKRES-91:
----------------------------------
JSoup dependency is included because we try to keep dependencies as flat as possible, as
requested some time ago by JBoss AS development team.
I think we should keep following this rule, hence I'm reopening the bug.
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Karel Piwko updated SHRINKRES-91:
---------------------------------
Attachment: jsoup-dependency.png
Attaching partial dependency graph for maven-impl.
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:44 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
George Gastaldi commented on SHRINKRES-91:
------------------------------------------
Pull request with the reverted commit created
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:44 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
George Gastaldi updated SHRINKRES-91:
-------------------------------------
Status: Pull Request Sent (was: Reopened)
Git Pull Request: https://github.com/shrinkwrap/resolver/pull/27 (was:
https://github.com/shrinkwrap/resolver/pull/25)
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:57 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-91:
------------------------------------------
So we're saying that removing this dependency as explicit doesn't *actually*
remove it as resolved, because it's transitive, yes?
IMO declaring transitive dependencies is silly. An upgrade to wagon-http-lightweight
could conceivably drop this dependency, and then we wouldn't need it anymore.
Managing transitive dependencies explicitly like this is a maintenance burden.
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:59 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
George Gastaldi commented on SHRINKRES-91:
------------------------------------------
+1 with Andrew. Transitive dependencies shouldn't be declared directly in ShrinkWrap.
I don't think this will do any good.
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:49 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-91:
------------------------------------------
Karel, any counter-arguments? Else we'll re-resolve this issue with the explicit
transitive dep removed.
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:12 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Karel Piwko commented on SHRINKRES-91:
--------------------------------------
No counter-arguments, let's keep it simpler. We can change it for AS purposes later on
if they'd still follow shallow dependency graph policy.
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-91?page=com.atlassian.jira.plug...
]
Karel Piwko updated SHRINKRES-91:
---------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Remove JSoup from the dependencies list
---------------------------------------
Key: SHRINKRES-91
URL: https://issues.jboss.org/browse/SHRINKRES-91
Project: ShrinkWrap Resolvers
Issue Type: Task
Components: bom, impl-maven
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Minor
Fix For: 2.0.0-alpha-6
Attachments: jsoup-dependency.png
The JSoup library is not being used anywhere, however it is declared as a dependency in
the shrinkwrap-resolver-impl-maven and the version as a property in the core pom.xml. It
should be probably removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4168
days inactive
4173
days old
shrinkwrap-issues@lists.jboss.org
13 comments
4 participants
participants (4)
-
Andrew Rubinger (JIRA) -
George Gastaldi (JIRA)
-
Karel Piwko (JIRA)
-
Michal Matloka (JIRA)