9:48 a.m.
Switch order of "path" and "source" in Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:55 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira....
]
Jesper Pedersen commented on SHRINKWRAP-61:
-------------------------------------------
Other examples include:
org.jboss.shrinkwrap.api.container.ResourceContainer
- addResource(String)
- addResource(File)
org.jboss.shrinkwrap.api.container.EnterpriseContainer
- addApplicationResource(String)
- addApplicationResource(File)
- addModule(Archive)
- addModule(String)
- addModule(File)
org.jboss.shrinkwrap.api.container.WebContainer
- addWebResource(String)
- addWebResource(File)
org.jboss.shrinkwrap.api.container.ManifestContainer
- addManifestResource(String)
- addManifestResource(File)
Maybe adding a common suffix to each of the above methods to solve the problem
Switch order of "path" and "source" in
Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:07 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira....
]
Andrew Lee Rubinger commented on SHRINKWRAP-61:
-----------------------------------------------
Reference detailing motivation on this issue: Bloch, Effective Java Edition 2 Item 40
Switch order of "path" and "source" in
Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:48 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira....
]
Aslak updated SHRINKWRAP-61:
----------------------------
Fix Version/s: 1.0.0-beta-1
Assignee: Aslak
Switch order of "path" and "source" in
Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Assignee: Aslak
Fix For: 1.0.0-beta-1
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 a.m.
New subject: [JBoss JIRA] Resolved: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira....
]
Aslak resolved SHRINKWRAP-61.
-----------------------------
Resolution: Done
Switch order of "path" and "source" in
Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Assignee: Aslak
Fix For: 1.0.0-beta-1
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:25 a.m.
New subject: [JBoss JIRA] Reopened: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira....
]
Aslak reopened SHRINKWRAP-61:
-----------------------------
missed changes in comment
Switch order of "path" and "source" in
Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Assignee: Aslak
Fix For: 1.0.0-beta-1
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:08 a.m.
New subject: [JBoss JIRA] Resolved: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira....
]
Aslak resolved SHRINKWRAP-61.
-----------------------------
Resolution: Done
new API:
add*('Source', 'Target')
add*('Source')
merge('Source', 'Target')
Switch order of "path" and "source" in
Archive.merge
----------------------------------------------------
Key: SHRINKWRAP-61
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
Project: ShrinkWrap
Issue Type: Task
Components: api, impl-base
Reporter: Andrew Lee Rubinger
Assignee: Aslak
Fix For: 1.0.0-beta-1
Switch:
T merge(Path path, Archive<?> source) throws IllegalArgumentException;
...to:
T merge(Archive<?> source, Path path) throws IllegalArgumentException;
...to match:
T merge(Archive<?> source) throws IllegalArgumentException;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5988
days inactive
6009
days old
shrinkwrap-issues@lists.jboss.org
6 comments
3 participants
participants (3)
-
Andrew Lee Rubinger (JIRA) -
Aslak (JIRA)
-
Jesper Pedersen (JIRA)