[
https://jira.jboss.org/browse/SHRINKWRAP-222?page=com.atlassian.jira.plug...
]
Aslak Knutsen commented on SHRINKWRAP-222:
------------------------------------------
WebAppDef :
Mixed use of Array[] vs Array... as input.
Change order of arguments, Class is always needed so it should be the first argument on
all overloading method:
servlet(Class<? extends javax.servlet.Servlet> clazz, String name, String...
urlPatterns)
servlet(Class<? extends javax.servlet.Servlet> clazz, String... urlPatterns)
servlet(String clazz, String name, String... urlPatterns)
servlet(String clazz, String... urlPatterns)
filter(Class<? extends javax.servlet.Filter> clazz, String name, String...
urlPatterns)
filter(Class<? extends javax.servlet.Filter> clazz, String... urlPatterns)
filter(String clazz, String name, String... urlPatterns)
filter(String clazz, String... urlPatterns)
Result after change:
makes ambiguous overload when calling:
m(String clazz, String name, String... urlPatterns)
m(String clazz, String... urlPatterns) <-- forces user to use new String[]{}
Review Descriptor API consistency
---------------------------------
Key: SHRINKWRAP-222
URL:
https://jira.jboss.org/browse/SHRINKWRAP-222
Project: ShrinkWrap
Issue Type: Feature Request
Components: descriptors
Reporter: Aslak Knutsen
All overloading methods and all Descriptors should follow the same style/pattern when it
comes to naming and arguments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira