[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos reassigned SHRINKWRAP-261: ---------------------------------------- Assignee: Samuel Santos -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Andrew Rubinger updated SHRINKWRAP-261: --------------------------------------- JBoss Forum Reference: http://community.jboss.org/message/596228#596228 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos edited comment on SHRINKWRAP-261 at 6/28/11 12:02 PM: -------------------------------------------------------------------- After discussing it on ShrinkWrap Development forum we decided to go with: {code} Collection<GenericArchive> Maven.artifacts(String... coordinates); GenericArchive Maven.artifact(String coordinate); Maven Maven.withPom(String pomFile); Maven.withPom("pom.xml").artifact("foo:bar"); // no version required there, POM may contain specific remote repositories definitions as well {code} was (Author: Silenius): After discussing it on ShrinkWrap Development forum we decided to go with: Collection<GenericArchive> Maven.artifacts(String... coordinates); GenericArchive Maven.artifact(String coordinate); Maven Maven.withPom(String pomFile); Maven.withPom("pom.xml").artifact("foo:bar"); // no version required there, POM may contain specific remote repositories definitions as well -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos commented on SHRINKWRAP-261: ------------------------------------------ Should Maven class methods be static or should we instantiate it with DependencyResolvers? Option 1: {code} Maven.artifact(String coordinate); // return a GenericArchive {code} Option 2: {code} DependencyResolvers.use(Maven.class).artifact(String coordinate); // return a GenericArchive {code} Since this is a shortcut API I'm more found of option 1. Please comment. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos commented on SHRINKWRAP-261: ------------------------------------------ Unfortunately, we need to keep state in withPom() method (the pomInternalDependencyManagement property), so it cannot be static. Should we go with Option 2 or do you have a better idea? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Karel Piwko commented on SHRINKWRAP-261: ---------------------------------------- Could we make something like? {code} class Maven { public static final GenericArchive artifact(String coords) { return new MavenResolver().artifact(coords); } public static final Collection<GenericArchive> artifacts(String...coords) { return new MavenResolver().artifact(coords); } public static MavenResolver withPom(URL pom) { return new MavenResolver(pom); } public static MavenResolver withPom(String pom) { return new MavenResolver(pom); } } class MavenResolver { // state & constructors public GenericArchive artifact(String coords) {...} public Collection<GenericArchive> artifacts(String coords) {...} // more settings method available here, such as SHRINKWRAP-282 evolves } {code} preferably MavenResolver with package-hidden constructors so user can't use it directly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos edited comment on SHRINKWRAP-261 at 6/29/11 9:21 AM: ------------------------------------------------------------------- I was doing something very similar: {code} public class Maven { public static GenericArchive artifact(String coordinates) throws ResolutionException { // ... } public static Collection<GenericArchive> artifacts(String... coordinates) throws ResolutionException { // ... } public static MavenInternal withPom(String path) throws ResolutionException { // ... } static class MavenInternal { private final MavenRepositorySystem system; private final RepositorySystemSession session; private Map<ArtifactAsKey, MavenDependency> pomInternalDependencyManagement; MavenInternal() { this.system = new MavenRepositorySystem(new MavenRepositorySettings()); this.pomInternalDependencyManagement = new HashMap<ArtifactAsKey, MavenDependency>(); this.session = system.getSession(); } MavenInternal(String path) { this.system = new MavenRepositorySystem(new MavenRepositorySettings()); this.pomInternalDependencyManagement = new HashMap<ArtifactAsKey, MavenDependency>(); this.session = system.getSession(); File pom = new File(path); Model model = system.loadPom(pom, session); ArtifactTypeRegistry stereotypes = session.getArtifactTypeRegistry(); // store all dependency information to be able to retrieve versions later for (org.apache.maven.model.Dependency dependency : model.getDependencies()) { MavenDependency d = MavenConverter.fromDependency(dependency, stereotypes); pomInternalDependencyManagement.put(new ArtifactAsKey(d.getCoordinates()), d); } } // ... } } {code} But you have to make the inner class static or you will get the error {{non-static variable this cannot be referenced from a static context}}. was (Author: Silenius): I was doing something very similar: {code} public class Maven { public static GenericArchive artifact(String coordinates) throws ResolutionException { // ... } public static Collection<GenericArchive> artifacts(String... coordinates) throws ResolutionException { // ... } public static MavenInternal withPom(String path) throws ResolutionException { // ... } static class MavenInternal { private final MavenRepositorySystem system; private final RepositorySystemSession session; private Map<ArtifactAsKey, MavenDependency> pomInternalDependencyManagement; MavenInternal() { this.system = new MavenRepositorySystem(new MavenRepositorySettings()); this.pomInternalDependencyManagement = new HashMap<ArtifactAsKey, MavenDependency>(); this.session = system.getSession(); } MavenInternal(String path) { this.system = new MavenRepositorySystem(new MavenRepositorySettings()); this.pomInternalDependencyManagement = new HashMap<ArtifactAsKey, MavenDependency>(); this.session = system.getSession(); File pom = new File(path); Model model = system.loadPom(pom, session); ArtifactTypeRegistry stereotypes = session.getArtifactTypeRegistry(); // store all dependency information to be able to retrieve versions later for (org.apache.maven.model.Dependency dependency : model.getDependencies()) { MavenDependency d = MavenConverter.fromDependency(dependency, stereotypes); pomInternalDependencyManagement.put(new ArtifactAsKey(d.getCoordinates()), d); } } } } {code} But you have to make the inner class static or would have the error {{non-static variable this cannot be referenced from a static context}}. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos commented on SHRINKWRAP-261: ------------------------------------------ Would you prefer to have the shortcut API on shrinkwrap-resolver-api-maven or shrinkwrap-resolver-impl-maven project? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Samuel Santos updated SHRINKWRAP-261: ------------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/shrinkwrap/shrinkwrap/pull/25 Sent pull request, please comment the code. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-261: -------------------------------------------- {code}(12:46:16 PM) kpiwko: as for 4/, I saw that Samuel actually did a copy of MavenBuilderImpl in his shortcut api...it means that internals are not flexible enough (12:46:46 PM) ALR: Yeah, there's a pending pull request from samaxes on the old Resolver location (12:47:20 PM) kpiwko: so all updates should leverage MavenResolverInteral so developer wanting to wrap it different way can access the internals (12:48:20 PM) kpiwko: the same point for MavenImporter...the problem is that we allow to goOffiline() on two of three impls user can access (12:48:28 PM) kpiwko: this should be consolidated somehow (12:48:37 PM) samaxes: it was done that way at the time because there were some diferences between the shortcut api and the mavenbuilderimpl (12:48:42 PM) ALR: What's the overall task we wanna solve here? (12:48:48 PM) kpiwko: we should have a basic set of operations supported everywhere (12:48:49 PM) ALR: Just the shortcut API (12:48:50 PM) ALR: ? (12:48:54 PM) kpiwko: ALR: jes (12:48:56 PM) kpiwko: yes (12:48:58 PM) samaxes: but i'm not up to date with karel code right now (12:49:09 PM) ALR: OK. How do we want to resolve this? (12:49:23 PM) ALR: I'll bet the first step is to rebase samaxes's work on the new resolver location (12:49:38 PM) jose_freitas: where's the samaxes work ? (12:50:03 PM) jose_freitas: samaxes's* (12:50:10 PM) kpiwko: ALR: iirc I already rebased it after same effort with samaxes (12:50:22 PM) kpiwko: ALR: I should rebase it again on current state (12:50:46 PM) ALR: jose_freitas has a good question; I thought the latest there was in samaxes fork. (12:51:10 PM) kpiwko: ALR: however, I didn't merge because I was concerned about c&p stuff samaxes had to do (12:51:15 PM) samaxes: jose: right now i just have a pull request pending https://github.com/shrinkwrap/resolver/pull/6 (12:51:22 PM) ALR: If not we can rebase against upstream/master and make an upstream/SHRINKWRAP-261 branch (12:51:23 PM) jbossbot: jira [SHRINKWRAP-261] Shorthand for including maven artifacts [Pull Request Sent (Unresolved) Feature Request, Minor, Samuel Santos] https://issues.jboss.org/browse/SHRINKWRAP-261 (12:51:32 PM) ALR: Then we'll all sync on upstream/SW-261 (12:51:36 PM) samaxes: ynot ready to be merged tight now (12:51:42 PM) ALR: And keep it rebased atop master (12:51:42 PM) samaxes: yep, not ready to be merged tight now (12:51:58 PM) ALR: samaxes: OK, cool. Would you like to put some work into getting that back into place (12:51:58 PM) ALR: ? (12:52:13 PM) ALR: And then when it's ready I can make an upstream branch for it, so it doesn't fall out of favor again? (12:52:45 PM) samaxes: yep, just need to sync with karel about the recent changes (12:52:47 PM) kpiwko: or we can release it as a part of 1.1.0 for users who want to use it and fix internals after? (12:53:32 PM) samaxes: it currently does not compile with 1.1.0-alpha-1-SNAPSHOT (12:53:42 PM) samaxes: still uses ArtifactAsKey (12:53:51 PM) jose_freitas: hm (12:54:07 PM) Jaikiran left the room (quit: Remote host closed the connection). (12:55:25 PM) kpiwko: samaxes: isn't it possible to simple take MavenBuilderImpl field and let you're methods properly chain required bits? (12:55:34 PM) kpiwko: sorry, (12:55:42 PM) kpiwko: MavenBuilderImpl as delegate (12:56:16 PM) samaxes: there were some differences between them (12:56:32 PM) samaxes: like not taking transitive dependencies by default (12:57:03 PM) ALR: Let's stay high-level guys :) (12:57:08 PM) jose_freitas: hehe (12:57:09 PM) ALR: The goal is to organize action items. (12:57:21 PM) ALR: So I can open a new issue, or we can make some notes on SW-261 (12:57:41 PM) kpiwko: we have some notes on pull request already (12:57:54 PM) kpiwko: but it makes sense to comment on SW-261 as well (12:58:00 PM) samaxes: agree (12:58:01 PM) kpiwko: no need to make a new issue mpov{code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Karel Piwko updated SHRINKWRAP-261: ----------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: resolver-1.1.0-alpha-1 Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.pl... ] Karel Piwko commented on SHRINKWRAP-261: ---------------------------------------- Or once pom is loaded, {code} Maven.dependency("org.jboss.shrinkwrap.test:test-deps-c:1.0.0") Maven.dependencies("org.jboss.shrinkwrap.test:test-deps-c:1.0.0", "org.jboss.shrinkwrap.test:test-deps-g:1.0.0") Maven.withPom("test-pom.xml").dependency("org.jboss.shrinkwrap.test:test-deps-c") Maven.withPom("test-pom.xml").dependencies("org.jboss.shrinkwrap.test:test-deps-c", "org.jboss.shrinkwrap.test:test-deps-g") {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira