[
https://issues.jboss.org/browse/SHRINKRES-164?page=com.atlassian.jira.plu...
]
Karel Piwko edited comment on SHRINKRES-164 at 2/13/14 3:43 AM:
----------------------------------------------------------------
Thank you very much for the suggestion.
Fixed and pushed upstream in
https://github.com/shrinkwrap/resolver/commit/42f5bff91a27a78c7234ce8af07...
It also supports project.build.sourceEncoding property, that is usually default way how to
setup encoding in Maven projects.
was (Author: kpiwko):
Thank you very much for the suggestion.
Fixed and pushed upstream in
https://github.com/shrinkwrap/resolver/commit/42f5bff91a27a78c7234ce8af07...
Support encoding property from Maven compiler plugin
----------------------------------------------------
Key: SHRINKRES-164
URL:
https://issues.jboss.org/browse/SHRINKRES-164
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Components: impl-maven
Affects Versions: 2.0.2
Reporter: Thilo Mezger
Assignee: Karel Piwko
Fix For: 2.1.0
I'd like to suggest that
org.jboss.shrinkwrap.resolver.impl.maven.archive.plugins.CompilerPluginConfiguration
should support the "encoding" property of the maven-compiler-plugin just like it
supports "source" and "target".
I know that you can use "compilerArgs" to pass any parameter but that
wouldn't be obvious when you have this special "encoding" parameter in
maven-compiler-plugin. Everyone would expect that this setting is passed on.
And things can really go wrong in all magic ways if you compile your files with the wrong
encoding...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira