[
https://jira.jboss.org/browse/SHRINKWRAP-238?page=com.atlassian.jira.plug...
]
Dan Allen commented on SHRINKWRAP-238:
--------------------------------------
It takes some getting used to at first, but if you start with a fresh perspective, it
appears more logical. Here's why.
If you have "addLibrary(String name)", you look at that and say "a string
isn't a library". So the "As" implies that not only will it become a
library, but it will be interpreted as/converted to a library as the archive defines it.
The one case that I can see not using "As" in the method name is when what you
are adding is the same as the target. It appears you've kept consistent on this by
keeping this method the same:
addClass(MyClass.class)
So it looks good to me.
Rename *Container add* methods to be more descriptive
-----------------------------------------------------
Key: SHRINKWRAP-238
URL:
https://jira.jboss.org/browse/SHRINKWRAP-238
Project: ShrinkWrap
Issue Type: Task
Components: api
Reporter: Andrew Rubinger
Assignee: Andrew Rubinger
Fix For: 1.0.0-alpha-12
Make it more clear that we're adding Assets *as* a target type, not *from* some
location.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira