7:34 a.m.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Tommy Tynjä
We need to assure that the test coverage of the SPI module is sufficent. Generally, a code
coverage of 80% is considered an adequate amount, so that should be considered the minimum
acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-68:
-------------------------------------------
Status, Tommy? Still available for this, or I should reassign?
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Tommy Tynjä
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Tommy Tynjä commented on SHRINKDESC-68:
---------------------------------------
I haven't got underway with this yet. Feel free to reassign to whoever might be
interested in it.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Tommy Tynjä
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:56 a.m.
New subject: [JBoss JIRA] Assigned: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Tommy Tynjä reassigned SHRINKDESC-68:
-------------------------------------
Assignee: Bartosz Majsak (was: Tommy Tynjä)
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:06 p.m.
New subject: [JBoss JIRA] Work started: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Work on SHRINKDESC-68 started by Bartosz Majsak.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:38 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Bartosz Majsak updated SHRINKDESC-68:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/shrinkwrap/descriptors/pull/45
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:38 p.m.
New subject: [JBoss JIRA] Work stopped: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Work on SHRINKDESC-68 stopped by Bartosz Majsak.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:40 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-68:
------------------------------------------
EclEmma reports 73.3% now (but somehow it's not giving right coverage for enums). But
what matters more than numbers - I caught two more bugs and covered them by tests.
Things skipped in linked pull request are Importers/Exporters. Should I cover them as
well?
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:56 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Bartosz Majsak edited comment on SHRINKDESC-68 at 9/7/11 5:54 PM:
------------------------------------------------------------------
EclEmma reports 73.3% now (but somehow it's not giving right coverage for enums).
Cobertura reports above 80%. But what matters more than numbers - I caught two more bugs
and covered them by tests.
Things skipped in linked pull request are Importers/Exporters. Should I cover them as
well?
BTW - How about adding this stuff to the build (and CI), if it's not there already?
Maybe also checkstyle/findbugs/pmd? I have some liberal rules already prepared from
different projects.
was (Author: bmajsak):
EclEmma reports 73.3% now (but somehow it's not giving right coverage for enums).
But what matters more than numbers - I caught two more bugs and covered them by tests.
Things skipped in linked pull request are Importers/Exporters. Should I cover them as
well?
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:20 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-68:
-------------------------------------------
It's added to the CI for SW, but there's a bug in the Hudson Cobertura Plugin
which shows incorrect code coverage results (some packages come up as 0%). If you've
got a known better config/plugin I'd love to hear it.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-68:
-------------------------------------------
Yeah, coverage of importers/exporters is great too, we'll take any extra tests
you've got in mind. Ultra valuable.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-68:
------------------------------------------
Ok, I will do some juggling with this stuff soon. Let's leave this issue and pull
request open until we reach higher level. Regarding CI - are you using Cloudbees? Can I
access it somehow?
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:33 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-68:
-------------------------------------------
Partial commits upstream: https://github.com/shrinkwrap/descriptors/pull/45
Do we want to resolve this issue now, do a release, then open a similar issue for the next
release? (That's my preference, so long as coverage tests for the imports/exporters
are likely to *not* result in changes to the SPI itself (internals and bug fixes are
fine)).
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:35 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-68:
-------------------------------------------
CI of Descriptors:
http://jboss.hudson.alrubinger.com/job/Descriptors/
Of SW which has the bad code coverage plugins:
http://jboss.hudson.alrubinger.com/job/ShrinkWrap_Deploy_Site/
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-68:
------------------------------------------
+1 for resolving this one, let's make subtask for Importers/Exporters.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:54 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Tommy Tynjä commented on SHRINKDESC-68:
---------------------------------------
I also think we can resolve this issue, and create new ones as we go forward and when
it's appropriate.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:58 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-68) Improve code coverage for SPI module
[
https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plu...
]
Andrew Rubinger updated SHRINKDESC-68:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.1.0-alpha-6
Resolution: Done
Resolving this to draw a line in the sand and release 1.1.0-beta-1. Further work can go
into 1.2.0-alpha-X series.
Improve code coverage for SPI module
------------------------------------
Key: SHRINKDESC-68
URL: https://issues.jboss.org/browse/SHRINKDESC-68
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Tommy Tynjä
Assignee: Bartosz Majsak
Fix For: 1.1.0-alpha-6
We need to assure that the test coverage of the SPI module is sufficent. Generally, a
code coverage of 80% is considered an adequate amount, so that should be considered the
minimum acceptable threshold.
As this is a general issue it can be added with subtasks for specific parts of the SPI if
needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4643
days inactive
4680
days old
shrinkwrap-issues@lists.jboss.org
16 comments
3 participants
participants (3)
-
Andrew Rubinger (JIRA) -
Bartosz Majsak (JIRA)
-
Tommy Tynjä (JIRA)