[ https://jira.jboss.org/jira/browse/SHRINKWRAP-122?page=com.atlassian.jira... ] Andrew Lee Rubinger commented on SHRINKWRAP-122: ------------------------------------------------ Good contributor issue; perhaps Ken Gullaksen. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/SHRINKWRAP-122?page=com.atlassian.jira... ] Andrew Lee Rubinger edited comment on SHRINKWRAP-122 at 1/24/10 11:38 AM: -------------------------------------------------------------------------- Thanks for the submission! Couple small notes: 1) This covers ZipImporter.importZip(stream); also need a similar one to account for importZip(ZipFile) 2) You don't need to actually get a handle to a real ZIP archive; we could do: new ZipImportStream(new InputStream(){ read(){ throw new IOException("Mock exception"); } }); ...in this way we don't depend upon the implementation of ZipImportStream to throw an exception if read after closed (exceptions for logic flow), and everything is under our control. With at least 1) resolved I'm happy to commit this patch. Welcome. was (Author: ALRubinger): Thanks for the submission! Couple small notes: 1) This covers ZipImporter.importZip(stream); also need a similar one to account for importZip(ZipFile) 2) You don't need to actually get a handle to a real ZIP archive; we could do: new ZipImportStream(new InputStream(){ read(){ throw new IOException("Mock exception"); } }); ...in this way we don't depend upon the implementation of ZipImportStream to throw an exception if read after closed (exceptions for logic flow), and everything is under our control. With at least 1) resolved I'm happy commit this patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/SHRINKWRAP-122?page=com.atlassian.jira... ] Ken Gullaksen updated SHRINKWRAP-122: ------------------------------------- Attachment: SHRINKWRAP-122.patch I agree, this is a much better solution, attaching updated patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/SHRINKWRAP-122?page=com.atlassian.jira... ] Andrew Lee Rubinger commented on SHRINKWRAP-122: ------------------------------------------------ I've cleared up the ArchiveImportException and ZipImporter JavaDoc. Essentially if any unexpected error is encountered during import, we wrap this Exception in ArchiveImportException. Hence this type always has a cause. And the API declares it in ZipImporter.importZip(ZipFile), so we must obey. :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/SHRINKWRAP-122?page=com.atlassian.jira... ] Ken Gullaksen updated SHRINKWRAP-122: ------------------------------------- Attachment: SHRINKWRAP-122.patch Attaching patch: * Added exception handling to importZip(ZipFile) * updated javadoc * test covering importZip(ZipImportStream), ensuring it throws ArchiveImportException on error * test covering importZip(ZipFile), ensuring it throws ArchiveImportException on error -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira