3:59 a.m.
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:11 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Karel Piwko commented on SHRINKWRAP-265:
----------------------------------------
Dependency is overused word there. I would go for
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveTransitivelyAs(T type); // return the Maven artifact and
its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:11 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-265:
--------------------------------------------
Status here?
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:26 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Samuel Santos commented on SHRINKWRAP-265:
------------------------------------------
Hi Andrew, I was waiting/hoping to have more feedback on this discussion:
http://community.jboss.org/thread/164679.
But if we are all aligned on this, I'm ready to start working on these issues.
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:27 p.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Samuel Santos updated SHRINKWRAP-265:
-------------------------------------
Forum Reference: http://community.jboss.org/message/595783,
http://community.jboss.org/thread/164679 (was:
http://community.jboss.org/message/595783#595783)
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:34 p.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Samuel Santos updated SHRINKWRAP-265:
-------------------------------------
Forum Reference: http://community.jboss.org/message/596228,
http://community.jboss.org/thread/164679 (was: http://community.jboss.org/message/595783,
http://community.jboss.org/thread/164679)
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:34 p.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
SBS JIRA Integration updated SHRINKWRAP-265:
--------------------------------------------
Forum Reference: http://community.jboss.org/message/596405#596405,
http://community.jboss.org/thread/164679, http://community.jboss.org/message/596228 (was:
http://community.jboss.org/message/596228, http://community.jboss.org/thread/164679)
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:52 p.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Samuel Santos updated SHRINKWRAP-265:
-------------------------------------
Forum Reference: http://community.jboss.org/message/596405,
http://community.jboss.org/message/596228 (was:
http://community.jboss.org/message/596405#596405,
http://community.jboss.org/thread/164679, http://community.jboss.org/message/596228)
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:59 p.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Samuel Santos commented on SHRINKWRAP-265:
------------------------------------------
Hi Karel,
Should we go ahead and implement something like what we discuss here
http://community.jboss.org/message/602026#602026?
{code}
// Depending on the strategy used, may return "<T extends Archive<T>>
Collection<T>" or "<T extends Archive<T>> T"
MavenDependencyResolver.artifact("foo:bar:1").strategy(TransitiveDependencyResolver.class).resolveAs(T
type [, MavenResolutionFilter filter]);
{code}
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:02 a.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Karel Piwko commented on SHRINKWRAP-265:
----------------------------------------
This should be applied to 2.0.0 branch. I think Strategy is general enough to be a part of
the API package, redefining DependencyResolver API.
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 a.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Karel Piwko commented on SHRINKWRAP-265:
----------------------------------------
Subject to discussion:
Say we have TransitiveDependencyResolver strategy and StrictDependencyResolver strategy.
We can't simply have "<T extends Archive<T>> T" as a return type
for the latter, as user might want to call
{code}
MavenDependencyResolver.artifacts("foo:bar", "foo:barbar")...
{code}
which simply implies multiple dependencies resolved.
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
New subject: [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Karel Piwko updated SHRINKWRAP-265:
-----------------------------------
Fix Version/s: resolver-2.0.0-alpha-1
Forum Reference: http://community.jboss.org/message/596405,
http://community.jboss.org/message/596228 (was:
http://community.jboss.org/message/596405, http://community.jboss.org/message/596228)
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
Fix For: resolver-2.0.0-alpha-1
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:18 a.m.
New subject: [JBoss JIRA] (SHRINKRES-11) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKRES-11?page=com.atlassian.jira.plug...
]
Andrew Rubinger resolved SHRINKRES-11.
--------------------------------------
Resolution: Done
New API has "as()" and "asSingle()", and this is coupled with the
option to "resolve().withTransitivity()" or
"resolve().withoutTransitivity()".
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKRES-11
URL: https://issues.jboss.org/browse/SHRINKRES-11
Project: ShrinkWrap Resolvers
Issue Type: Task
Reporter: Samuel Santos
Assignee: Andrew Rubinger
Fix For: 2.0.0-alpha-2
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4249
days inactive
4782
days old
shrinkwrap-issues@lists.jboss.org
12 comments
8 participants
participants (8)
-
Andrew Rubinger (JIRA) -
Karel Piwko (Commented) (JIRA)
-
Karel Piwko (JIRA)
-
Karel Piwko (Updated) (JIRA)
-
Samuel Santos (Commented) (JIRA)
-
Samuel Santos (JIRA)
-
Samuel Santos (Updated) (JIRA)
-
SBS JIRA Integration (Updated) (JIRA)