[JBoss JIRA] Created: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
1:24 p.m.
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://jira.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to load
fqcn, but then further down the line, I find myself in ContainerBase.addPackages(), which
is called indirectly from the previous addClass method. The addPackages still uses the
TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:04 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Davide D'Alto commented on SHRINKWRAP-244:
------------------------------------------
I can work on this one
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:12 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Davide D'Alto commented on SHRINKWRAP-244:
------------------------------------------
I'm working on this one but I'm not sure how to test it...any suggestions?
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:43 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
David Bosschaert commented on SHRINKWRAP-244:
---------------------------------------------
Hi Davide,
The main thing you need to do is get 2 classloaders. One that can load org.example.MyClass
(or whatever) and another that can't. There are many ways to do that, for example you
can do this by creating a jar file on disk with that class and then create a
URLClassLoader that can load from that jar.
Of the classloader that can't load the class you can use the current class's
classloader (as long as it doesn't load the org.example.MyClass).
Then:
1. create a SW Java Archive instance
2. Set TCCL to the one that *doesn't see* org.example.MyClass
3. Let's say jcl is the classloader that loads the jar file that holds
org.example.MyClass;
4. call archive.addClass("org.example.MyClass", jcl)
5. check the SW Java Archive.
For the other API the sequence is:
1. create a SW Java Archive instance
2. Set TCCL to the one that *doesn't see* org.example.MyClass
3. Let's say jcl is the classloader that loads the jar file that holds
org.example.MyClass;
4. Class<?> cls = jcl.loadClass("org.example.MyClass");
5. call archive.addClass(cls)
6. check the SW Java Archive.
This is off the top of my head, but in general that should do it.
Cheers,
David
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:20 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Davide D'Alto commented on SHRINKWRAP-244:
------------------------------------------
Hi David,
following your suggestion I've added this test:
https://github.com/DavideD/shrinkwrap/blob/SHRINKWRAP-244/impl-base/src/t...
I've created a JAR that contains a class with an inner class and I check that in the
generated archive the inner class is present.
Is it correct?
The problem that I have now is that the class is included in the archive without the inner
class.
It seems that the URLPackageScanner cannot see the inner class in my custom ClassLoader
(even if I load the class in the classloader before adding the class to the archive).
This is where the URLPackageScanner is called to include the inner classes in the
archive:
https://github.com/DavideD/shrinkwrap/blob/SHRINKWRAP-244/impl-base/src/m...
Thanks,
Davide
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:53 a.m.
New subject: [JBoss JIRA] Assigned: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Davide D'Alto reassigned SHRINKWRAP-244:
----------------------------------------
Assignee: Davide D'Alto
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
Assignee: Davide D'Alto
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:53 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Davide D'Alto commented on SHRINKWRAP-244:
------------------------------------------
If I'm not wrong right now ShrinkWrap finds the inner classes looking among the
resources in the classpath (it checks the .class files in the same folder as the class).
In my test I create a Classloader using a JAR file so the inner classes are inside an
archive not visible as resources.
I tried using the method getDeclaredClasses() of Class but it doesn't include the
anonymous inner classes (great unit tests by the way).
Am I missing anything?
Thanks for the help.
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:53 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
David Bosschaert commented on SHRINKWRAP-244:
---------------------------------------------
I'm not sure how the inner class is relevant here. That seems like a completely
different issue...
In general I think the tests look good.
I did leave a comment on the code change you're proposing in
https://github.com/DavideD/shrinkwrap/commit/8c157bcebf6ee543a3a5108a7644...
Probably best to get one of the real ShrinkWrap guys to review your changes too :)
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
Assignee: Davide D'Alto
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:12 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Davide D'Alto commented on SHRINKWRAP-244:
------------------------------------------
I agree, the inner class is not relevant to this issue.
I will fix the thing that you pointed out in the comment on github and then I will leave
at the Shrinkwrap guys the last word :)
Cheers
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
Assignee: Davide D'Alto
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-244:
--------------------------------------------
Commented on the line w/ DavidB. Once complete, ping me and I'll do final review for
push. Overall, just make sure that the Class.getClassLoader is used to load the .class
resource, and all's setty. The explicit CL is only needed when adding a class from a
String arg.
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
Assignee: Davide D'Alto
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:11 p.m.
New subject: [JBoss JIRA] Resolved: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
[
https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.pl...
]
Andrew Rubinger resolved SHRINKWRAP-244.
----------------------------------------
Fix Version/s: 1.0.0-alpha-13
Resolution: Done
Upstream:
https://github.com/shrinkwrap/shrinkwrap/commit/c382f93eae15012c8fce175d2...
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL: https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
Assignee: Davide D'Alto
Fix For: 1.0.0-alpha-13
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4770
days inactive
4926
days old
shrinkwrap-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Andrew Rubinger (JIRA) -
David Bosschaert (JIRA)
-
Davide D'Alto (JIRA)