5:15 p.m.
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:03 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-253:
--------------------------------------------
In the Sun JDK, a null ClassLoader may infer a system/boot/appCL resource. The real
behaviour is not specified by the Class API:
http://download.oracle.com/javase/1.5.0/docs/api/java/lang/Class.html#get...
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:38 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Aslak Knutsen commented on SHRINKWRAP-253:
------------------------------------------
{panel:title=JavaDoc Class.getResourceAsStream}
Finds a resource with a given name. The rules for searching resources associated with a
given class are implemented by the defining class loader of the class. This method
delegates to this object's class loader. If this object was loaded by the bootstrap
class loader, the method delegates to
ClassLoader.getSystemResourceAsStream(java.lang.String).
{panel}
Wouldn't simply using this work as expected?
{code}
return clazz.getResourceAsStream(getResourceNameOfClass(clazz));
{code}
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:31 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-253:
--------------------------------------------
Volunteered to be tackled by Prabin Paudel.
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:26 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Prabin Paudel commented on SHRINKWRAP-253:
------------------------------------------
I guess we don't have to go that far. If a class loader is null, it is a bootstrap
class loader. That means we can just pick the system class loader for delegation:
if(classLoader == null) {
classLoader = ClassLoader.getSystemClassLoader();
}
It should fix the problem.
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:22 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-253:
--------------------------------------------
If the CL is null, it *may be* the Bootstrap CL.
Regardless, I think that's a safe fix, Prabin.
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:33 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Tommy Tynjä commented on SHRINKWRAP-253:
----------------------------------------
I've implemented Prabins suggestion and pushed it to Github:
https://github.com/tommysdk/shrinkwrap/tree/SHRINKWRAP-253
Hadn't time to create a unit test for it now though, and I'm quite unsure how to
create such a test in the first place.
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-253:
--------------------------------------------
Upstream:
https://github.com/shrinkwrap/shrinkwrap/commit/e4e313ce2d41e48d254631025...
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:08 a.m.
New subject: [JBoss JIRA] Resolved: (SHRINKWRAP-253) ClassAsset / ClassLoaderAsset should not use TCCL
[
https://issues.jboss.org/browse/SHRINKWRAP-253?page=com.atlassian.jira.pl...
]
Andrew Rubinger resolved SHRINKWRAP-253.
----------------------------------------
Assignee: Tommy Tynjä
Fix Version/s: 1.0.0-beta-3
Resolution: Done
ClassAsset / ClassLoaderAsset should not use TCCL
-------------------------------------------------
Key: SHRINKWRAP-253
URL: https://issues.jboss.org/browse/SHRINKWRAP-253
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
Assignee: Tommy Tynjä
Fix For: 1.0.0-beta-3
ClassAsset.openStream should not fall back to using TCCL if class.getClassLoader is null.
That means it's a System resource and static ClassLoader.getResourceAsStream should be
used instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4736
days inactive
4863
days old
shrinkwrap-issues@lists.jboss.org
8 comments
4 participants
participants (4)
-
Andrew Rubinger (JIRA) -
Aslak Knutsen (JIRA)
-
Prabin Paudel (JIRA)
-
Tommy Tynjä (JIRA)