[ https://issues.jboss.org/browse/SHRINKWRAP-398?page=com.atlassian.jira.pl... ] Craig Ringer updated SHRINKWRAP-398: ------------------------------------ Attachment: ArquillianShrinkwrapDuplicateAlternatives.zip -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-398?page=com.atlassian.jira.pl... ] Craig Ringer updated SHRINKWRAP-398: ------------------------------------ Labels: alternative arquillian beans beans.xml descriptors shrinkwrap (was: arquillian beans beans.xml descriptors shrinkwrap) Description: Using: org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-impl-javaee:jar:2.0.0-alpha-2 The attached test case produces an invalid beans.xml with a duplicate <alternatives/> entry with the code: {code} BeansDescriptor beansXml = Descriptors.importAs(BeansDescriptor.class) .from(new File("src/main/webapp/WEB-INF/beans.xml")) .getOrCreateAlternatives(); {code} 'getOrCreate' is in fact always creating an alternatives entry, so the following beans.xml is produced in the example: {code} <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <beans xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/beans_1_0.xsd"> <alternatives> <alternative>com.example.shrinkwraptestskeleton.Production</alternative> </alternatives> <alternatives/> </beans> {code} The produced beans.xml descriptor fails at deployment time with: org.jboss.weld.exceptions.DefinitionException: WELD-001203 <alternatives> can only be specified once, but appears multiple times: vfs:/content/demo.jar/META-INF/beans.xml@6 Also: Since there can only ever be one <alternatives/> block, it's not clear what the difference between getOrCreateAlternatives() and createAlternatives() is. Is the latter supposed to *replace* any existing block? The API for managing alternatives is in Descriptors 2.0 is IMO difficult to use and understand. Issues with examples pending. was: Using: org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-impl-javaee:jar:2.0.0-alpha-2 The attached test case produces an invalid beans.xml with a duplicate <alternatives/> entry with the code: {code} BeansDescriptor beansXml = Descriptors.importAs(BeansDescriptor.class) .from(new File("src/main/webapp/WEB-INF/beans.xml")) .getOrCreateAlternatives(); {code} 'getOrCreate' is in fact always creating an alternatives entry, so the following beans.xml is produced in the example: {code} <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <beans xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/beans_1_0.xsd"> <alternatives> <alternative>com.example.shrinkwraptestskeleton.Production</alternative> </alternatives> <alternatives/> </beans> {code} Also: Since there can only ever be one <alternatives/> block, it's not clear what the difference between getOrCreateAlternatives() and createAlternatives() is. Is the latter supposed to *replace* any existing block? The API for managing alternatives is in Descriptors 2.0 is IMO difficult to use and understand. Issues with examples pending. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-115?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-115: -------------------------------------------- Thank you Craig for the detailed description. I will have a look into this issue. S, Ralf -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-115?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKDESC-115: -------------------------------------------- Keep in mind that the notion of "getOrCreate" as an API is likely to change to be more clear in the API refactoring of SWD 2.0 in parallel with SHRINKDESC-116 and SHRINKDESC-21 (prototype work-in-progress in upstream/SHRINKDESC-21). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-115?page=com.atlassian.jira.pl... ] Andrew Rubinger closed SHRINKDESC-115. -------------------------------------- -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira