[JBoss JIRA] Created: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
9:13 a.m.
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The content
is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:06 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-116:
------------------------------------------------
The issue isn't that we're returning an InputStream; it's that we're
backing it with a byte array and thus keeping the full contents in memory. Instead we can
switch to a pull model. @see linked forum discussion for implications.
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger updated SHRINKWRAP-116:
-------------------------------------------
Attachment: SHRINKWRAP-116.patch
Attached patch requires us to rethink whether ArchiveExportException needs to be thrown.
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Attachments: SHRINKWRAP-116.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger updated SHRINKWRAP-116:
-------------------------------------------
JBoss Forum Reference: http://community.jboss.org/thread/146923
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Attachments: SHRINKWRAP-116.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:30 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger updated SHRINKWRAP-116:
-------------------------------------------
Attachment: SHRINKWRAP-116.patch
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Attachments: SHRINKWRAP-116.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:30 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger updated SHRINKWRAP-116:
-------------------------------------------
Attachment: (was: SHRINKWRAP-116.patch)
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Attachments: SHRINKWRAP-116.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:32 p.m.
New subject: [JBoss JIRA] Assigned: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger reassigned SHRINKWRAP-116:
----------------------------------------------
Assignee: Andrew Lee Rubinger
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Assignee: Andrew Lee Rubinger
Attachments: SHRINKWRAP-116.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:26 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger updated SHRINKWRAP-116:
-------------------------------------------
Attachment: SHRINKWRAP-116_OOM.patch
Attached patch w/ test case showing OOM on large archives. Not the post reliable due to
calls to System.gc() and estimating total memory from the runtime; let's see if
it's reliable enough to avoid transient errors in CI.
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Assignee: Andrew Lee Rubinger
Attachments: SHRINKWRAP-116.patch, SHRINKWRAP-116_OOM.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:20 p.m.
New subject: [JBoss JIRA] Resolved: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger resolved SHRINKWRAP-116.
--------------------------------------------
Fix Version/s: 1.0.0-alpha-4
Resolution: Done
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-4
Attachments: SHRINKWRAP-116.patch, SHRINKWRAP-116_OOM.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:09 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Adrian Cole commented on SHRINKWRAP-116:
----------------------------------------
any chance of a new alpha in the near future? I'd like to include this in some
jclouds tooling
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-4
Attachments: SHRINKWRAP-116.patch, SHRINKWRAP-116_OOM.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-116:
------------------------------------------------
Yeah, let's do an alpha when this is fully resolved (from an end-user view) on the
forums.
OOM Exception when exporting large archives using ZIPExporter
-------------------------------------------------------------
Key: SHRINKWRAP-116
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Reporter: Aslak Knutsen
Assignee: Andrew Lee Rubinger
Fix For: 1.0.0-alpha-4
Attachments: SHRINKWRAP-116.patch, SHRINKWRAP-116_OOM.patch
The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The
content is later returned as a ByteArrayInputStream.
This does not work well for larger archives.
The API should be switched:
- do not return a inputstream
- write directly to given outputstream
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5394
days inactive
5401
days old
shrinkwrap-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Adrian Cole (JIRA) -
Andrew Lee Rubinger (JIRA)
-
Aslak Knutsen (JIRA)