[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Martin Kouba updated SHRINKWRAP-369: ------------------------------------ Description: I ran into this issue when working with *Arquillian* and *Weld EE 1.1 Embedded container* (that uses ShrinkWrapClassLoader under the hood). ShrinkWrap correctly builds web archive with CDI extension (using org.jboss.shrinkwrap.api.container.ManifestContainer.addAsServiceProvider(Class<?>, Class<?>...); this was also discussed in SHRINKWRAP-266). Output: {code} test.war /WEB-INF/ /WEB-INF/classes/ /WEB-INF/classes/META-INF/ /WEB-INF/classes/META-INF/services/ /WEB-INF/classes/META-INF/services/javax.enterprise.inject.spi.Extension {code} However no extensions are found. *org.jboss.shrinkwrap.api.classloader.ShrinkWrapClassLoader* probably does not find any resource when looking for "META-INF/services/javax.enterprise.inject.spi.Extension". Note that I'm not quite sure whether it's ShrinkWrapClassLoader or WeldEEMockContainer issue. was: I ran into this issue when working with *Arquillian* and *Weld EE 1.1 Embedded container* (that uses ShrinkWrapClassLoader under the hood). ShrinkWrap correctly builds web archive with CDI extension (this was also discussed in SHRINKWRAP-266). Output: {code} test.war /WEB-INF/ /WEB-INF/classes/ /WEB-INF/classes/META-INF/ /WEB-INF/classes/META-INF/services/ /WEB-INF/classes/META-INF/services/javax.enterprise.inject.spi.Extension {code} However no extensions are found. *org.jboss.shrinkwrap.api.classloader.ShrinkWrapClassLoader* probably does not find any resource when looking for "META-INF/services/javax.enterprise.inject.spi.Extension". Note that I'm not quite sure whether it's ShrinkWrapClassLoader or WeldEEMockContainer issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Martin Kouba commented on SHRINKWRAP-369: ----------------------------------------- This issue applies to WAR. Change your testcase to: {code} /** * SHRINKWRAP-369 */ @Test public void shouldBeAbleToFindServiceProvider() throws Exception { final WebArchive archive = ShrinkWrap.create(WebArchive.class).addAsServiceProvider(Cloneable.class, String.class); System.out.println(archive.toString(true)); final ShrinkWrapClassLoader cl = new ShrinkWrapClassLoader((ClassLoader) null, archive); final Enumeration<URL> found = cl.findResources("META-INF/services/java.lang.Cloneable"); if(found.hasMoreElements()) System.out.println(found.nextElement().toString()); else fail("Resource not found"); } {code} Final archive is: {code} 5a267a22-f1e4-4af8-821f-b00fae01543c.war: /WEB-INF/ /WEB-INF/classes/ /WEB-INF/classes/META-INF/ /WEB-INF/classes/META-INF/services/ /WEB-INF/classes/META-INF/services/java.lang.Cloneable {code} And the resource is not found. The problem is that shrinkwrap builds correct archive however later on when Weld EE Embedded uses ShrinkWrapClassloader to load service providers. Its ServiceLoader (that works BTW in the same way as standard java.util.ServiceLoader) tries to find "META-INF/services/javax.enterprise.inject.spi.Extension" and fails. This was discussed in SHRINKWRAP-266 in detail. In the end the *addAsServiceProvider* method was added in order to add service providers in WEB-INF/classes/META-INF/services. This works ok for archive building but not for loading service providers via ShrinkWrapClassloader. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Martin Kouba commented on SHRINKWRAP-369: ----------------------------------------- I'm not expecting anything ;-). I just say that loading service providers is broken for Weld EE 1.1 Embedded (that uses ShrinkWrapClassloader) and WAR. BTW the same archive deployed to JBoss AS7 works ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Davide D'Alto commented on SHRINKWRAP-369: ------------------------------------------ If I'm not wrong this is a problem of the Weld container not really of the ShrinkWrapClassLoader. The ServiceLoader class only look for services inside the folder META-INF/services and therefore it doesn't work when you use a WAR. https://github.com/arquillian/arquillian-container-weld/blob/master/weld-... I think I have a patch for this but do I have to create a new JIRA for arquilian first? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Martin Kouba commented on SHRINKWRAP-369: ----------------------------------------- Yes, this should work. Although I haven't found any clear specification of how META-INF location in WAR works. JAR file specification does not handle WAR "exception". And for instance Java Persistence 2.0 spec explicitly defines "WEB-INF/classes/META-INF" (see 8.2 Persistence Unit Packaging). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Martin Kouba commented on SHRINKWRAP-369: ----------------------------------------- Davide, I don't get your last comment. The part of CDI spec you mention only states what the bean archive is (where beans.xml must be located). Nothing about extensions or META-INF location in WAR. CDI spec also states: "An extension is a service provider of the service javax.enterprise.inject.spi.Extension declared in META-INF/services." (see 11.5. Container lifecycle events) IMHO this is too general and doesn't say anything about our problem. BTW I read CDI spec everyday since I write TCK tests for it ;-). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-369?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-369: -------------------------------------------- Sample commit to resolve and comment added: https://github.com/DavideD/shrinkwrap/commit/dbf14768086c50181adc4bc248e4... Further opinions and approaches sought, and as explained in the link, I think the best step forward is to make a failing case with the integration point (Weld 1.1. Embedded) to show the problem as reported. Then figure the right level to solve it (which I don't think is as low as ShrinkWrapClassLoader). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira