[ https://issues.jboss.org/browse/SHRINKRES-63?page=com.atlassian.jira.plug... ] Andrew Rubinger updated SHRINKRES-63: ------------------------------------- Description: The location of offline() method in MavenStrategyStage unfortunately does not cover all possible use cases: Imagine the following: User loads a pom - now the first resolution happens, because an effective pom is created and this is later used to define the dependencies: {code}final File[] longhand = Resolvers.use(MavenResolverSystem.class).configureFromPom("path/to/pom").resolve("G:A").offline() .withTransitivity().as(File.class);{code} I don't think that delaying ".configureFromPom("path/to/pom").resolve("G:A")" call until MavenStrategyStage is reached in the right way to go, because that way we couldn't for instance cache already parsed POM file. was: The location of offline() method in MavenStrategyStage unfortunately does not cover all possible use cases: Imagine the following: User loads a pom - now the first resolution happens, because an effective pom is created and this is later used to define the dependencies: final File[] longhand = Resolvers.use(MavenResolverSystem.class).configureFromPom("path/to/pom").resolve("G:A").offline() .withTransitivity().as(File.class); I don't think that delaying ".configureFromPom("path/to/pom").resolve("G:A")" call until MavenStrategyStage is reached in the right way to go, because that way we couldn't for instance cache already parsed POM file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKRES-63?page=com.atlassian.jira.plug... ] Michal Matloka updated SHRINKRES-63: ------------------------------------ Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/shrinkwrap/resolver/pull/17 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKRES-63?page=com.atlassian.jira.plug... ] Karel Piwko resolved SHRINKRES-63. ---------------------------------- Resolution: Done Resolved. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKRES-63?page=com.atlassian.jira.plug... ] Karel Piwko updated SHRINKRES-63: --------------------------------- Fix Version/s: 2.0.0-alpha-5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira