[
https://issues.jboss.org/browse/SHRINKRES-173?page=com.atlassian.jira.plu...
]
Karel Piwko resolved SHRINKRES-173.
-----------------------------------
Resolution: Done
Pushed upstream at
https://github.com/shrinkwrap/resolver/commit/16809f87dd80f2a906665f0ef98....
Moved configuration related calls to configureResolver()
* old methods were kept in place but @Deprecated
* offline() is now workOffline(), offline() is deprecated - I had to rename method
* configureFrom* methods were deprecated in favor of from* methods
present on Factory, as there were called much more frequently
* ConfiguredResolvedSystemFactory was dropped as it was not flexible to
be called for subclasses
So, user does not have to change anything in his tests, although we modified API we are
fully API backwards compatible with previous release.
Configuration methods don't affect pom.xml resolution
-----------------------------------------------------
Key: SHRINKRES-173
URL:
https://issues.jboss.org/browse/SHRINKRES-173
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: api-maven, impl-maven
Affects Versions: 2.0.2
Reporter: Karel Piwko
Assignee: Karel Piwko
Priority: Critical
Fix For: 2.1.0
Maven Resolver allows to control resolution via following methods:
* withCentralRepo(...)
* offline(...)
* withRemoteRepo(...)
* withClasspathResolution(...)
However, with an exception of offline(...) call, all these method can be called in phase
where pom.xml resolution was already done if user call loadPomFrom* method.
This means for example that resolver will touch Maven Central to resolve dependencies in
pom.xml file user is loading.
In order to fix that, these methods should be callable only in configureResolver() phase,
before pom.xml is touched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira