11:14 a.m.
Anti-pattern use of getPackage
------------------------------
Key: SHRINKWRAP-260
URL: https://issues.jboss.org/browse/SHRINKWRAP-260
Project: ShrinkWrap
Issue Type: Bug
Reporter: Carlo de Wolf
ClassContainer.addPackage suffers from an anti-pattern, because Package.getPackage returns
null if no classes have been loaded from that package yet.
As an example see org.jboss.jsfunit.arquillian.JSFUnitApplicationArchiveProcessor.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-260) Anti-pattern use of getPackage
[
https://issues.jboss.org/browse/SHRINKWRAP-260?page=com.atlassian.jira.pl...
]
Aslak Knutsen commented on SHRINKWRAP-260:
------------------------------------------
Workarounds/alternatives exists:
addPackage(String) <-- this is what addPackage(Package) will end up as
or addPackage(Class.getPackage()) <-- to force load (to some extent refactor safe)
Should addPackage(Package) be removed? The above refactor safe example can be rewritten as
addPackage(Class.getPackage().getName())
Anti-pattern use of getPackage
------------------------------
Key: SHRINKWRAP-260
URL: https://issues.jboss.org/browse/SHRINKWRAP-260
Project: ShrinkWrap
Issue Type: Bug
Reporter: Carlo de Wolf
ClassContainer.addPackage suffers from an anti-pattern, because Package.getPackage
returns null if no classes have been loaded from that package yet.
As an example see org.jboss.jsfunit.arquillian.JSFUnitApplicationArchiveProcessor.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:11 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-260) Anti-pattern use of getPackage
[
https://issues.jboss.org/browse/SHRINKWRAP-260?page=com.atlassian.jira.pl...
]
Andrew Rubinger commented on SHRINKWRAP-260:
--------------------------------------------
IMO the limitations of passing around packages should be known by or clearly communicated
to the user via JavaDoc. I think the only other option is to kill "addPackage*"
entirely (to force things to be consistent), but that's not going to fly. Would be
happy seeing documentation added to correct this issue and keep expectations clear with
the end-user.
Anti-pattern use of getPackage
------------------------------
Key: SHRINKWRAP-260
URL: https://issues.jboss.org/browse/SHRINKWRAP-260
Project: ShrinkWrap
Issue Type: Bug
Reporter: Carlo de Wolf
ClassContainer.addPackage suffers from an anti-pattern, because Package.getPackage
returns null if no classes have been loaded from that package yet.
As an example see org.jboss.jsfunit.arquillian.JSFUnitApplicationArchiveProcessor.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4820
days inactive
4820
days old
shrinkwrap-issues@lists.jboss.org
2 comments
3 participants
participants (3)
-
Andrew Rubinger (JIRA) -
Aslak Knutsen (JIRA)
-
Carlo de Wolf (JIRA)