2:48 p.m.
import should close stream
--------------------------
Key: SHRINKDESC-18
URL: https://jira.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-1
Reporter: Dan Allen
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:59 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-18) import should close stream
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Tommy Tynjä commented on SHRINKDESC-18:
---------------------------------------
A bit vague description, but I've commited some code for this issue:
https://github.com/tommysdk/descriptors/commit/d3cc21d1bef153e2579a60a704....
Please review and give me feedback whether this is sufficient or not.
import should close stream
--------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:35 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-18) import should close stream
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-18:
-------------------------------------------
This breaks the symmetry; whomever opened the stream should in general close it. But I
see the value in saving our users the boilerplate when they typically just want to read in
the contents. So let's instead add this in DescriptorImporter:
T from(InputStream in, boolean close);
We'll overload it. The close flag set to false will keep it open so the user may
reset and reuse (if the stream supports it). In the single-argument version, we'll
default to closing the stream. And both methods should be documented to make clear what
we're doing.
Keep in mind the SPI has been refactored, so new patches should take that into account.
import should close stream
--------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:35 p.m.
New subject: [JBoss JIRA] Assigned: (SHRINKDESC-18) import should close stream
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Andrew Rubinger reassigned SHRINKDESC-18:
-----------------------------------------
Assignee: Tommy Tynjä
import should close stream
--------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:35 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Andrew Rubinger updated SHRINKDESC-18:
--------------------------------------
Summary: DescriptorImporter.from(InputStream) should close the IS by default, have
option to leave open (was: import should close stream)
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Dan Allen commented on SHRINKDESC-18:
-------------------------------------
Don't you typically lead with the boolean flags. I'm referring to the ShrinkWrap
archive methods like addPackages(boolean recursive, ...). I'm just bringing it to your
attention...not necessarily saying it should come first in this case.
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:08 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Aslak Knutsen commented on SHRINKDESC-18:
-----------------------------------------
The only reason for boolean first in addPackages is due to the varargs Package..., needs
to be the last argument
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 a.m.
New subject: [JBoss JIRA] Work started: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Work on SHRINKDESC-18 started by Tommy Tynjä.
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Tommy Tynjä commented on SHRINKDESC-18:
---------------------------------------
Proposed solution: https://github.com/tommysdk/descriptors/tree/SHRINKDESC-18
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:02 a.m.
New subject: [JBoss JIRA] Closed: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Andrew Rubinger closed SHRINKDESC-18.
-------------------------------------
Fix Version/s: 1.1.0-alpha-3
Resolution: Done
Upstream:
https://github.com/shrinkwrap/descriptors/commit/c528b95230c7460b643913db...
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
Fix For: 1.1.0-alpha-3
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:02 a.m.
New subject: [JBoss JIRA] Resolved: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Andrew Rubinger resolved SHRINKDESC-18.
---------------------------------------
Resolution: Done
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
Fix For: 1.1.0-alpha-3
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:02 a.m.
New subject: [JBoss JIRA] Reopened: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
[
https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plu...
]
Andrew Rubinger reopened SHRINKDESC-18:
---------------------------------------
DescriptorImporter.from(InputStream) should close the IS by default,
have option to leave open
----------------------------------------------------------------------------------------------
Key: SHRINKDESC-18
URL: https://issues.jboss.org/browse/SHRINKDESC-18
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Affects Versions: 0.1.0
Reporter: Dan Allen
Assignee: Tommy Tynjä
Priority: Minor
Fix For: 1.1.0-alpha-3
The import process should close the stream. After all, the main purpose of providing the
stream is to slurp up all the contents. If the stream is left open, we throw the burden
back on the developer to close it (and all the try/catch block headaches)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5359
days inactive
5639
days old
shrinkwrap-issues@lists.jboss.org
11 comments
4 participants
participants (4)
-
Andrew Rubinger (JIRA) -
Aslak Knutsen (JIRA)
-
Dan Allen (JIRA)
-
Tommy Tynjä (JIRA)