[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Michal Matloka updated SHRINKWRAP-432: -------------------------------------- Description: When archive contains directories, shallow copy throws exception due to {noformat} for (final ArchivePath path : contents.keySet()) { newArchive.add(contents.get(path).getAsset(), path); } {noformat} because add(...) checks {noformat} Validate.notNull(asset, "No asset was specified"); {noformat} was: When archive contains directories, shallow copy throws exception due to { for (final ArchivePath path : contents.keySet()) { newArchive.add(contents.get(path).getAsset(), path); } } because add(...) checks {Validate.notNull(asset, "No asset was specified");} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Michal Matloka updated SHRINKWRAP-432: -------------------------------------- Description: When archive contains directories, shallow copy throws exception due to {noformat} for (final ArchivePath path : contents.keySet()) { newArchive.add(contents.get(path).getAsset(), path); } {noformat} because add(...) checks {noformat} Validate.notNull(asset, "No asset was specified"); {noformat} it is possible that same bug concerns also ArchiveBase.shallowCopy() was: When archive contains directories, shallow copy throws exception due to {noformat} for (final ArchivePath path : contents.keySet()) { newArchive.add(contents.get(path).getAsset(), path); } {noformat} because add(...) checks {noformat} Validate.notNull(asset, "No asset was specified"); {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Michal Matloka updated SHRINKWRAP-432: -------------------------------------- Steps to Reproduce: 1. Create archive, e.g. from zip 2. execute shallowCopy() method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Andrew Rubinger reassigned SHRINKWRAP-432: ------------------------------------------ Assignee: Vineet Reynolds -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Andrew Rubinger updated SHRINKWRAP-432: --------------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: container-glassfish-31-1.0.0-beta-2 1.1.1 Resolution: Done Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/0198e8cbbe7bcd8e7379c629f... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Michal Matloka commented on SHRINKWRAP-432: ------------------------------------------- So with this we omit in copy empty directories? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Vineet Reynolds commented on SHRINKWRAP-432: -------------------------------------------- Yes, that is right. Empty directories that have no nested assets are omitted in the shallow copy. If you have {{META-INF/services/foo}} in the archive where foo is an {{Asset}} (could be an {{EmptyAsset}}), then a shallow copy will have the same structure. But if you have {{META-INF/}} then a shallow copy will omit the {{META-INF/}} directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.pl... ] Vineet Reynolds commented on SHRINKWRAP-432: -------------------------------------------- Well, it appears easy to resolve that. I've tested modified my original change locally, from: {code:java} if (asset != null) { to.add(asset, path); } {code} to: {code:java} if (asset != null) { to.add(asset, path); } else { to.addAsDirectory(path); } {code} This retains the original directories, but I'm not sure if this (use of {{addAsDirectory}}) obeys all the semantics expected of {{shallowCopy()}}. I'll investigate this more closely. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira