[jbosstools-issues] [JBoss JIRA] (JBIDE-19081) Use simpler Surefire include/exclude pattern in parent pom

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262769#comment-13262769 ] 

Nick Boldt commented on JBIDE-19081:
------------------------------------

Using my script, which actually works on a proper linux, I get these results - 10 more test classes, 40 more tests run:

{code}
Before:

Total, Run, Failures, Errors, Skips :: path/to/surefire-reports/class-file.txt
12 12 0 0 0 :: common/tests/org.jboss.tools.common.core.test/target/surefire-reports/org.jboss.tools.common.core.test.CommonCoreTestSuite.txt
53 53 0 0 0 :: common/tests/org.jboss.tools.common.el.core.test/target/surefire-reports/org.jboss.tools.common.el.core.test.CommonELAllTests.txt
45 45 0 0 0 :: common/tests/org.jboss.tools.common.model.test/target/surefire-reports/org.jboss.tools.common.model.test.CommonModelAllTests.txt
25 25 0 0 0 :: common/tests/org.jboss.tools.common.model.ui.test/target/surefire-reports/org.jboss.tools.common.model.ui.test.ModelUiAllTests.txt
1 1 0 0 0 :: common/tests/org.jboss.tools.common.mylyn.test/target/surefire-reports/org.jboss.tools.common.mylyn.test.CommonMylynAllTests.txt
47 47 0 0 0 :: common/tests/org.jboss.tools.common.test/target/surefire-reports/org.jboss.tools.common.test.CommonAllTests.txt
7 7 0 0 0 :: common/tests/org.jboss.tools.common.test/target/surefire-reports/org.jboss.tools.common.zip.test.ZipAllTests.txt
11 11 0 0 0 :: common/tests/org.jboss.tools.common.text.ext.test/target/surefire-reports/org.jboss.tools.common.text.ext.test.TextExtAllTests.txt
12 12 0 0 0 :: common/tests/org.jboss.tools.common.ui.test/target/surefire-reports/org.jboss.tools.common.ui.CommonUITestSuite.txt
4 4 0 0 0 :: common/tests/org.jboss.tools.common.validation.test/target/surefire-reports/org.jboss.tools.common.validation.test.CommonValidationAllTests.txt
1 1 0 0 0 :: common/tests/org.jboss.tools.common.verification.test/target/surefire-reports/org.jboss.tools.common.verification.test.CommonVerificationAllTests.txt
1 0 0 0 1 :: common/tests/org.jboss.tools.common.verification.ui.test/target/surefire-reports/org.jboss.tools.common.verification.ui.test.VerificationUiAllTests.txt
8 8 0 0 0 :: foundation/tests/org.jboss.tools.foundation.checkup.test/target/surefire-reports/org.jboss.tools.foundation.checkup.test.FoundationCheckupTestSuite.txt
12 12 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.test.FoundationAllTests.txt
5 5 0 0 0 :: foundation/tests/org.jboss.tools.foundation.help.test/target/surefire-reports/org.jboss.tools.foundation.help.ui.internal.search.SearchiskoEngineTest.txt
2 2 0 0 0 :: foundation/tests/org.jboss.tools.foundation.ui.test/target/surefire-reports/org.jboss.tools.foundation.ui.test.FoundationUITestSuite.txt
16 16 0 0 0 :: runtime/tests/org.jboss.tools.runtime.test/target/surefire-reports/org.jboss.tools.runtime.test.RuntimeDetectionAllTests.txt
2 2 0 0 0 :: stacks/tests/org.jboss.tools.stacks.core.test/target/surefire-reports/org.jboss.tools.stacks.core.test.StacksAllTests.txt
1 1 0 0 0 :: tests/tests/org.jboss.tools.tests.test/target/surefire-reports/org.jboss.tools.tests.tests.AllTests.txt
29 29 0 0 0 :: usage/tests/org.jboss.tools.usage.test/target/surefire-reports/org.jboss.tools.usage.test.event.EventTestSuite.txt
50 50 0 0 0 :: usage/tests/org.jboss.tools.usage.test/target/surefire-reports/org.jboss.tools.usage.test.UsageTestSuite.txt

Total classes: 21
Total tests run: 343

After:

Total, Run, Failures, Errors, Skips :: path/to/surefire-reports/class-file.txt
12 12 0 0 0 :: common/tests/org.jboss.tools.common.core.test/target/surefire-reports/org.jboss.tools.common.core.test.CommonCoreTestSuite.txt
53 53 0 0 0 :: common/tests/org.jboss.tools.common.el.core.test/target/surefire-reports/org.jboss.tools.common.el.core.test.CommonELAllTests.txt
45 45 0 0 0 :: common/tests/org.jboss.tools.common.model.test/target/surefire-reports/org.jboss.tools.common.model.test.CommonModelAllTests.txt
25 25 0 0 0 :: common/tests/org.jboss.tools.common.model.ui.test/target/surefire-reports/org.jboss.tools.common.model.ui.test.ModelUiAllTests.txt
1 1 0 0 0 :: common/tests/org.jboss.tools.common.mylyn.test/target/surefire-reports/org.jboss.tools.common.mylyn.test.CommonMylynAllTests.txt
47 47 0 0 0 :: common/tests/org.jboss.tools.common.test/target/surefire-reports/org.jboss.tools.common.test.CommonAllTests.txt
7 7 0 0 0 :: common/tests/org.jboss.tools.common.test/target/surefire-reports/org.jboss.tools.common.zip.test.ZipAllTests.txt
11 11 0 0 0 :: common/tests/org.jboss.tools.common.text.ext.test/target/surefire-reports/org.jboss.tools.common.text.ext.test.TextExtAllTests.txt
12 12 0 0 0 :: common/tests/org.jboss.tools.common.ui.test/target/surefire-reports/org.jboss.tools.common.ui.CommonUITestSuite.txt
4 4 0 0 0 :: common/tests/org.jboss.tools.common.validation.test/target/surefire-reports/org.jboss.tools.common.validation.test.CommonValidationAllTests.txt
1 1 0 0 0 :: common/tests/org.jboss.tools.common.verification.test/target/surefire-reports/org.jboss.tools.common.verification.test.CommonVerificationAllTests.txt
1 0 0 0 1 :: common/tests/org.jboss.tools.common.verification.ui.test/target/surefire-reports/org.jboss.tools.common.verification.ui.test.VerificationUiAllTests.txt
7 7 0 0 0 :: foundation/tests/org.jboss.tools.foundation.checkup.test/target/surefire-reports/org.jboss.tools.foundation.checkup.test.JVMProblemDetectorTest.txt
1 1 0 0 0 :: foundation/tests/org.jboss.tools.foundation.checkup.test/target/surefire-reports/org.jboss.tools.foundation.checkup.test.TestEnvironmentDetectorTest.txt
1 1 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.properties.internal.PropertiesProviderFactoryTest.txt
2 2 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.properties.internal.SimpleHierarchicalVersionTest.txt
2 2 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.properties.internal.VersionExtractorTest.txt
8 8 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.txt
5 5 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.test.credentials.CredentialsModelTest.txt
3 3 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.test.digest.DigestUtilsTest.txt
9 9 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.test.ecf.URLTransportUtilTest.txt
15 15 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.test.expressions.ExpressionResolverTest.txt
3 3 0 0 0 :: foundation/tests/org.jboss.tools.foundation.core.test/target/surefire-reports/org.jboss.tools.foundation.core.test.jobs.WaitJobTest.txt
5 5 0 0 0 :: foundation/tests/org.jboss.tools.foundation.help.test/target/surefire-reports/org.jboss.tools.foundation.help.ui.internal.search.SearchiskoEngineTest.txt
2 2 0 0 0 :: foundation/tests/org.jboss.tools.foundation.ui.test/target/surefire-reports/org.jboss.tools.foundation.ui.test.BrowserUtilTest.txt
4 4 0 0 0 :: foundation/tests/org.jboss.tools.foundation.ui.test/target/surefire-reports/org.jboss.tools.foundation.ui.test.WidgetUtilityTest.txt
16 16 0 0 0 :: runtime/tests/org.jboss.tools.runtime.test/target/surefire-reports/org.jboss.tools.runtime.test.RuntimeDetectionAllTests.txt
2 2 0 0 0 :: stacks/tests/org.jboss.tools.stacks.core.test/target/surefire-reports/org.jboss.tools.stacks.core.test.StacksAllTests.txt
1 1 0 0 0 :: tests/tests/org.jboss.tools.tests.test/target/surefire-reports/org.jboss.tools.tests.tests.AllTests.txt
29 29 0 0 0 :: usage/tests/org.jboss.tools.usage.test/target/surefire-reports/org.jboss.tools.usage.test.event.EventTestSuite.txt
50 50 0 0 0 :: usage/tests/org.jboss.tools.usage.test/target/surefire-reports/org.jboss.tools.usage.test.UsageTestSuite.txt

Total classes: 31
Total tests run: 383
{code}

This class has a test which is always skipped. Should that be fixed?

{code}
1 0 0 0 1 :: common/tests/org.jboss.tools.common.verification.ui.test/target/surefire-reports/org.jboss.tools.common.verification.ui.test.VerificationUiAllTests.txt
{code}

> Use simpler Surefire include/exclude pattern in parent pom
> ----------------------------------------------------------
>
>                 Key: JBIDE-19081
>                 URL: https://issues.jboss.org/browse/JBIDE-19081
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Minor
>             Fix For: 4.4.x
>
>
> 1. In JBDS9, use these new default patterns for Surefire to define which test classes to run/exclude:
> {code}
> include = *Test*, *Test, *TestCase
> exclude = *Abstract*
> {code}
> 2. If that causes test failures because running incorrectly named
> abstract stuff, they can refactor, add their own root pom overrides, use
> a TestSuite, or use @Ignore in test classes.
> 3. If the count of tests run suddenly DROPS because the pattern isn't
> running the correct # of tests, they can add their own root pom
> overrides, or use a TestSuite.
> Ref: http://lists.jboss.org/pipermail/jbosstools-dev/2015-January/009688.html



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)