[security-dev] pull request for partition creation
Bill Burke
bburke at redhat.com
Thu Jun 13 18:50:34 EDT 2013
On 6/13/2013 6:40 PM, Pedro Igor Silva wrote:
> I think you did it right. We should use the IMF for that.
>
> We just don't need the test cases you provided. We already have them executed for all stores that support partitions.
>
The test cases I added use a created partition instead of a
pre-configured one. I guess add a new TestSuite
> I think we should also consider a method to obtain all supported partitions. That might be useful if you need to know which of them are already created.
>
The findTier()/findRealm() methods I added return null if the realm or
tier doesn't exist. Also createTier/Realm also return null if the tier
or realm couldn't be created. Wasn't sure if was better to throw an
exception or not.
> I'have started something around that too, but Shane prefers to work on that because of PLINK-130.
>
> One question, don't you need to remove partition as well ?
>
OH ya, I forgot I had put that off. Seems simple enough to implement
for the file case. JPA case seems a bit more involved though.
--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com
More information about the security-dev
mailing list