[infinispan-dev] To make it clear which PRs need attention ...

Dan Berindei dan.berindei at gmail.com
Mon Aug 4 07:54:58 EDT 2014


Nice idea! I am using [1] to monitor the PRs I was involved in, which does
a pretty good job, but it's annoying that it misses some updates (like the
build status, most of the time).

I have one suggestion: most PRs are ready for review the moment they are
issued, so I think that should be the default - no label required.
I would add instead a "Do not integrate yet" label :)


[1] https://prs.paas.allizom.org/infinispan/infinispan


On Mon, Aug 4, 2014 at 11:02 AM, Radim Vansa <rvansa at redhat.com> wrote:

> Great, thanks, Sanne! I was often in-doubt what's the actual status of
> my PR, now I will check these :)
>
> Btw., "Ready for review" suggests that I think that it could be
> integrated after a proper review. There are situations (such as my [1])
> where I need some advice about the PR - should that be considered "Ready
> for review", or would be some label "Advice/Review requested" fit
> better? Of course, having thousand labels is not desirable, that's why I
> am asking how coarse grained this should be.
>
> Radim
>
> [1] https://github.com/infinispan/infinispan/pull/2585
>
> On 08/01/2014 09:50 PM, Sanne Grinovero wrote:
> > .. and from who.
> >
> > It's sometimes unclear which PRs are there in need for review, or
> > which have been commented on and are waiting for fixes / polishing /
> > rebase / denial.
> >
> > Hope these labels help:
> > https://github.com/infinispan/infinispan/pulls
> >
> > And you can bookmark them!
> >
> https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%3A%22Ready+for+Review%22
> >
> > Cheers,
> > Sanne
> > _______________________________________________
> > infinispan-dev mailing list
> > infinispan-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
> --
> Radim Vansa <rvansa at redhat.com>
> JBoss DataGrid QA
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20140804/715e6cce/attachment.html 


More information about the infinispan-dev mailing list