-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
All,
We are planning on merging this feature by Monday next week, if there
are no objections. So, please let me know if there's anything else
that would need a change/improvement.
Thanks!
Juca.
On 02/11/2014 04:40 PM, Juraci Paixão Kröhling wrote:
All,
I've done the proposed changes, and the squashed new branch is
available here:
https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu...
What I'm not sure, however, is whether I need to duplicate the
fields from Visible (will check the JCR spec in the meantime), but
it seems that's indeed a requirement, as I've seen it done in
another inherited type (though, it wasn't a mixin).
I'm specially interested in comments about the code on
NavigationServiceImpl, RestrictAccess and gatein-nodetypes.xml, but
a review on the other parts would be just as awesome :-)
Juca. _______________________________________________ gatein-dev
mailing list gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iQEcBAEBCgAGBQJTAy6uAAoJECKM1e+fkPrXPo4H/2EePwZgNg6DWdiDpIsCfMMR
Z7TQhrtReLiscFuvnZfBRSPboQUOhESSP8VU1ufIJMIKx14FNQ195BFSxaTNRJwP
mGji7NI8p1aw9hpl+9D2dsCKKk3jt7mUVN1YSb0O2x6oE824/wrbFok1b0AX8Xx9
v4qqeT9tmxhKq7zug0nuFBZRSgHekprBCnEMc/j9CrpTgIKBvQp/eKFOI/EveWOk
aKJLtOwcrvl0YZKfQwwmMhnrQUVchnsl+IIASUHBPi/OxDC6OtTiA1+9N3OZtO7g
wpHEIZtBFptnbJy4AURGa513NNy4AW644OYAjz9EW1NDdZweUNjbEW8LJsB6ybI=
=lgYe
-----END PGP SIGNATURE-----