[gatein-dev] Review Request - Page Composition API (was Re: RFC - Page Composition API)

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 All, Work on this task has been almost completed, so, I'd like to ask you to take a look at the implementation on the following branches, and see if you'd suggest a change somewhere. https://github.com/jpkrohling/gatein-api-java/compare/BZ1043858-ComposeAPI https://github.com/jpkrohling/gatein-portal/compare/BZ1043858-ComposeAPI Note that there's a sample portlet called ComposePageDemoPortlet, which would possibly *not* ship with the final version. I'd also like to hear your comments about it. The upside on shipping is that it's a very simple portlet, whose only purpose is to create a page. It doesn't even attaches this page to a navigation node, so, people can easily consume this information and adapt to their needs. The downside is that it's not a real world example. Perhaps we could ship this demo portlet this way, and prepare a more complete quickstart, to compensate. WDYT? Another question is about the versioning for the API: the only part that changed the current API code is on the "savePage" method, with a pair of calls to dataStorage.save(). I'll be doing some tests on the next couple of days, to see if it badly affects the current users of the API, but assuming that it doesn't (or that we can skip those lines if the page doesn't contains containers), what should be the next version number for the API? A bump on the revision part? Minor? - - Juca. On 01/16/2014 12:26 PM, Juraci Paixão Kröhling wrote: