Re: [gatein-dev] Change Modal/Popup Behaviour

I take silence to mean acceptance :) I will submit a PR for this soon if I don't hear any objections.

Thanks, Matt Wringe On 29/05/13 11:44 AM, Matt Wringe wrote: > The current behaviour of how the classic site handles modals (eg popups) > doesn't work well on mobile or touch based devices. > > On the classic site, the modals are positioned on the page via > javascript and are configured to center the content when the browser > window's size has changed or a scroll event has occurred. > > On mobile devices, when entering a form the device will scroll the page > to make room for the on-screen keyboard. > > When a mobile device accesses a modal on the classic site, the page gets > scrolled via the browser for the on-screen keyboard and then the > portal's javascript will re-position the modal due to this scroll. This > modal is then always hidden behind the keyboard and it becomes unusuable. > > A fix would be to remove the vertical movement during a scroll. The > horizonal movement will still exist and the modal is centered on the > page when it is first created, but it will no longer reposition itself > vertically afterwards. Since this is a behaviour change (and could be > reviewed as a feature regression) and I asking what people's thoughts > are on this and if people have a different idea on how to handle it. > > jira: https://issues.jboss.org/browse/GTNPORTAL-3079 > branch which remove vertical movement on scroll: > https://github.com/mwringe/gatein-portal/tree/GTNPORTAL-3079 > > Thanks, > > Matt Wringe > > NB: the mobile site does something different with all of this and uses a > purely css based solution to center the content horizontally and > vertically, but this solution doesn't work nicely with the fixed layout > of the classic site. > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/gatein-dev _______________________________________________ gatein-dev mailing list gatein-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/gatein-dev