On 2013-10-14 13:46, Phuong Viet VU wrote:
ok, I have some more comments:
1. I see that "root" user can do anything, even when we set "nobody"
for
move*-application and move*-container. But the specification say that it
can prevent "root" user.
No, the spec says that <move-*-permissions>Nobody</move-*-permissions>
forbids the actions to everyone _except for_ root. So, the present
implementation works as specified.
2. I can't DnD new App and Container to portal-layout (run gatein
with
extension).
When I create page with "Add page" wizard, choose "Two columns"
layout
--> Can't DnD new container to the Page, even there is
"HasMoveContainersPermissions" class
Sorry, this part of JavaScript was broken since Friday. It must work now.
3. The feature only work if we create page from templates. But
GateIn
also allow to create page with-out template:
by using "Page management" portlet, or when using navigation editor -->
create node --> create page. It create a page with-out template, and the
move* permission is null --> no way to DnD Apps and Container to the
newly created page. And we don't have UI support to set the move* permission
I agree that at some point, we need to add a UI for the management of
the new permissions. But it is out of scope ATM.
With the present spec, I guess, the customer will be able to hide the
alternative ways to create pages from user groups that are supposed to
use the "template way". Thomas?
And finally, I agree that the page creation with null move* permissions
from Page management and navigation editor is not correct. I have
changed it to use ProtectedContainer.DEFAULT_MOVE_*_PERMISSIONS, see []
Do you know of other places where I should do the same?
[1]
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
Thanks,
Peter
On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Thanks for the message, Phuong. I'll have a look what is the
problem. -- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
Hi, I'm trying "Restricted" page editor feature (build with
tomcat7 -->
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>)
I tried GateIn without the extension
(
https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<
https://github.com/ppalaga/gatein-restricted-page-editor-extension>)
-->
It should works the same as before this feature, right ?
1. After login as root, go to home page, edit portal layout -->
I can't
DnD page-body to another place, it always stay in the same place
2. Try to drop new Row container, and new application to the
page, then
move them around --> Exception in the console
143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication -
Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.__portal.__UIPortalComponentActionListene__r$MoveChildActionListener.__prepareUiSource(__UIPortalComponentActionListene__r.java:300)
at
org.exoplatform.portal.webui.__portal.__UIPortalComponentActionListene__r$MoveChildActionListener.__execute(__UIPortalComponentActionListene__r.java:239)
at org.exoplatform.webui.event.__Event.broadcast(Event.java:97)
at
org.exoplatform.webui.core.__lifecycle.Lifecycle.__processAction(Lifecycle.java:__51)
at
org.exoplatform.webui.core.__UIComponent.processAction(__UIComponent.java:119)
at
org.exoplatform.portal.webui.__workspace.__UIPortalApplicationLifecycle.__processAction(__UIPortalApplicationLifecycle.__java:73)
at
org.exoplatform.portal.webui.__workspace.__UIPortalApplicationLifecycle.__processAction(__UIPortalApplicationLifecycle.__java:36)
On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>> wrote:
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
: The new
permissions are enforced also during deletions now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
> Hi,
>
> We are going to take a look at this and will give you
feedback on
Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>>
wrote:
>
> Hi *,
>
> it would be nice if someone from eXo could have a
look at
this. Please
> note that we cannot wait for long. We have decided
to do a
RH-internal
> cross-checking with Lucas and if there is no message
from eXo
after we
> are finished with the checks, I'll merge it without
waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11, Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an extensive patch. Could please
somebody have
a look
> at it?
> >
> >
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
> >
> > It implements a requirement from a customer as
described in
> >
> >
https://community.jboss.org/__wiki/RestrictedPageEditor
<
https://community.jboss.org/wiki/RestrictedPageEditor>
> >
> > To see the behavior requested by the customer,
you should
build the
> > portal from my GTNPORTAL-3263.3 branch and run AS
with this
> extension:
> >
> >
https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<
https://github.com/ppalaga/gatein-restricted-page-editor-extension>
> >
> > Thanks,
> >
> > Peter
> > _________________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
> >
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<
https://lists.jboss.org/mailman/listinfo/gatein-dev>
> >
>
> _________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
>
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<
https://lists.jboss.org/mailman/listinfo/gatein-dev>
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 | /trongtt(a)gmail.com
<mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>>
>
Twitter:http://twitter.com/__trongtt//
<
http://twitter.com/trongtt//>
_________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<
https://lists.jboss.org/mailman/listinfo/gatein-dev>