Re: [gatein-dev] Request for review: GTNPORTAL-3459 Permissions Move Apps, Move Containers are not inherited to a newly created page

Hi, yes, you're right, we should have the move* permission inherited I've just rebuild and run GateIn master with PR from GTNPORTAL-3459. But there is NPE in the console. Step to reproduce - Login as root, create a portal site "TestSite" - Go to "Page management" page, and Click "Add new page" --> NPE in the console [http-bio-8080-exec-8] ERROR portal:UIPortalApplication - Error during the processAction phase java.lang.NullPointerException at org.exoplatform.portal.webui.page.UIPageForm$ChangeOwnerTypeActionListener.execute(UIPageForm.java:377) at org.exoplatform.webui.event.Event.broadcast(Event.java:97) at org.exoplatform.portal.webui.page.UIPageBrowser$AddNewActionListener.execute(UIPageBrowser.java:373) at org.exoplatform.webui.event.Event.broadcast(Event.java:97) On Mon, Apr 28, 2014 at 2:37 PM, Peter Palaga <ppalaga(a)redhat.com&gt; wrote: > Hi *, I will merge this today after 16:00 CEST unless somebody raises his > hand. -- PP > > > On 2014-04-24 15:09, Peter Palaga wrote: > >> Hi *, >> >> from my PoV this is a follow up of GTNPORTAL-3364 "Implement UI part for >> Restricted layout setting" done by nttuyen. >> >> The present issue: >> https://issues.jboss.org/browse/GTNPORTAL-3459 >> >> When creating new portal site, there are 4 permissions to set - Access, >> Edit, Move Apps, Move Containers. When I create new portal and set some >> permissions, then create new page in this portal, the owner of the new >> page is the newly created portal, and Access and Edit permissions are >> inherited or "copied" into the permissions of the new page. But Move >> Apps, Move Containers permissions are set to "Everyone". This >> permissions should probably also inherit the permissions from the owning >> portal. >> Steps to reproduce: >> 1. Create new portal site, set some permissions >> 2. Go to this new portal site, create new page. On the 3rd step of >> creating the page, in View Page Properties, Permissions tab are >> inherited only Access and Edit permissions. >> >> Could you please review my fix? >> https://github.com/gatein/gatein-portal/pull/841 >> >> Thanks, >> >> Peter >> _______________________________________________ >> gatein-dev mailing list >> gatein-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/gatein-dev >> >> >