Hi,
Great that you have it working on Tomcat. I have some minor comments:
- Names of your classes like SPNEGOFilter, SPNEGOLoginModule etc are
same like already existing classes inside gatein-sso. How about renaming
them to something like TomcatSPNEGOFilter, TomcatSPNEGOLoginModule etc?
- there are 3 configuration files where is SPNEGOFilter defined and it
seems that it's needed just inside extension. So it seems that this
whole directory
https://github.com/nttuyen/gatein-spnego/tree/master/spnego-jar/src/main/...
could be removed?
- Very minor - I noticed invalid log class here:
https://github.com/nttuyen/gatein-spnego/blob/master/spnego-jar/src/main/...
Place where to put it: I am not sure. In current form, it can't be put
inside gatein-sso because it has dependencies on some gatein-portal
artifacts. It should be possible to remove it if you want to do some
more changes in your code and perhaps change instructions (For example
use SSOInterceptor like other stuff inside gatein-sso instead of
org.exoplatform.web.filter.Filter). So in current state, I would suggest
to put it inside some separate directory inside gatein-toolbox or inside
some separate directory in gatein-portal.
Marek
On 13.5.2014 12:17, Bolesław Dawidowicz wrote:
Marek is away this week and I would prefer that he takes a look at
it.
On 05/13/2014 09:32 AM, Tuyen The Nguyen wrote:
> Hi all,
>
> We are trying to make SPNEGO SSO work on gatein tomcat packaging.
>
> Unfortunately, current spnego sso implementation of gatein only works on
> jboss because it use Jboss Negotiation library - a specific library for
> jboss.
>
> So, i provide other spnego implementation for gatein tomcat packaging at
>
https://github.com/nttuyen/gatein-spnego, this implementation works as
> an extension and i tested it on master and 3.7.x branch.
>
> If there some one can review and have any feedback, i would appreciate.
> Btw, is there any idea about where this implementation should be in
> gatein codebase?
>
> Thanks!
>
> TuyenNT.
>
>
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/gatein-dev
>