FYI, I just pushed my work on GTNPORTAL-3246
On 21 August 2013 19:06, Adam Kovari <akovari(a)redhat.com> wrote:
Hi Tran,
thank you very much. I'll wait for your PR then(Added myself to the new
Jira).
Regards,
----- Original Message -----
From: "Trong Tran" <trongtt(a)gmail.com>
To: "Adam Kovari" <akovari(a)redhat.com>
Cc: "gatein-dev" <gatein-dev(a)lists.jboss.org>
Sent: Wednesday, August 21, 2013 1:57:18 PM
Subject: Re: Review of GTNPORTAL-3156
Hi Adam,
First sorry for my late response.
On 20 August 2013 14:41, Adam Kovari <akovari(a)redhat.com> wrote:
> Hi Tran,
>
> I'm sorry to bother again, just one more small thing, hopefully this is
> the last one:
>
>
https://github.com/gatein/gatein-portal/pull/625
>
> I have added:
> + if(maximizedUIComponent.getAncestorOfType(UIPage.class) ==
> getUIComponent()) {
> +
> maximizedUIComponent.processRender((WebuiRequestContext)
> WebuiRequestContext.getCurrentInstance());
> + return;
> + }
>
> into UIPageBody.processRender because without this if you have one
> maximized portlet and go to another page, then it would still display
> the maximized portlet from the first page even if this portlet doesn't
> exist at that page at all!
>
I guess this problem is a regression introduced from the fix of
https://issues.jboss.org/browse/GTNPORTAL-3182
You have fixed it partially. I find there is another problem that currently
the only maximized portlet state of last page is kept. I just created JIRA
issue GTNPORTAL-3246 and going to work on this. I would like to remove the
duplication of maintaining maximized component in both UIPageBody and
UIPage on the same occasion
> I hope this is ok, I just want to make sure that I can do this check for
> maximizedUIComponent.getAncestorOfType(UIPage.class) and assume it
> should be equal to uiComponent in the UIPageBody class.
>
> Maybe I'm forgetting of some other usecase or this will always work?
>
> It works fine for what I've tested.
>
>
> Thanks,
>
>
> On Friday 16 August 2013 23:54:25 Trong Tran wrote:
> >Hello Adam,
> >
> >This is a concurrency problem of parallel requests on different nav
> >node. UIPage objects are cached now for performance, when you move
> >from nav node A -> B, the UIPage A takes off from the tree and B will
> >be replaced.
> >
> >So the proper fix would be to simply replace
> >getAncestorOfType(UIPortalApplication.class) by
> >Util.getUIPortalApplication() in the #getSuitedTheme.
> >
> >Thanks
> >
> >On 15 August 2013 15:53, Adam Kovari <akovari(a)redhat.com> wrote:
> >> Hi Tran,
> >>
> >> when you have a moment, could you please review my PR 625 for
> >> GTNPORTAL-3156?
> >>
> >>
https://issues.jboss.org/browse/GTNPORTAL-3156
> >>
https://github.com/gatein/gatein-portal/pull/625
> >>
> >>
> >> Thanks,
> >>
> >> --
> >> Adam Kovari
> --
> Adam Kovari
>
>
--
*Trong Tran*
*(+84) 983841909 | *trongtt(a)gmail.com
Twitter:
http://twitter.com/trongtt**
--
Adam Kovari