September 2011 - shrinkwrap-issues

[JBoss JIRA] Created: (SHRINKDESC-68) Improve code coverage for SPI module

by Tommy Tynjä (JIRA)

Improve code coverage for SPI module ------------------------------------ Key: SHRINKDESC-68 URL: https://issues.jboss.org/browse/SHRINKDESC-68 Project: ShrinkWrap Descriptors Issue Type: Task Reporter: Tommy Tynjä Assignee: Tommy Tynjä We need to assure that the test coverage of the SPI module is sufficent. Generally, a code coverage of 80% is considered an adequate amount, so that should be considered the minimum acceptable threshold. As this is a general issue it can be added with subtasks for specific parts of the SPI if needed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

3
16
0 / 0

[JBoss JIRA] Created: (SHRINKDESC-88) Hide Away Pattern/Query from SPI

by Andrew Rubinger (JIRA)

Hide Away Pattern/Query from SPI -------------------------------- Key: SHRINKDESC-88 URL: https://issues.jboss.org/browse/SHRINKDESC-88 Project: ShrinkWrap Descriptors Issue Type: Task Affects Versions: 1.1.0-alpha-5 Reporter: Andrew Rubinger Assignee: Andrew Rubinger Fix For: 1.1.0-alpha-6 Discussion: https://github.com/shrinkwrap/descriptors/commit/8ed82c896468eab53c3b0a65... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

1
1
0 / 0

[JBoss JIRA] Created: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree

by Aslak Knutsen (JIRA)

Node.get(Patterns) matches recursive down the whole tree -------------------------------------------------------- Key: SHRINKDESC-84 URL: https://issues.jboss.org/browse/SHRINKDESC-84 Project: ShrinkWrap Descriptors Issue Type: Bug Affects Versions: 1.1.0-alpha-3 Reporter: Aslak Knutsen Priority: Critical Fix For: 1.1.0-alpha-4 Node.get should only try to match the first level. {code} @Test public void shouldNotMatchAChildsChildrenOnQuery() { // /root/child1/child2 Node root = new Node(ROOT_NAME) .createChild(CHILD_1_NAME) .createChild(CHILD_2_NAME).getRoot(); // this Assert fails Assert.assertNull(root.get(CHILD_2_NAME)); } {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

3
20
0 / 0

[JBoss JIRA] Created: (SHRINKDESC-87) Refactor Queries to enum-based Singletons

by Andrew Rubinger (JIRA)

Refactor Queries to enum-based Singletons ----------------------------------------- Key: SHRINKDESC-87 URL: https://issues.jboss.org/browse/SHRINKDESC-87 Project: ShrinkWrap Descriptors Issue Type: Task Affects Versions: 1.1.0-alpha-5 Reporter: Andrew Rubinger Assignee: Bartosz Majsak Introduced by fixes to SHRINKDESC-84, account for thread safety and employ a singleton approach (implemented w/ enums) for all Query impls in the SPI. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

1
1
0 / 0

[JBoss JIRA] Commented: (SHRINKWRAP-299) addAsResources() does not remove /classes segment when adding output directory to deployment

by Geoffrey De Smet (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-299?page=com.atlassian.jira.pl... ] Geoffrey De Smet commented on SHRINKWRAP-299: --------------------------------------------- @aslak +1 for "target" means add the directory and it's children "target/" means add the children The javadoc on the method should clearly state this. > addAsResources() does not remove /classes segment when adding output directory to deployment > -------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-299 > URL: https://issues.jboss.org/browse/SHRINKWRAP-299 > Project: ShrinkWrap > Issue Type: Bug > Affects Versions: 1.0.0-beta-3 > Reporter: Lincoln Baxter III > > {code} > @Deployment(testable = false) > public static WebArchive getDeployment() > { > return ShrinkWrap > .create(WebArchive.class, "rewrite-test.war") > .addAsResource(new File("../api/target/classes/com")) > .addAsResource(new File("../api/target/classes/META-INF")) > .addAsResource(new File("../impl-servlet/target/classes/com")) > .addAsResource(new File("../impl-servlet/target/classes/META-INF")) > .addAsLibraries(DependencyResolvers.use(MavenDependencyResolver.class) > .artifacts("org.jboss.weld.servlet:weld-servlet:1.1.1.Final") > .resolveAs(GenericArchive.class)) > .setWebXML("jetty-web.xml") > .addAsWebResource( > new StringAsset("<beans/>"), > ArchivePaths.create("WEB-INF/beans.xml")) > .addAsWebResource("jetty-env.xml", > ArchivePaths.create("WEB-INF/jetty-env.xml")); > } > {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

1
0
0 / 0

[JBoss JIRA] Commented: (SHRINKWRAP-299) addAsResources() does not remove /classes segment when adding output directory to deployment

by Aslak Knutsen (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-299?page=com.atlassian.jira.pl... ] Aslak Knutsen commented on SHRINKWRAP-299: ------------------------------------------ Should addAsResource("target") end up adding the "target" directory and it's children, or should it function like "target/*"; only add children. "resource-location"/target/child vs "resource-location"/child I think in most cases you don't want to include the added folder it self, but it's children. We could reuse the ssh copy concepts from linux here. "target" means add the directory and it's children "target/" means add the children > addAsResources() does not remove /classes segment when adding output directory to deployment > -------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-299 > URL: https://issues.jboss.org/browse/SHRINKWRAP-299 > Project: ShrinkWrap > Issue Type: Bug > Affects Versions: 1.0.0-beta-3 > Reporter: Lincoln Baxter III > > {code} > @Deployment(testable = false) > public static WebArchive getDeployment() > { > return ShrinkWrap > .create(WebArchive.class, "rewrite-test.war") > .addAsResource(new File("../api/target/classes/com")) > .addAsResource(new File("../api/target/classes/META-INF")) > .addAsResource(new File("../impl-servlet/target/classes/com")) > .addAsResource(new File("../impl-servlet/target/classes/META-INF")) > .addAsLibraries(DependencyResolvers.use(MavenDependencyResolver.class) > .artifacts("org.jboss.weld.servlet:weld-servlet:1.1.1.Final") > .resolveAs(GenericArchive.class)) > .setWebXML("jetty-web.xml") > .addAsWebResource( > new StringAsset("<beans/>"), > ArchivePaths.create("WEB-INF/beans.xml")) > .addAsWebResource("jetty-env.xml", > ArchivePaths.create("WEB-INF/jetty-env.xml")); > } > {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

1
0
0 / 0

[JBoss JIRA] Created: (SHRINKWRAP-323) Update load*From* methods to be more generic using a path qualifier

by Karel Piwko (JIRA)

Update load*From* methods to be more generic using a path qualifier ------------------------------------------------------------------- Key: SHRINKWRAP-323 URL: https://issues.jboss.org/browse/SHRINKWRAP-323 Project: ShrinkWrap Issue Type: Feature Request Components: ext-resolver Reporter: Karel Piwko Assignee: José Freitas Fix For: resolver-1.1.0-alpha-1 Replace current multiple load* methods with a single method which determines type of the resource on a qualifier base: * classpath: retrieve resource from classpath * file: retrieve resource from filesystem * -no-qualifier-: retrieve from filesystem, as default behavior -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

1
1
0 / 0

[JBoss JIRA] Created: (SHRINKDESC-85) Decouple NodeImporter and DescriptorImporter Design Concepts

by Andrew Rubinger (JIRA)

Decouple NodeImporter and DescriptorImporter Design Concepts ------------------------------------------------------------ Key: SHRINKDESC-85 URL: https://issues.jboss.org/browse/SHRINKDESC-85 Project: ShrinkWrap Descriptors Issue Type: Task Affects Versions: 1.1.0-alpha-3 Reporter: Andrew Rubinger Assignee: Andrew Rubinger Fix For: 1.1.0-alpha-4, 1.2.0-alpha-1 NodeImporter only needs to return a root Node from a source, does not need to know anything about endUserImpl views or similar. Decouple these design concepts such that a DescriptorImporter can *use* a NodeImporter, not *be* one. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 7 months

1
1
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues September 2011