November 2013 - shrinkwrap-issues

[JBoss JIRA] (SHRINKRES-155) MavenImporer flattens structure of resources

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-155?page=com.atlassian.jira.plu... ] Karel Piwko updated SHRINKRES-155: ---------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/shrinkwrap/resolver/pull/57 > MavenImporer flattens structure of resources > -------------------------------------------- > > Key: SHRINKRES-155 > URL: https://issues.jboss.org/browse/SHRINKRES-155 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.0.0 > Reporter: Karel Piwko > Assignee: Karel Piwko > > *When*: > I have resources likes > * src/main/resources/foo.properties > * src/main/resources/nested/bar.properties > *Expect*: > WAR Archive have these entries as: > * /WEB-INF/classes/foo.properties > * /WEB-INF/classes/nested/bar.properties > *Current behavior*: > * /WEB-INF/classes/foo.properties > * /WEB-INF/classes/nested > * /WEB-INF/classes/bar.properties -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-99) Add support for applying includes/excludes when defining package resource

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-99?page=com.atlassian.jira.plug... ] Karel Piwko reassigned SHRINKRES-99: ------------------------------------ Assignee: Karel Piwko > Add support for applying includes/excludes when defining package resource > ------------------------------------------------------------------------- > > Key: SHRINKRES-99 > URL: https://issues.jboss.org/browse/SHRINKRES-99 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Reporter: Karel Piwko > Assignee: Karel Piwko > > SHRINKRES-61 does not honor <includes> and <excludes> from pom.xml file. Therefore, the resulting archive might not 100% match the archive build by Maven. > {code:xml} > <resource> > <includes> > </includes> > <excludes> > </excludes> > </resource> > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-155) MavenImporer flattens structure of resources

by Karel Piwko (JIRA)

Karel Piwko created SHRINKRES-155: ------------------------------------- Summary: MavenImporer flattens structure of resources Key: SHRINKRES-155 URL: https://issues.jboss.org/browse/SHRINKRES-155 Project: ShrinkWrap Resolvers Issue Type: Bug Components: impl-maven Affects Versions: 2.0.0 Reporter: Karel Piwko Assignee: Karel Piwko *When*: I have resources likes * src/main/resources/foo.properties * src/main/resources/nested/bar.properties *Expect*: WAR Archive have these entries as: * /WEB-INF/classes/foo.properties * /WEB-INF/classes/nested/bar.properties *Current behavior*: * /WEB-INF/classes/foo.properties * /WEB-INF/classes/nested * /WEB-INF/classes/bar.properties -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-154) Nonclear description in README.asciidoc for system environment properties

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-154?page=com.atlassian.jira.plu... ] Andrew Rubinger updated SHRINKRES-154: -------------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: 2.1.0 Resolution: Done Upstream: https://github.com/shrinkwrap/resolver/commit/e6760fd7ca8489efab0ec373a54... > Nonclear description in README.asciidoc for system environment properties > ------------------------------------------------------------------------- > > Key: SHRINKRES-154 > URL: https://issues.jboss.org/browse/SHRINKRES-154 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Environment: master branch of https://github.com/shrinkwrap/resolver > Reporter: Marek Novotny > Assignee: Andrew Rubinger > Fix For: 2.1.0 > > > https://github.com/shrinkwrap/resolver#system-properties for _org.apache.maven.user-settings_ property description states that > bq. Path to user settings.xml file. In case both settings are provided, they are merged, user one has the priority. > And without reading the following description for _org.apache.maven.global-settings_ property it is not clear enough that both means user-settings and global-settings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-154) Nonclear description in README.asciidoc for system environment properties

by Marek Novotny (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-154?page=com.atlassian.jira.plu... ] Marek Novotny updated SHRINKRES-154: ------------------------------------ Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/shrinkwrap/resolver/pull/56 > Nonclear description in README.asciidoc for system environment properties > ------------------------------------------------------------------------- > > Key: SHRINKRES-154 > URL: https://issues.jboss.org/browse/SHRINKRES-154 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Environment: master branch of https://github.com/shrinkwrap/resolver > Reporter: Marek Novotny > Assignee: Andrew Rubinger > > https://github.com/shrinkwrap/resolver#system-properties for _org.apache.maven.user-settings_ property description states that > bq. Path to user settings.xml file. In case both settings are provided, they are merged, user one has the priority. > And without reading the following description for _org.apache.maven.global-settings_ property it is not clear enough that both means user-settings and global-settings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-154) Nonclear description in README.asciidoc for system environment properties

by Marek Novotny (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-154?page=com.atlassian.jira.plu... ] Marek Novotny updated SHRINKRES-154: ------------------------------------ Summary: Nonclear description in README.asciidoc for system environment properties (was: Nonclear description in README.MD for system environment properties) > Nonclear description in README.asciidoc for system environment properties > ------------------------------------------------------------------------- > > Key: SHRINKRES-154 > URL: https://issues.jboss.org/browse/SHRINKRES-154 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Environment: master branch of https://github.com/shrinkwrap/resolver > Reporter: Marek Novotny > Assignee: Andrew Rubinger > > https://github.com/shrinkwrap/resolver#system-properties for _org.apache.maven.user-settings_ property description states that > bq. Path to user settings.xml file. In case both settings are provided, they are merged, user one has the priority. > And without reading the following description for _org.apache.maven.global-settings_ property it is not clear enough that both means user-settings and global-settings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-154) Nonclear description in README.MD for system environment properties

by Marek Novotny (JIRA)

Marek Novotny created SHRINKRES-154: --------------------------------------- Summary: Nonclear description in README.MD for system environment properties Key: SHRINKRES-154 URL: https://issues.jboss.org/browse/SHRINKRES-154 Project: ShrinkWrap Resolvers Issue Type: Bug Environment: master branch of https://github.com/shrinkwrap/resolver Reporter: Marek Novotny Assignee: Andrew Rubinger https://github.com/shrinkwrap/resolver#system-properties for _org.apache.maven.user-settings_ property description states that bq. Path to user settings.xml file. In case both settings are provided, they are merged, user one has the priority. And without reading the following description for _org.apache.maven.global-settings_ property it is not clear enough that both means user-settings and global-settings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 5 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-469) ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases

by Under Flowerpot (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-469?page=com.atlassian.jira.pl... ] Under Flowerpot commented on SHRINKWRAP-469: -------------------------------------------- No PR. I investigate shrinkwrap for its standalone features and implementation. I am experimenting with my own nio2 FileSystem implementation of Zookeeper. > ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases > ---------------------------------------------------------------------- > > Key: SHRINKWRAP-469 > URL: https://issues.jboss.org/browse/SHRINKWRAP-469 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Under Flowerpot > Priority: Minor > > Unfortunately the nio2 API was designed before Java8's stream library. > The documentation says that ShrinkWrapDirectoryStream.iterator must throw IllegalStateException if the Stream is closed OR if the iterator() has been accessed already. > From my reading of the DirectoryStream javadoc, the implementation of Iterator is otherwise fine. close() does not have to prematurely terminate the Iterator. iterator() should just comply with the precondition exceptions. > ShrinkWrapDirectoryStream is package protected, there is no reason to discuss any relationship to SecureDirectoryStream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-470) SeekableInMemoryByteChannel.truncate misimplements the contract

by Under Flowerpot (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-470?page=com.atlassian.jira.pl... ] Under Flowerpot commented on SHRINKWRAP-470: -------------------------------------------- No PR. I investigate shrinkwrap for its standalone features and implementation. I am experimenting with my own nio2 FileSystem implementation of Zookeeper. > SeekableInMemoryByteChannel.truncate misimplements the contract > --------------------------------------------------------------- > > Key: SHRINKWRAP-470 > URL: https://issues.jboss.org/browse/SHRINKWRAP-470 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Under Flowerpot > > At the tail end of truncate, is this logic: > {code} > // If we've been given a size greater than we are > if (newSize > currentSize) { > // Reset the position only > this.position = newSize; > } > {code} > which is not what the API says: "If the given size is less than the current size then the entity is truncated, discarding any bytes beyond the new end. If the given size is greater than or equal to the current size then the entity is not modified." > I think you wanted this instead, which should be inside the above array truncation: > {code} > // If we've been given a size less than we are > if (newSize < currentSize) { > // Reset the size only > this.size = newSize; > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-470) SeekableInMemoryByteChannel.truncate misimplements the contract

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-470?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-470: -------------------------------------------- Thanks for the report; was there an associated PR? Else we'll fix it up here. > SeekableInMemoryByteChannel.truncate misimplements the contract > --------------------------------------------------------------- > > Key: SHRINKWRAP-470 > URL: https://issues.jboss.org/browse/SHRINKWRAP-470 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Under Flowerpot > > At the tail end of truncate, is this logic: > {code} > // If we've been given a size greater than we are > if (newSize > currentSize) { > // Reset the position only > this.position = newSize; > } > {code} > which is not what the API says: "If the given size is less than the current size then the entity is truncated, discarding any bytes beyond the new end. If the given size is greater than or equal to the current size then the entity is not modified." > I think you wanted this instead, which should be inside the above array truncation: > {code} > // If we've been given a size less than we are > if (newSize < currentSize) { > // Reset the size only > this.size = newSize; > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues November 2013