November 2013 - shrinkwrap-issues

[JBoss JIRA] (SHRINKWRAP-469) ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-469?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-469: -------------------------------------------- Thanks for the report; was there an associated PR? > ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases > ---------------------------------------------------------------------- > > Key: SHRINKWRAP-469 > URL: https://issues.jboss.org/browse/SHRINKWRAP-469 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Under Flowerpot > Priority: Minor > > Unfortunately the nio2 API was designed before Java8's stream library. > The documentation says that ShrinkWrapDirectoryStream.iterator must throw IllegalStateException if the Stream is closed OR if the iterator() has been accessed already. > From my reading of the DirectoryStream javadoc, the implementation of Iterator is otherwise fine. close() does not have to prematurely terminate the Iterator. iterator() should just comply with the precondition exceptions. > ShrinkWrapDirectoryStream is package protected, there is no reason to discuss any relationship to SecureDirectoryStream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-470) SeekableInMemoryByteChannel.truncate misimplements the contract

by Under Flowerpot (JIRA)

Under Flowerpot created SHRINKWRAP-470: ------------------------------------------ Summary: SeekableInMemoryByteChannel.truncate misimplements the contract Key: SHRINKWRAP-470 URL: https://issues.jboss.org/browse/SHRINKWRAP-470 Project: ShrinkWrap Issue Type: Bug Reporter: Under Flowerpot At the tail end of truncate, is this logic: {code} // If we've been given a size greater than we are if (newSize > currentSize) { // Reset the position only this.position = newSize; } {code} which is not what the API says: "If the given size is less than the current size then the entity is truncated, discarding any bytes beyond the new end. If the given size is greater than or equal to the current size then the entity is not modified." I think you wanted this instead, which should be inside the above array truncation: {code} // If we've been given a size less than we are if (newSize < currentSize) { // Reset the size only this.size = newSize; } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-469) ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases

by Under Flowerpot (JIRA)

Under Flowerpot created SHRINKWRAP-469: ------------------------------------------ Summary: ShrinkWrapDirectoryStream.iterator missing IllegalStateException cases Key: SHRINKWRAP-469 URL: https://issues.jboss.org/browse/SHRINKWRAP-469 Project: ShrinkWrap Issue Type: Bug Reporter: Under Flowerpot Priority: Minor Unfortunately the nio2 API was designed before Java8's stream library. The documentation says that ShrinkWrapDirectoryStream.iterator must throw IllegalStateException if the Stream is closed OR if the iterator() has been accessed already. >From my reading of the DirectoryStream javadoc, the implementation of Iterator is otherwise fine. close() does not have to prematurely terminate the Iterator. iterator() should just comply with the precondition exceptions. ShrinkWrapDirectoryStream is package protected, there is no reason to discuss any relationship to SecureDirectoryStream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-150) Support Bean Validation 1.0 and 1.1 descriptor

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-150?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKDESC-150: -------------------------------------------- d8a5822c11acf796e52e955718bbf25b0a93fdd7 > Support Bean Validation 1.0 and 1.1 descriptor > ---------------------------------------------- > > Key: SHRINKDESC-150 > URL: https://issues.jboss.org/browse/SHRINKDESC-150 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha--6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > Fix For: 2.0.0-alpha--6 > > > The Bean Validation descriptors should be part of the Java EE 7 descriptors -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-150) Support Bean Validation 1.0 and 1.1 descriptor

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-150?page=com.atlassian.jira.pl... ] Andrew Rubinger resolved SHRINKDESC-150. ---------------------------------------- Fix Version/s: 2.0.0-alpha--6 Resolution: Done > Support Bean Validation 1.0 and 1.1 descriptor > ---------------------------------------------- > > Key: SHRINKDESC-150 > URL: https://issues.jboss.org/browse/SHRINKDESC-150 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha--6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > Fix For: 2.0.0-alpha--6 > > > The Bean Validation descriptors should be part of the Java EE 7 descriptors -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues November 2013