January 2014 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKRES-158) Wrong parsing of plugins with list configuration

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-158?page=com.atlassian.jira.plu... ] Karel Piwko commented on SHRINKRES-158: --------------------------------------- Example of list configuration in plugin: {code} <compilerArgs> <arg>1</arg> <arg>2</arg> </compilerArgs> {code} Maps to list compilerArgs = [1, 2] > Wrong parsing of plugins with list configuration > ------------------------------------------------ > > Key: SHRINKRES-158 > URL: https://issues.jboss.org/browse/SHRINKRES-158 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.0.1 > Reporter: Karel Piwko > Assignee: Karel Piwko > Fix For: 2.0.2 > > > *When*: > I want to parse an argument list via MavenImporter in a plugin configuration. > *Then*: > A expect that arguments will be correctly propagated. > *Current behavior*: > Default value is always retrieved due to bug in ConfigurationUtils. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-159) Update JUnit to 4.11

by Karel Piwko (JIRA)

Karel Piwko created SHRINKRES-159: ------------------------------------- Summary: Update JUnit to 4.11 Key: SHRINKRES-159 URL: https://issues.jboss.org/browse/SHRINKRES-159 Project: ShrinkWrap Resolvers Issue Type: Component Upgrade Reporter: Karel Piwko Assignee: Karel Piwko This change will allow us to work better with assertThat in tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-158) Wrong parsing of plugins with list configuration

by Karel Piwko (JIRA)

Karel Piwko created SHRINKRES-158: ------------------------------------- Summary: Wrong parsing of plugins with list configuration Key: SHRINKRES-158 URL: https://issues.jboss.org/browse/SHRINKRES-158 Project: ShrinkWrap Resolvers Issue Type: Bug Components: impl-maven Affects Versions: 2.0.1 Reporter: Karel Piwko Assignee: Karel Piwko Fix For: 2.0.2 *When*: I want to parse an argument list via MavenImporter in a plugin configuration. *Then*: A expect that arguments will be correctly propagated. *Current behavior*: Default value is always retrieved due to bug in ConfigurationUtils. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- Hi Ralf, Yeah in the case of enums, I resolved using the String parameter method signature. That's fine. In my implementation, since this is done manually, I only added the common types that could be used in the current plugins, however a better solution would be to also generate these subtypes in the common package. The main idea is that common parts of a descriptor could be invoked from the common interface without requiring any casts to a specific type. > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- Hi George and Lincoln I added version and the transactiontype. Of course, it is done in a reusable way, other common descriptors would benefit as well. The transactionType enum stressed me a little bit. I tried several things. At the end, I came to the conclusion that the best approach between all enum type version e.g. transactionType version 1.0, 1.1 and 1.2 are strings. All generated enums already accept strings as arguments, and returns the value as string with the method getXXXXAsString(). I think, this is an acceptable way. I hope:-) Then some thoughts about the missing Properties type. It took me a long time to analyze your solution of the common web app descriptor. One thing I realized that this common descriptor makes only few sub types of the webapp descriptor common. SERVLET, SERVLET_MAPPING and so on. Other subtypes are not defined or part of the common descriptor. So my question is what are the criterias for a common descriptor? And more important, do you need a common type and inside this as well common subtypes? This is the case of the properties type. It is a sub time of the persistence-unit type. I will find a way to make this as well possible. Stay tuned Ralf > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- Thank you Geroge for your suggestions. I will work on the points you have mentioned. The enums bothers me most... Generics and enums... difficult ;-) I am not the generics expert. I think more an one common definition of enums as long as the match 100% but what if not... > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- Thanks Lincoln, I see it exactly as you see this :-) > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Lincoln Baxter III (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Lincoln Baxter III commented on SHRINKDESC-151: ----------------------------------------------- Hey Ralf, this is excellent! I agree with the "common" package, as it makes it very clear what is and is not part of the shared API/schema. Sorry for the late reply, I was gone for a while over the holidays :) ~Lincoln > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- - the <property> element in JPA should be part of the common descriptor. - PersistenceCommonDescriptor.getVersion() is missing > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- Ralf, PersistenceUnitCommonType is missing getOrCreateProperties() and transactionType(). Still looking into other issues > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues January 2014