January 2014 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- I added a common descriptor for persistence and for beans. Note that the beans common descriptor is a so called empty common descriptor. This is because the xsd's differ fundamental regarding the unbounded definition. In beans 1.0, the nested class elements are unbounded whereas in beans 1.1 the interceptors, alternatives etc. are unbounded. Can you check if that still meets your requirement? If not, then we have an issue... My repo is: https://github.com/rbattenfeld/descriptors/tree/SHRINKDESC-151 Regards, Ralf > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- There is no problem in that. The fact is that each common subpackage belongs to a specific descriptor. So if you want to know which classes belong to the persistence descriptor, for example, it is just a matter of seeing the package name. The current generation places all the generated descriptors in a single common package, making it harder to identify. > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- I wanted to make it as simple as possible. Do you see a problem with a common package? The nature of all 'common' classes is that they are cross version compatible. I am happy if this here is as simple as possible. If not, the there are many common packages: ...api.persistence.common, ...api.webapp.common. ...api.beans.common ...... I see no technical issue having one common package but I you see one, please shout:-) > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- The WebCommonDescriptor seems to work fine. I noticed the package it resides on is {{org.jboss.shrinkwrap.descriptor.api.common}}. Is it possible to place it in something like {{org.jboss.shrinkwrap.descriptor.api.webapp.common}} ? > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- Thanks George I will configure a common descriptor for those descriptors too. The WebCommonDescriptor matches your expectations? It should produces exactly the same common descriptor as you implemented manually. - Ralf > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-472) Shrinkwrap BOM seems to be unreleased in Maven Central

by Stefan Miklosovic (JIRA)

Stefan Miklosovic created SHRINKWRAP-472: -------------------------------------------- Summary: Shrinkwrap BOM seems to be unreleased in Maven Central Key: SHRINKWRAP-472 URL: https://issues.jboss.org/browse/SHRINKWRAP-472 Project: ShrinkWrap Issue Type: Task Affects Versions: 1.2.1 Reporter: Stefan Miklosovic Priority: Critical Hi, I am wondering why is this happening, it seems ShrinkWrap BOM of version 1.2.1 is released here https://repository.jboss.org/nexus/index.html#nexus-search;gav~org.jboss.... https://github.com/shrinkwrap/shrinkwrap/blob/1.2.1/bom/pom.xml#L13 But it is not here: http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.jboss.shrinkwrap%2... I was trying to use 1.2.1 of BOM and Maven just can not resolve it since it is not in Central. It seems to me that there was some synchronization issue while these bits where uploaded to central. What is the next step? Regards -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- Ralf, We need common entries for the JPA descriptors (persistence.xml), CDI (1.0 and 1.1) and the web.xml. See the commits in the forked repository: http://github.com/forge/javaee-descriptors/commits/master > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues January 2014