[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions
by Ralf Battenfeld (JIRA)
[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ]
Ralf Battenfeld commented on SHRINKDESC-151:
--------------------------------------------
A first descriptor build providing common descriptors are here: https://github.com/rbattenfeld/descriptors/tree/SHRINKDESC-151
It would be great if you can check and see if that is what you expect.
It was a long journey in order to find all hidden issues. If something works for a descriptor A it does not mean that this works as well for a descriptor B. The long time was also caused by the fact that xslt doesn't allow to check if a common class is already generated. So, I had to introduce in the metadata parser a search functionality for such generated classes. Let me know what you think.
Here is a list of workable common descriptors:
- ConnectorCommonDescriptor (versions 1.5, 1.6, 1.7)
- PortletCommonDescriptor (2.0)
- ApplicationCommonDescriptor (5, 6, 7)
- PersistenceCommonDescriptor (1.0, 2.0, 2.1)
- OrmCommonDescriptor (1.0, 2.0, 2.1)
- EjbJarCommonDescriptor (3.0, 3.1, 3.2)
- WebFacelettaglibraryCommonDescriptor (2.0, 2.2)
- WebFacesConfigCommonDescriptor (2.0, 2.1, 2.2)
- WebFacesPartialResponseCommonDescriptor (2.0, 2.1, 2.2)
- WebAppCommonDescriptor (2.5, 3.0, 3.1)
- PermissionsCommonDescriptor (7.0)
- JobXMLCommonDescriptor (1.0)
- BatchXMLCommonDescriptor (1.0)
- ValidationMappingCommonDescriptor (1.1)
- ValidationConfigurationCommonDescriptor (1.1)
I am aware that one of the most important descriptors are not in this list, the beans descriptor. I will try to find a solution for this one. But later:-)
Once you are happy with this, I will try to squash my commits into one.
Forecast:-) After this JIRA is in 2.0.0.X I will and want to:
1. Get rid of the Child<T> stuff in the way I proposed some months ago. Details we can discuss.
2. Read-Only descriptors (SD-21)
In this order. I think, the read-only descriptors are easier to implement after the generics up(). is gone.
Let me know what you think.
Ralf
> Descriptors should generate a common parent for different spec versions
> -----------------------------------------------------------------------
>
> Key: SHRINKDESC-151
> URL: https://issues.jboss.org/browse/SHRINKDESC-151
> Project: ShrinkWrap Descriptors
> Issue Type: Feature Request
> Components: api-javaee
> Reporter: George Gastaldi
> Assignee: Ralf Battenfeld
>
> This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used.
> A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface:
> Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java...
> Sub Interfaces:
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java...
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java...
> https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java...
> The generated code doesn't need to change either. The existence of the super interface is what matters most.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 2 months
[JBoss JIRA] (SHRINKRES-163) Implements importTestBuildOutput for type JAR
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-163?page=com.atlassian.jira.plu... ]
Karel Piwko commented on SHRINKRES-163:
---------------------------------------
Johan, what exactly do you expect for importTestBuildOutput() in WAR?
Merging src/test/main classes into WEB-INF/classes and merging src/test/resources into WEB-INF/classes as well?
> Implements importTestBuildOutput for type JAR
> ---------------------------------------------
>
> Key: SHRINKRES-163
> URL: https://issues.jboss.org/browse/SHRINKRES-163
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Components: impl-maven
> Affects Versions: 2.0.2
> Reporter: Karel Piwko
>
> While default use case - merging src/main and src/test together might not be seen as useful, there is at least an option that user will be willing to import src/test only.
> That said, implementing importTestBuildOutput() for a archive of type jar is a valid operation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 2 months
[JBoss JIRA] (SHRINKRES-147) Maven plugin compilation fails under maven 3.1.0
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-147?page=com.atlassian.jira.plu... ]
Karel Piwko reassigned SHRINKRES-147:
-------------------------------------
Assignee: Karel Piwko (was: Andrew Rubinger)
> Maven plugin compilation fails under maven 3.1.0
> ------------------------------------------------
>
> Key: SHRINKRES-147
> URL: https://issues.jboss.org/browse/SHRINKRES-147
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Components: maven-plugin
> Affects Versions: 2.1.0-alpha-1
> Environment: maven 3.1.0, windows, jdk 7
> Reporter: Michal Matloka
> Assignee: Karel Piwko
>
> {noformat}
> [INFO] Building: dependency-tree-scope\pom.xml
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO]
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO] Building ShrinkWrap Maven Resolver Plugin Tests: Dependency Tree with Scope 1.0.0
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO]
> [INFO] [INFO] --- shrinkwrap-resolver-maven-plugin:2.0.1-SNAPSHOT:dependency-tree (default-cli) @ shrinkwrap-resolver-maven-plugin-tests-dep
> endency-tree-scoped ---
> [INFO] [debug] Propagating [maven.execution.pom-file=I:\Dev\JBoss\shrinkwrap resolver\maven-plugin\target\it\dependency-tree-scope\pom.xml]
> from Maven Session to command line properties
> [INFO] [debug] Propagating [maven.execution.offline=false] from Maven Session to command line properties
> [INFO] [debug] Propagating [maven.execution.user-settings=C:\Users\mich\AppData\Local\Temp\invoker-settings5519757379074982689.xml] from Mav
> en Session to command line properties
> [INFO] [debug] Propagating [maven.execution.global-settings=I:\Programy\Dev\apache-maven-3.1.0\conf\settings.xml] from Maven Session to comm
> and line properties
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO] BUILD FAILURE
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO] Total time: 1.762s
> [INFO] [INFO] Finished at: Thu Jul 25 11:42:06 CEST 2013
> [INFO] [INFO] Final Memory: 7M/154M
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [ERROR] Failed to execute goal org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-maven-plugin:2.0.1-SNAPSHOT:dependency-tree (default
> -cli) on project shrinkwrap-resolver-maven-plugin-tests-dependency-tree-scoped: Execution default-cli of goal org.jboss.shrinkwrap.resolver:
> shrinkwrap-resolver-maven-plugin:2.0.1-SNAPSHOT:dependency-tree failed: Could not create object from user view: InvocationTargetException: C
> ould not create new service instance: org/sonatype/aether/resolution/DependencyResolutionException: org.sonatype.aether.resolution.Dependenc
> yResolutionException -> [Help 1]
> [INFO] [ERROR]
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR]
> [INFO] [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [INFO] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> [INFO] ..FAILED (4.2 s)
> [INFO] The build exited with code 1. See I:\Dev\JBoss\shrinkwrap resolver\maven-plugin\target\it\dependency-tree-scope\build.log for detai
> ls.
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO] Passed: 2, Failed: 2, Errors: 0, Skipped: 0
> [INFO] -------------------------------------------------
> [ERROR] The following builds failed:
> [ERROR] * dependency-tree\pom.xml
> [ERROR] * dependency-tree-scope\pom.xml
> [INFO] -------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ShrinkWrap Resolver Bill of Materials ............. SUCCESS [0.502s]
> [INFO] ShrinkWrap Resolver Aggregator .................... SUCCESS [0.869s]
> [INFO] Shrinkwrap Resolver Build Resources ............... SUCCESS [1.087s]
> [INFO] ShrinkWrap Resolver API ........................... SUCCESS [3.816s]
> [INFO] ShrinkWrap Resolver Maven API ..................... SUCCESS [5.368s]
> [INFO] ShrinkWrap Resolver SPI ........................... SUCCESS [1.368s]
> [INFO] ShrinkWrap Resolver Maven SPI ..................... SUCCESS [2.134s]
> [INFO] ShrinkWrap Resolver Maven Implementation .......... SUCCESS [1:51.888s]
> [INFO] ShrinkWrap Resolver Maven Archive API ............. SUCCESS [1.401s]
> [INFO] ShrinkWrap Resolver Maven Archive SPI ............. SUCCESS [1.647s]
> [INFO] ShrinkWrap Resolver Maven Archive Implementation .. SUCCESS [48.196s]
> [INFO] ShrinkWrap Resolver Dependency Chain .............. SUCCESS [0.457s]
> [INFO] ShrinkWrap Resolver Maven Plugin .................. FAILURE [1:27.822s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 4:27.370s
> [INFO] Finished at: Thu Jul 25 11:42:07 CEST 2013
> [INFO] Final Memory: 27M/183M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:1.7:run (run-integration-test) on project shrinkwrap-resolver-m
> aven-plugin: 2 builds failed. See console output above for details. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the command
> [ERROR] mvn <goals> -rf :shrinkwrap-resolver-maven-plugin
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 2 months
[JBoss JIRA] (SHRINKRES-147) Maven plugin compilation fails under maven 3.1.0
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-147?page=com.atlassian.jira.plu... ]
Karel Piwko resolved SHRINKRES-147.
-----------------------------------
Fix Version/s: 2.1.0
Resolution: Done
This was fixed as part of SHRINKRES-140 migration.
> Maven plugin compilation fails under maven 3.1.0
> ------------------------------------------------
>
> Key: SHRINKRES-147
> URL: https://issues.jboss.org/browse/SHRINKRES-147
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Components: maven-plugin
> Affects Versions: 2.1.0-alpha-1
> Environment: maven 3.1.0, windows, jdk 7
> Reporter: Michal Matloka
> Assignee: Karel Piwko
> Fix For: 2.1.0
>
>
> {noformat}
> [INFO] Building: dependency-tree-scope\pom.xml
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO]
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO] Building ShrinkWrap Maven Resolver Plugin Tests: Dependency Tree with Scope 1.0.0
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO]
> [INFO] [INFO] --- shrinkwrap-resolver-maven-plugin:2.0.1-SNAPSHOT:dependency-tree (default-cli) @ shrinkwrap-resolver-maven-plugin-tests-dep
> endency-tree-scoped ---
> [INFO] [debug] Propagating [maven.execution.pom-file=I:\Dev\JBoss\shrinkwrap resolver\maven-plugin\target\it\dependency-tree-scope\pom.xml]
> from Maven Session to command line properties
> [INFO] [debug] Propagating [maven.execution.offline=false] from Maven Session to command line properties
> [INFO] [debug] Propagating [maven.execution.user-settings=C:\Users\mich\AppData\Local\Temp\invoker-settings5519757379074982689.xml] from Mav
> en Session to command line properties
> [INFO] [debug] Propagating [maven.execution.global-settings=I:\Programy\Dev\apache-maven-3.1.0\conf\settings.xml] from Maven Session to comm
> and line properties
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO] BUILD FAILURE
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [INFO] Total time: 1.762s
> [INFO] [INFO] Finished at: Thu Jul 25 11:42:06 CEST 2013
> [INFO] [INFO] Final Memory: 7M/154M
> [INFO] [INFO] ------------------------------------------------------------------------
> [INFO] [ERROR] Failed to execute goal org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-maven-plugin:2.0.1-SNAPSHOT:dependency-tree (default
> -cli) on project shrinkwrap-resolver-maven-plugin-tests-dependency-tree-scoped: Execution default-cli of goal org.jboss.shrinkwrap.resolver:
> shrinkwrap-resolver-maven-plugin:2.0.1-SNAPSHOT:dependency-tree failed: Could not create object from user view: InvocationTargetException: C
> ould not create new service instance: org/sonatype/aether/resolution/DependencyResolutionException: org.sonatype.aether.resolution.Dependenc
> yResolutionException -> [Help 1]
> [INFO] [ERROR]
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR]
> [INFO] [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [INFO] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> [INFO] ..FAILED (4.2 s)
> [INFO] The build exited with code 1. See I:\Dev\JBoss\shrinkwrap resolver\maven-plugin\target\it\dependency-tree-scope\build.log for detai
> ls.
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO] Passed: 2, Failed: 2, Errors: 0, Skipped: 0
> [INFO] -------------------------------------------------
> [ERROR] The following builds failed:
> [ERROR] * dependency-tree\pom.xml
> [ERROR] * dependency-tree-scope\pom.xml
> [INFO] -------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ShrinkWrap Resolver Bill of Materials ............. SUCCESS [0.502s]
> [INFO] ShrinkWrap Resolver Aggregator .................... SUCCESS [0.869s]
> [INFO] Shrinkwrap Resolver Build Resources ............... SUCCESS [1.087s]
> [INFO] ShrinkWrap Resolver API ........................... SUCCESS [3.816s]
> [INFO] ShrinkWrap Resolver Maven API ..................... SUCCESS [5.368s]
> [INFO] ShrinkWrap Resolver SPI ........................... SUCCESS [1.368s]
> [INFO] ShrinkWrap Resolver Maven SPI ..................... SUCCESS [2.134s]
> [INFO] ShrinkWrap Resolver Maven Implementation .......... SUCCESS [1:51.888s]
> [INFO] ShrinkWrap Resolver Maven Archive API ............. SUCCESS [1.401s]
> [INFO] ShrinkWrap Resolver Maven Archive SPI ............. SUCCESS [1.647s]
> [INFO] ShrinkWrap Resolver Maven Archive Implementation .. SUCCESS [48.196s]
> [INFO] ShrinkWrap Resolver Dependency Chain .............. SUCCESS [0.457s]
> [INFO] ShrinkWrap Resolver Maven Plugin .................. FAILURE [1:27.822s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 4:27.370s
> [INFO] Finished at: Thu Jul 25 11:42:07 CEST 2013
> [INFO] Final Memory: 27M/183M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:1.7:run (run-integration-test) on project shrinkwrap-resolver-m
> aven-plugin: 2 builds failed. See console output above for details. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the command
> [ERROR] mvn <goals> -rf :shrinkwrap-resolver-maven-plugin
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 2 months
[JBoss JIRA] (SHRINKRES-170) Enable checkstyle rule for unused imports
by Karel Piwko (JIRA)
Karel Piwko created SHRINKRES-170:
-------------------------------------
Summary: Enable checkstyle rule for unused imports
Key: SHRINKRES-170
URL: https://issues.jboss.org/browse/SHRINKRES-170
Project: ShrinkWrap Resolvers
Issue Type: Task
Affects Versions: 2.0.0
Reporter: Karel Piwko
Assignee: Karel Piwko
Fix For: 2.1.0
Checkstyle is now able to check for unused imports including javadoc. Enable the rule and release new build-config as a part of next release.
The second part of this step is to enable the rule as next release is out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 2 months