February 2014 - shrinkwrap-issues

[JBoss JIRA] (SHRINKRES-164) Support encoding property from Maven compiler plugin

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-164?page=com.atlassian.jira.plu... ] Karel Piwko edited comment on SHRINKRES-164 at 2/13/14 3:43 AM: ---------------------------------------------------------------- Thank you very much for the suggestion. Fixed and pushed upstream in https://github.com/shrinkwrap/resolver/commit/42f5bff91a27a78c7234ce8af07... It also supports project.build.sourceEncoding property, that is usually default way how to setup encoding in Maven projects. was (Author: kpiwko): Thank you very much for the suggestion. Fixed and pushed upstream in https://github.com/shrinkwrap/resolver/commit/42f5bff91a27a78c7234ce8af07... > Support encoding property from Maven compiler plugin > ---------------------------------------------------- > > Key: SHRINKRES-164 > URL: https://issues.jboss.org/browse/SHRINKRES-164 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: impl-maven > Affects Versions: 2.0.2 > Reporter: Thilo Mezger > Assignee: Karel Piwko > Fix For: 2.1.0 > > > I'd like to suggest that org.jboss.shrinkwrap.resolver.impl.maven.archive.plugins.CompilerPluginConfiguration should support the "encoding" property of the maven-compiler-plugin just like it supports "source" and "target". > I know that you can use "compilerArgs" to pass any parameter but that wouldn't be obvious when you have this special "encoding" parameter in maven-compiler-plugin. Everyone would expect that this setting is passed on. > And things can really go wrong in all magic ways if you compile your files with the wrong encoding... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-164) Support encoding property from Maven compiler plugin

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-164?page=com.atlassian.jira.plu... ] Karel Piwko resolved SHRINKRES-164. ----------------------------------- Resolution: Done Thank you very much for the suggestion. Fixed and pushed upstream in https://github.com/shrinkwrap/resolver/commit/42f5bff91a27a78c7234ce8af07... > Support encoding property from Maven compiler plugin > ---------------------------------------------------- > > Key: SHRINKRES-164 > URL: https://issues.jboss.org/browse/SHRINKRES-164 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: impl-maven > Affects Versions: 2.0.2 > Reporter: Thilo Mezger > Assignee: Karel Piwko > Fix For: 2.1.0 > > > I'd like to suggest that org.jboss.shrinkwrap.resolver.impl.maven.archive.plugins.CompilerPluginConfiguration should support the "encoding" property of the maven-compiler-plugin just like it supports "source" and "target". > I know that you can use "compilerArgs" to pass any parameter but that wouldn't be obvious when you have this special "encoding" parameter in maven-compiler-plugin. Everyone would expect that this setting is passed on. > And things can really go wrong in all magic ways if you compile your files with the wrong encoding... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-26) Make Shrinkwrap resolver work in a modular environment

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-26?page=com.atlassian.jira.plug... ] Karel Piwko resolved SHRINKRES-26. ---------------------------------- Assignee: Karel Piwko Fix Version/s: 2.1.0 Resolution: Done Modular tests - with different classloader are used in ShrinkWrap Maven Plugin Dependecy Tree goal. Maven has a modular classpath handled by Plexu ClassWorlds and we require specific classpath setup in order to execute ShrinkWrap Resolver from Maven Plugin. The only issue is that classloader that is used to load Resolvers/Maven class must be the same as the one passed to API or the must be parent-child relationship. This happens due to fact that casting to generic types might fail with ClassCastException if Generic type Erasure was loaded by different classloader. I don't see that as an issue, hence closing the issue, marking as resolved. Please file a new bug if you need more complicated classloader handling. > Make Shrinkwrap resolver work in a modular environment > ------------------------------------------------------ > > Key: SHRINKRES-26 > URL: https://issues.jboss.org/browse/SHRINKRES-26 > Project: ShrinkWrap Resolvers > Issue Type: Enhancement > Components: impl-maven > Affects Versions: 1.1.0-alpha-1 > Reporter: Galder Zamarreño > Assignee: Karel Piwko > Fix For: 2.1.0 > > > The subsystem I'm building requires dependencies of my war to downloaded and resolved at runtime or deploy time. > So, that means that I need to create a set of JBoss AS7 modules for Shrinkwrap resolver. However, the way classloader works to load META-INF/services/org.jboss.shrinkwrap.resolver.api.maven.MavenDependencyResolver is a bit crap cos it uses thread context classloader in DependencyBuilderInstantiator. > Can this be rewritten so that classloading can work in a modular environment as well? > The problem is that the thread context classloader at runtime is: > {code}ModuleClassLoader for Module "org.jboss.as.server:main" from local module loader @5d2412e7 (roots: ...){code} > I can probably workaround this setting the module's classloader as thread context classloader temporarily, but this is not nice. > Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-169) Replace deprecated Assert code

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-169?page=com.atlassian.jira.plu... ] Karel Piwko resolved SHRINKRES-169. ----------------------------------- Resolution: Done Pushed upstream in https://github.com/shrinkwrap/resolver/commit/7f424e82085b7966d6e84fb3d46... > Replace deprecated Assert code > ------------------------------ > > Key: SHRINKRES-169 > URL: https://issues.jboss.org/browse/SHRINKRES-169 > Project: ShrinkWrap Resolvers > Issue Type: Enhancement > Components: build-resources > Affects Versions: 2.0.2 > Reporter: Karel Piwko > Assignee: Karel Piwko > Fix For: 2.1.0 > > > There is plenty of deprecated calls, especially in tests, namely using junitframework.Assert instead of recent org.junit.Assert. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-140) Update Aether implementation to org.eclipse.aether one

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-140?page=com.atlassian.jira.plu... ] Karel Piwko commented on SHRINKRES-140: --------------------------------------- Debugging cleanup in additional commit here - https://github.com/shrinkwrap/resolver/commit/d2989576a0f04b4fa765575ebbd... > Update Aether implementation to org.eclipse.aether one > ------------------------------------------------------ > > Key: SHRINKRES-140 > URL: https://issues.jboss.org/browse/SHRINKRES-140 > Project: ShrinkWrap Resolvers > Issue Type: Component Upgrade > Components: impl-maven > Affects Versions: 2.0.0-beta-5 > Reporter: Karel Piwko > Assignee: Karel Piwko > Fix For: 2.1.0 > > > Aether is now a part of org.eclipse foundation. We should update to newer version when they release first stable version. > Update should not affect user at all, it should comprise of replacing imports with new ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-167) Update jboss-parent to latest version (12)

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-167?page=com.atlassian.jira.plu... ] Karel Piwko resolved SHRINKRES-167. ----------------------------------- Assignee: Karel Piwko (was: Andrew Rubinger) Resolution: Done Pushed upstream in https://github.com/shrinkwrap/resolver/commit/e3e50144607c242efb9b21eed19... > Update jboss-parent to latest version (12) > ------------------------------------------ > > Key: SHRINKRES-167 > URL: https://issues.jboss.org/browse/SHRINKRES-167 > Project: ShrinkWrap Resolvers > Issue Type: Component Upgrade > Components: build-resources > Affects Versions: 2.0.2 > Reporter: Karel Piwko > Assignee: Karel Piwko > Fix For: 2.1.0 > > > Update jboss-parent to recent version. > During the update: > * custom compiler plugin configuration can be removed > * surefire configuration can be updated to forkCount, reuseForks -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-5) Make it easier to add a maven repository with the maven resolvers

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-5?page=com.atlassian.jira.plugi... ] Karel Piwko commented on SHRINKRES-5: ------------------------------------- I believe that https://github.com/shrinkwrap/resolver/pull/63 is a good start. > Make it easier to add a maven repository with the maven resolvers > ----------------------------------------------------------------- > > Key: SHRINKRES-5 > URL: https://issues.jboss.org/browse/SHRINKRES-5 > Project: ShrinkWrap Resolvers > Issue Type: Enhancement > Components: api-maven > Affects Versions: 2.0.2 > Reporter: Jason Porter > Priority: Minor > Labels: api-change > Fix For: 2.1.0 > > > It should be easier to add a repository than creating a full settings.xml. Perhaps something like addRepository(String), or addRepositories(String...) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-5) Make it easier to add a maven repository with the maven resolvers

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-5?page=com.atlassian.jira.plugi... ] Karel Piwko updated SHRINKRES-5: -------------------------------- Fix Version/s: 2.1.0 Affects Version/s: 2.0.2 Component/s: api-maven > Make it easier to add a maven repository with the maven resolvers > ----------------------------------------------------------------- > > Key: SHRINKRES-5 > URL: https://issues.jboss.org/browse/SHRINKRES-5 > Project: ShrinkWrap Resolvers > Issue Type: Enhancement > Components: api-maven > Affects Versions: 2.0.2 > Reporter: Jason Porter > Priority: Minor > Labels: api-change > Fix For: 2.1.0 > > > It should be easier to add a repository than creating a full settings.xml. Perhaps something like addRepository(String), or addRepositories(String...) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-169) Replace deprecated Assert code

by Karel Piwko (JIRA)

Karel Piwko created SHRINKRES-169: ------------------------------------- Summary: Replace deprecated Assert code Key: SHRINKRES-169 URL: https://issues.jboss.org/browse/SHRINKRES-169 Project: ShrinkWrap Resolvers Issue Type: Component Upgrade Components: build-resources Affects Versions: 2.0.2 Reporter: Karel Piwko Assignee: Andrew Rubinger Fix For: 2.1.0 There is plenty of deprecated calls, especially in tests, namely using junitframework.Assert instead of recent org.junit.Assert. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-169) Replace deprecated Assert code

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-169?page=com.atlassian.jira.plu... ] Karel Piwko updated SHRINKRES-169: ---------------------------------- Issue Type: Enhancement (was: Component Upgrade) > Replace deprecated Assert code > ------------------------------ > > Key: SHRINKRES-169 > URL: https://issues.jboss.org/browse/SHRINKRES-169 > Project: ShrinkWrap Resolvers > Issue Type: Enhancement > Components: build-resources > Affects Versions: 2.0.2 > Reporter: Karel Piwko > Assignee: Andrew Rubinger > Fix For: 2.1.0 > > > There is plenty of deprecated calls, especially in tests, namely using junitframework.Assert instead of recent org.junit.Assert. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues February 2014