[JBoss JIRA] (SHRINKRES-195) activeProfiles element from settings.xml seems to be ignored, property override not working
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-195?page=com.atlassian.jira.plu... ]
Karel Piwko closed SHRINKRES-195.
---------------------------------
> activeProfiles element from settings.xml seems to be ignored, property override not working
> -------------------------------------------------------------------------------------------
>
> Key: SHRINKRES-195
> URL: https://issues.jboss.org/browse/SHRINKRES-195
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Components: maven
> Affects Versions: 2.0.2
> Environment: Win7 x64
> JDK7u51
> Reporter: Falko M.
> Assignee: Karel Piwko
> Priority: Minor
> Fix For: 2.2.0-beta-1
>
>
> See:
> http://maven.apache.org/settings.html#Active_Profiles
> On the command line (mvn), the element is evaluated as expected and the specified profiles are activated but when I load the very same pom.xml via {{Maven.resolver().offline().loadPomFromFile(...)}}, the respective profiles are ignored, as it seems.
> I came accross this issue when I wanted to override a property from pom.xml in settings.xml and {{ParsedPomFile.getProperties()}} kept returning the non-overriden value.
> Notes:
> - the following in settings.xml *does work*:
> {noformat}
> <activation>
> <activeByDefault>true</activeByDefault>
> </activation>
> {noformat}
> - a new property defined in a settings.xml profile also doesn't show up in {{ParsedPomFile.getProperties()}} which seems to prove that the profile is not actived
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (SHRINKRES-176) MavenImporter archive name
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-176?page=com.atlassian.jira.plu... ]
Karel Piwko updated SHRINKRES-176:
----------------------------------
Component/s: maven
> MavenImporter archive name
> --------------------------
>
> Key: SHRINKRES-176
> URL: https://issues.jboss.org/browse/SHRINKRES-176
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Components: maven
> Reporter: Michael Irwin
> Assignee: Karel Piwko
> Fix For: 2.2.0-beta-1
>
>
> When using the MavenImporter, the archiveName property is ignored.
> {code}
> WebArchive archive = ShrinkWrap.create(MavenImporter.class, "test.war")
> .loadPomFromFile("pom.xml")
> .importBuildOutput()
> .as(WebArchive.class);
> System.out.println(archive.getName());
> {code}
> The archive name will be whatever the name of the Maven artifact is, which is usually [artifactId]-[version].
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (SHRINKRES-190) implements equals and hashCode methods in MavenResolvedArtifactImpl / MavenArtifactInfoImpl
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-190?page=com.atlassian.jira.plu... ]
Karel Piwko updated SHRINKRES-190:
----------------------------------
Component/s: maven
> implements equals and hashCode methods in MavenResolvedArtifactImpl / MavenArtifactInfoImpl
> -------------------------------------------------------------------------------------------
>
> Key: SHRINKRES-190
> URL: https://issues.jboss.org/browse/SHRINKRES-190
> Project: ShrinkWrap Resolvers
> Issue Type: Feature Request
> Components: maven
> Affects Versions: 2.1.1
> Reporter: Mathieu Lachance
> Assignee: Karel Piwko
> Fix For: 2.2.0-beta-1
>
>
> I'm currently to find an effective way to filter out many dependencies at once that I could provide within a "dummy" pom.xml.
> I'd like to do the following:
> {code:java}
> public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveDependencies() {
> return Arrays.asList(
> Maven.resolver()
> .loadPomFromFile("pom.xml")
> .importTestDependencies().resolve()
> .withoutTransitivity()
> .asResolvedArtifact());
> }
>
> public static List<MavenResolvedArtifact> resolveAllArquillianDependencies() {
> return Arrays.asList(
> Maven.resolver()
> .loadPomFromFile("src/test/resources/arquillian.pom.xml")
> .importTestDependencies().resolve()
> .withoutTransitivity()
> .asResolvedArtifact());
> }
>
> public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveNonArquillianDependencies() {
> List<MavenResolvedArtifact> testDependencies = resolveAllTestNonTransitiveDependencies();
>
> List<MavenResolvedArtifact> arquillianDependencies = resolveAllArquillianDependencies();
>
> List<MavenResolvedArtifact> filteredTestDependencies = new ArrayList<MavenResolvedArtifact>();
> for (MavenResolvedArtifact testDependency : testDependencies) {
> if (!arquillianDependencies.contains(testDependency)) {
> filteredTestDependencies.add(testDependency);
> }
> }
> return filteredTestDependencies;
> }
> {code}
> The problem is that MavenResolvedArtifactImpl does not implements equals and hashCode needed for using Collection::contains method.
> I think it would be safe to delegate MavenResolvedArtifactImpl / MavenArtifactInfoImpl equals and hashCode methods to the one defined in MavenCoordinateImpl
> Thanks,
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (SHRINKRES-179) Build Fails in JDK8
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-179?page=com.atlassian.jira.plu... ]
Karel Piwko updated SHRINKRES-179:
----------------------------------
Component/s: maven
> Build Fails in JDK8
> -------------------
>
> Key: SHRINKRES-179
> URL: https://issues.jboss.org/browse/SHRINKRES-179
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Components: maven
> Affects Versions: 2.2.0-alpha-2
> Reporter: Andrew Rubinger
> Assignee: Karel Piwko
> Fix For: 2.2.0-beta-1
>
>
> In environment:
> {code}alr@distortion ~/business/jboss/git/shrinkwrap/resolver $ mvn -version
> Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T12:37:52-05:00)
> Maven home: /usr/local/Cellar/maven/3.2.1/libexec
> Java version: 1.8.0_05, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.9.2", arch: "x86_64", family: "mac"{code}
> The build fails due to:
> {code}[INFO] Running post-build script: /Users/alr/business/jboss/git/shrinkwrap/resolver/maven-plugin/target/it/dependency-tree-scope/verify.bsh
> [INFO] Finished post-build script: /Users/alr/business/jboss/git/shrinkwrap/resolver/maven-plugin/target/it/dependency-tree-scope/verify.bsh
> [INFO] ..SUCCESS (1.4 s)
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO] Passed: 3, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -------------------------------------------------
> [ERROR] The following builds failed:
> [ERROR] * dependency-tree/pom.xml{code}
> Available in the logs:
> https://shrinkwrap.ci.cloudbees.com/view/SWR/job/ShrinkWrap_Resolver_upst...
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (SHRINKRES-194) Multi-module gradle project support
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-194?page=com.atlassian.jira.plu... ]
Karel Piwko updated SHRINKRES-194:
----------------------------------
Component/s: gradle
> Multi-module gradle project support
> -----------------------------------
>
> Key: SHRINKRES-194
> URL: https://issues.jboss.org/browse/SHRINKRES-194
> Project: ShrinkWrap Resolvers
> Issue Type: Sub-requirement
> Components: gradle
> Affects Versions: 2.2.0-alpha-2
> Reporter: Michal Matloka
> Assignee: Michal Matloka
> Fix For: 2.2.0-beta-1
>
>
> Issue from github https://github.com/mmatloka/arquillian-gradle-sample/issues/1:
> {quote}
> Hi,
> I'm very glad for your gradle resolver. However, we have multi project setup in which this code fails with an ArrayIndexOutOfBoundException
> {code}
> final GradleProject gradleProject = projectConnection.getModel(GradleProject.class);
> final File buildDir = new File(projectDir, "build");
> final File libsDir = new File(buildDir, "libs");
> final File result = libsDir.listFiles(new FilenameFilter() {
> @Override
> public boolean accept(final File dir, final String name) {
> return name.startsWith(gradleProject.getName());
> }
> })[0];
> {code}
> This is imho due to the fact that the gradleProject above holds the multi project but the arquillian tests are contained (and should be contained) in the sub project (*server). There the predicate will never be true and the [0] with end up in an exception.
> I think you can either do a deep search to also get the sub project jars or more accurately resolve the project the tests are in. If you need help let me know.
> Best,
> Maik
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (SHRINKRES-96) Separate lifecycle for build-resources package
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-96?page=com.atlassian.jira.plug... ]
Karel Piwko closed SHRINKRES-96.
--------------------------------
Resolution: Done
> Separate lifecycle for build-resources package
> ----------------------------------------------
>
> Key: SHRINKRES-96
> URL: https://issues.jboss.org/browse/SHRINKRES-96
> Project: ShrinkWrap Resolvers
> Issue Type: Enhancement
> Components: api
> Affects Versions: 2.0.0-alpha-6
> Reporter: Karel Piwko
> Assignee: Karel Piwko
> Fix For: 2.0.1
>
>
> Build resources are mostly static. We should change its release cycle and depend on a non-snapshot version.
> That way we will get rid of pom.xml parsing warning in IDE (Eclipse), as plugin execution cannot rely on a project being available from workspace due to security constraints. See JBIDE-13147 for more details on that.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months