September 2014 - shrinkwrap-issues

[JBoss JIRA] (SHRINKRES-73) Improve error message for unsupported type of dependency

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-73?page=com.atlassian.jira.plug... ] Karel Piwko resolved SHRINKRES-73. ---------------------------------- Resolution: Out of Date Packaging type is no longer enum since https://github.com/shrinkwrap/resolver/commit/ee71e55cee525c6985c973542df..., closing this issue as out of date. > Improve error message for unsupported type of dependency > -------------------------------------------------------- > > Key: SHRINKRES-73 > URL: https://issues.jboss.org/browse/SHRINKRES-73 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Affects Versions: 2.0.0-alpha-4 > Reporter: Karel Piwko > Fix For: 2.2.0-alpha-3 > > > <dependency> declaration might contain a type which is not valid at given place, such as import. > We should definitely make exception message better if that happens. > {code} > IllegalArgumentException : Packaging type import is not supported > {code} > As a side note, type can be virtually anything, I'm not sure if we can provide a typesafe enum here. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-181) MavenArtifactInfo is missing <optional> info

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-181?page=com.atlassian.jira.plu... ] Karel Piwko updated SHRINKRES-181: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done Pushed upstream in https://github.com/shrinkwrap/resolver/commit/7d62adc092f51f18e1dab69e06f... and https://github.com/shrinkwrap/resolver/commit/51ac1948caad99c3119d8f6a7c3.... > MavenArtifactInfo is missing <optional> info > -------------------------------------------- > > Key: SHRINKRES-181 > URL: https://issues.jboss.org/browse/SHRINKRES-181 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: api-maven > Affects Versions: 2.2.0-alpha-2 > Reporter: Ales Justin > Assignee: Michal Matloka > Fix For: 2.2.0-alpha-3 > > > There is no way to tell if MavenArtifactInfo is optional, > if not using custom strategy. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-204) Broken filtering of archives via MavenImporter on Windows

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-204?page=com.atlassian.jira.plu... ] Karel Piwko resolved SHRINKRES-204. ----------------------------------- Assignee: Karel Piwko Fix Version/s: 2.2.0-alpha-3 Resolution: Done Landed in https://github.com/shrinkwrap/resolver/commit/43680a21a55dec69a5275002bd2... > Broken filtering of archives via MavenImporter on Windows > --------------------------------------------------------- > > Key: SHRINKRES-204 > URL: https://issues.jboss.org/browse/SHRINKRES-204 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.2.0-alpha-2 > Reporter: Karel Piwko > Assignee: Karel Piwko > Fix For: 2.2.0-alpha-3 > > Attachments: org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.ConfiguredMavenImporterTestCase.txt, org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.JarMavenImporterTestCase.txt, org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.WarMavenImporterTestCase.txt > > > MavenImporter ignores resource filtering - inclusions are not a part of resulting archives on Windows platform. > It is unclear whether this is a bug in implementation or in test bed. To be investigated. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-205) Try to fork and use javac from path in MavenImporter if compiler is not found

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-205?page=com.atlassian.jira.plu... ] Karel Piwko resolved SHRINKRES-205. ----------------------------------- Assignee: Karel Piwko Fix Version/s: 2.2.0-alpha-3 Resolution: Done Landed in https://github.com/shrinkwrap/resolver/commit/8aa0d2be9303b4b1a792de6a474... > Try to fork and use javac from path in MavenImporter if compiler is not found > ----------------------------------------------------------------------------- > > Key: SHRINKRES-205 > URL: https://issues.jboss.org/browse/SHRINKRES-205 > Project: ShrinkWrap Resolvers > Issue Type: Enhancement > Components: impl-maven > Affects Versions: 2.2.0-alpha-2 > Reporter: Karel Piwko > Assignee: Karel Piwko > Fix For: 2.2.0-alpha-3 > > > In cases MavenImporter does not find Javac class, IDE is probably set to run on top of JRE instead of JDK. In such cases, MavenImporter can emit a warning and modify configuration to fork and use javac from $PATH. > Such approach will make compilation more robust. > See https://gist.github.com/kpiwko/626ed1c04ac28354137d for a quick idea how it could work. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-204) Broken filtering of archives via MavenImporter on Windows

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-204?page=com.atlassian.jira.plu... ] Karel Piwko commented on SHRINKRES-204: --------------------------------------- Problem is related to trailing slash / being removed in https://github.com/shrinkwrap/resolver/blob/master/impl-maven-archive/src... In such case default include pattern **/** is not triggered. > Broken filtering of archives via MavenImporter on Windows > --------------------------------------------------------- > > Key: SHRINKRES-204 > URL: https://issues.jboss.org/browse/SHRINKRES-204 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.2.0-alpha-2 > Reporter: Karel Piwko > Attachments: org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.ConfiguredMavenImporterTestCase.txt, org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.JarMavenImporterTestCase.txt, org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.WarMavenImporterTestCase.txt > > > MavenImporter ignores resource filtering - inclusions are not a part of resulting archives on Windows platform. > It is unclear whether this is a bug in implementation or in test bed. To be investigated. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-202) withClassPathResolution method in ConfigurableMavenResolverSystemImpl ignores parameter

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-202?page=com.atlassian.jira.plu... ] Karel Piwko updated SHRINKRES-202: ---------------------------------- Labels: starter (was: ) > withClassPathResolution method in ConfigurableMavenResolverSystemImpl ignores parameter > --------------------------------------------------------------------------------------- > > Key: SHRINKRES-202 > URL: https://issues.jboss.org/browse/SHRINKRES-202 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.1.1 > Reporter: Daniele Gaffuri > Priority: Minor > Labels: starter > Fix For: 2.2.0-alpha-3 > > > The implementation of withClassPathResolution in org.jboss.shrinkwrap.resolver.impl.maven.ConfigurableMavenResolverSystemImpl ignores its parameter and always disables resolution > {code} > public ConfigurableMavenResolverSystem withClassPathResolution(boolean useClassPathResolution) { > getMavenWorkingSession().disableClassPathWorkspaceReader(); > return this; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-202) withClassPathResolution method in ConfigurableMavenResolverSystemImpl ignores parameter

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-202?page=com.atlassian.jira.plu... ] Karel Piwko updated SHRINKRES-202: ---------------------------------- Fix Version/s: 2.2.0-alpha-3 > withClassPathResolution method in ConfigurableMavenResolverSystemImpl ignores parameter > --------------------------------------------------------------------------------------- > > Key: SHRINKRES-202 > URL: https://issues.jboss.org/browse/SHRINKRES-202 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.1.1 > Reporter: Daniele Gaffuri > Priority: Minor > Labels: starter > Fix For: 2.2.0-alpha-3 > > > The implementation of withClassPathResolution in org.jboss.shrinkwrap.resolver.impl.maven.ConfigurableMavenResolverSystemImpl ignores its parameter and always disables resolution > {code} > public ConfigurableMavenResolverSystem withClassPathResolution(boolean useClassPathResolution) { > getMavenWorkingSession().disableClassPathWorkspaceReader(); > return this; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-202) withClassPathResolution method in ConfigurableMavenResolverSystemImpl ignores parameter

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-202?page=com.atlassian.jira.plu... ] Karel Piwko commented on SHRINKRES-202: --------------------------------------- Nice catch! > withClassPathResolution method in ConfigurableMavenResolverSystemImpl ignores parameter > --------------------------------------------------------------------------------------- > > Key: SHRINKRES-202 > URL: https://issues.jboss.org/browse/SHRINKRES-202 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.1.1 > Reporter: Daniele Gaffuri > Priority: Minor > Labels: starter > Fix For: 2.2.0-alpha-3 > > > The implementation of withClassPathResolution in org.jboss.shrinkwrap.resolver.impl.maven.ConfigurableMavenResolverSystemImpl ignores its parameter and always disables resolution > {code} > public ConfigurableMavenResolverSystem withClassPathResolution(boolean useClassPathResolution) { > getMavenWorkingSession().disableClassPathWorkspaceReader(); > return this; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-205) Try to fork and use javac from path in MavenImporter if compiler is not found

by Karel Piwko (JIRA)

Karel Piwko created SHRINKRES-205: ------------------------------------- Summary: Try to fork and use javac from path in MavenImporter if compiler is not found Key: SHRINKRES-205 URL: https://issues.jboss.org/browse/SHRINKRES-205 Project: ShrinkWrap Resolvers Issue Type: Enhancement Components: impl-maven Affects Versions: 2.2.0-alpha-2 Reporter: Karel Piwko In cases MavenImporter does not find Javac class, IDE is probably set to run on top of JRE instead of JDK. In such cases, MavenImporter can emit a warning and modify configuration to fork and use javac from $PATH. Such approach will make compilation more robust. See https://gist.github.com/kpiwko/626ed1c04ac28354137d for a quick idea how it could work. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-204) Broken filtering of archives via MavenImporter on Windows

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-204?page=com.atlassian.jira.plu... ] Karel Piwko updated SHRINKRES-204: ---------------------------------- Attachment: org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.ConfiguredMavenImporterTestCase.txt org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.JarMavenImporterTestCase.txt org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.WarMavenImporterTestCase.txt Attaching logs from Surefire tests. > Broken filtering of archives via MavenImporter on Windows > --------------------------------------------------------- > > Key: SHRINKRES-204 > URL: https://issues.jboss.org/browse/SHRINKRES-204 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Components: impl-maven > Affects Versions: 2.2.0-alpha-2 > Reporter: Karel Piwko > Attachments: org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.ConfiguredMavenImporterTestCase.txt, org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.JarMavenImporterTestCase.txt, org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.WarMavenImporterTestCase.txt > > > MavenImporter ignores resource filtering - inclusions are not a part of resulting archives on Windows platform. > It is unclear whether this is a bug in implementation or in test bed. To be investigated. -- This message was sent by Atlassian JIRA (v6.3.1#6329)

9 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues September 2014