]
David Bosschaert commented on SHRINKWRAP-244:
---------------------------------------------
I'm not sure how the inner class is relevant here. That seems like a completely
different issue...
In general I think the tests look good.
I did leave a comment on the code change you're proposing in
Probably best to get one of the real ShrinkWrap guys to review your changes too :)
When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL
gets used instead
-------------------------------------------------------------------------------------
Key: SHRINKWRAP-244
URL:
https://issues.jboss.org/browse/SHRINKWRAP-244
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-12
Reporter: David Bosschaert
Assignee: Davide D'Alto
When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to
load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(),
which is called indirectly from the previous addClass method. The addPackages still uses
the TCCL while it should really use the cl passed in to the addClass method.
This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used
could be inferred from the cls argument, but instead the TCCL gets used...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: