[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading
[
https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.pl...
]
Karel Piwko commented on SHRINKWRAP-265:
----------------------------------------
Subject to discussion:
Say we have TransitiveDependencyResolver strategy and StrictDependencyResolver strategy.
We can't simply have "<T extends Archive<T>> T" as a return type
for the latter, as user might want to call
{code}
MavenDependencyResolver.artifacts("foo:bar", "foo:barbar")...
{code}
which simply implies multiple dependencies resolved.
MavenDependencyResolver.resolveAs is misleading
-----------------------------------------------
Key: SHRINKWRAP-265
URL: https://issues.jboss.org/browse/SHRINKWRAP-265
Project: ShrinkWrap
Issue Type: Task
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Samuel Santos
Assignee: Samuel Santos
The method name {{resolveAs}} is misleading as it does not imply any dependencies.
We should refactor it into two distinct methods:
{code}
<T extends Archive<T>> Collection<T>
MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact
and its dependencies
<T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return
the artifact without any dependencies
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira