[
https://issues.jboss.org/browse/SHRINKRES-81?page=com.atlassian.jira.plug...
]
Karel Piwko edited comment on SHRINKRES-81 at 11/4/12 9:05 AM:
---------------------------------------------------------------
Michal, I did better encapsulation as a side effect when working on SHRINKRES-78.
Basically I took ResolvedArtifactInfo from your implementation, split it into
ResolvedArtifact and MavenResolvedArtifact. MavenResolvedArtifact is the object passed in
between Strategy and Format Stages now. Code is available here
https://github.com/kpiwko/resolver/tree/SHRINKRES-78
was (Author: kpiwko):
Michal, I did better encapsulation as a part of SHRINKRES-78.
Poor encapsulation, passing around Aether (Artifact) objects when we
should be using our own
--------------------------------------------------------------------------------------------
Key: SHRINKRES-81
URL:
https://issues.jboss.org/browse/SHRINKRES-81
Project: ShrinkWrap Resolvers
Issue Type: Task
Reporter: Michal Matloka
Assignee: Michal Matloka
TODO located in MavenStrategyBaseImpl
// TODO Poor encapsulation, passing around Aether (Artifact) objects when we should be
using our own
// representation
and
MavenWorkingSession
// TODO We're not really encapsulating much here, as we expose out Aether and Maven
classes. Refactor this class and
// usages to hide all implementation details of Maven and Aether *behind* this SPI
facade
Some of this refactors has to be made for SHRINKRES-27
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira