2:35 p.m.
Karel Piwko created SHRINKRES-76:
------------------------------------
Summary: Version of the dependency is not found when <exclusion>s are
defined
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:57 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Karel Piwko commented on SHRINKRES-76:
--------------------------------------
Andrew, we need to agree on the strategy for this issue:
Either we will remove exclusions from equals(Object) method or create coordinateEquals()
or something like that. What do you prefer? You've added exclusions to equals(Object),
so I guess you would prefer the later, I'm still in favor of the first.
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:47 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Ales Justin commented on SHRINKRES-76:
--------------------------------------
This is also broken for a dependency that has anything else defined; e.g. <scope> or
<optional>.
Atm it only knows how to match plain groupId + artifactId + version.
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:53 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-76:
------------------------------------------
I was being overeager in determining value equality for dependencies; I don't think we
actually have a use case which mandates we match on anything other than GAV.
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:31 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Tair Sabirgaliev commented on SHRINKRES-76:
-------------------------------------------
What about MavenCoordinate.satisfies(MavenCoordinate)?
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:35 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Tair Sabirgaliev edited comment on SHRINKRES-76 at 10/31/12 4:34 PM:
---------------------------------------------------------------------
What about -MavenCoordinate- MavenDependency.satisfies(MavenCoordinate)?
was (Author: tair.sabirgaliev):
What about MavenCoordinate.satisfies(MavenCoordinate)?
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-76:
------------------------------------------
Tair: What use case mandates that? I think if we do value equality only based on GAV,
that should suffice; do you see evidence to the contrary?
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:21 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Tair Sabirgaliev commented on SHRINKRES-76:
-------------------------------------------
Hmm, another option is to just hardcode that `satisfies` logic into
PomEquippedResolveStageBaseImpl.resolveVersion(MavenDependency). This is what I can think
of looking at the `resolveVersion` call-tree :)
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Tair Sabirgaliev commented on SHRINKRES-76:
-------------------------------------------
And you wanna say "equality based on Group-Artifact" not "GAV", right?
The current `equals` impl. doesn't compare versions, so why should it consider
exclusions.. :)
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Tair Sabirgaliev edited comment on SHRINKRES-76 at 10/31/12 5:47 PM:
---------------------------------------------------------------------
And you wanna say "equality based on Group-Artifact" not "GAV", right?
The current `equals` impl. doesn't compare versions, so why should it consider
exclusions.. :) and BTW all the other stuff, like scope and optionality.
was (Author: tair.sabirgaliev):
And you wanna say "equality based on Group-Artifact" not "GAV",
right? The current `equals` impl. doesn't compare versions, so why should it consider
exclusions.. :)
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-76:
------------------------------------------
Hehe, yes, by "GA", not version. Maven docs explicitly say that versions
shouldn't be consulted when determining dependency declaration equality, so at least I
was smart enough to leave *those* out. :)
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-76:
------------------------------------------
Status update, Tair?
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:08 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Tair Sabirgaliev commented on SHRINKRES-76:
-------------------------------------------
Attempt 1: https://github.com/shrinkwrap/resolver/pull/19
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger updated SHRINKRES-76:
-------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 2.0.0-alpha-5
Resolution: Done
Upstream:
https://github.com/shrinkwrap/resolver/commit/8b061a8d04418c5bcd3ffc1bc46...
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Fix For: 2.0.0-alpha-5
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger updated SHRINKRES-76:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/shrinkwrap/resolver/pull/19
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Fix For: 2.0.0-alpha-5
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-76?page=com.atlassian.jira.plug...
]
Andrew Rubinger reassigned SHRINKRES-76:
----------------------------------------
Assignee: Tair Sabirgaliev (was: Andrew Rubinger)
Version of the dependency is not found when <exclusion>s are
defined
--------------------------------------------------------------------
Key: SHRINKRES-76
URL: https://issues.jboss.org/browse/SHRINKRES-76
Project: ShrinkWrap Resolvers
Issue Type: Bug
Components: impl-maven
Affects Versions: 2.0.0-alpha-4
Reporter: Karel Piwko
Assignee: Tair Sabirgaliev
Fix For: 2.0.0-alpha-5
equals(Object) method for Maven dependency is considering exclusions as well.
This effectively means that if you specify following in your pom.xml file:
{code:xml}
<dependency>
<groupId>com.google.appengine.orm</groupId>
<artifactId>datanucleus-appengine</artifactId>
<version>${version.org.datanucleus.gae}</version>
<exclusions>
<exclusion>
<!-- Force this just in case -->
<groupId>org.jboss.maven.plugins</groupId>
<artifactId>arquillian-transformer</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
then following code:
{code}
Maven.resolver().loadPomFromFile("/path/to/file").resolve("com.google.appengine.orm:datanucleus-appengine")
{code}
is not able to find the version managed in pom.xml, failing with:
Caused by: org.jboss.shrinkwrap.resolver.api.ResolutionException: Unable to get version
for dependency specified by com.google.appengine.orm:datanucleus-appengine, it was not
provided in <dependencyManagement> section.
at
org.jboss.shrinkwrap.resolver.impl.maven.PomEquippedResolveStageBaseImpl.resolveVersion(PomEquippedResolveStageBaseImpl.java:194)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4213
days inactive
4232
days old
shrinkwrap-issues@lists.jboss.org
15 comments
4 participants
participants (4)
-
Ales Justin (JIRA) -
Andrew Rubinger (JIRA)
-
Karel Piwko (JIRA)
-
Tair Sabirgaliev (JIRA)