[JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collections<String> and Collection<MavenDependency>
10:04 p.m.
Andrew Rubinger created SHRINKRES-66:
----------------------------------------
Summary: Allow "resolve" to take in Collections<String> and
Collection<MavenDependency>
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-3, 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Andrew Rubinger
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing the
API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:04 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Andrew Rubinger updated SHRINKRES-66:
-------------------------------------
Assignee: (was: Andrew Rubinger)
Allow "resolve" to take in Collections<String> and
Collection<MavenDependency>
------------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:29 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Karel Piwko updated SHRINKRES-66:
---------------------------------
Labels: starter (was: )
Allow "resolve" to take in Collections<String> and
Collection<MavenDependency>
------------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Labels: starter
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:53 a.m.
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-66:
------------------------------------------
We need to debate how to go about API name changes here. Collections<String> and
Collection<MavenDependency> will have the same erasure when the compiler is done
with them, so we might start to explore renaming all the "resolve" methods to be
specific as to their input types.
Allow "resolve" to take in Collections<String> and
Collection<MavenDependency>
------------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Labels: starter
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:14 a.m.
New subject: [JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collection<String> and Collection<MavenDependency>
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Andrew Rubinger updated SHRINKRES-66:
-------------------------------------
Summary: Allow "resolve" to take in Collection<String> and
Collection<MavenDependency> (was: Allow "resolve" to take in
Collections<String> and Collection<MavenDependency>)
Allow "resolve" to take in Collection<String> and
Collection<MavenDependency>
-----------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Labels: starter
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 p.m.
New subject: [JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collection<String> and Collection<MavenDependency>
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-66:
------------------------------------------
Added candidate to solve this in:
https://github.com/ALRubinger/resolver/commit/8744d8c99f56457b04aec17e735...;
garner feedback on API name changes before pushing upstream.
Allow "resolve" to take in Collection<String> and
Collection<MavenDependency>
-----------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Labels: starter
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 a.m.
New subject: [JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collection<String> and Collection<MavenDependency>
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Karel Piwko commented on SHRINKRES-66:
--------------------------------------
Copying comment from github here:
I've seen those yesterday. I don't like the change. It makes the API too verbose.
I'm wondering what's the point of having method which resolves based on
MavenDependency instead of coordinates.
While the MavenDependency might give you better control, you can't really get much
from it:
you still need string coordinate
specifying optional does not make much sense, why would you try to resolve something
optional or filter on optional dependencies?
specifying scope does not make much sense neither for very same reason
Having possibility to add exclusions is tempting. However, we can promote filters here.
Moreover, filters give you an ability to globally exclude for free. Trying to get 1:1
matching with Maven only makes API too complex without giving a real advantage.
The only disadvantage happens when you want to exclude G:A(V1) from dependency and and
G:A:V2 to be resolved. Then you have to write a custom filter, because current ones ignore
version.
To conclude, I vote for having String-based resolve(), addDependency() methods only.
Allow "resolve" to take in Collection<String> and
Collection<MavenDependency>
-----------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Labels: starter
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:53 a.m.
New subject: [JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collection<String> and Collection<MavenDependency>
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Andrew Rubinger resolved SHRINKRES-66.
--------------------------------------
Assignee: Andrew Rubinger
Fix Version/s: 2.0.0-alpha-5
Resolution: Done
Resolved discussion on GitHub.
Conclusion: "resolve" to accept String, String..., Collection<String>.
"addDependency" to accept MavenDependency, MavenDependency...,
Collection<MavenDependency>.
Upstream:
https://github.com/shrinkwrap/resolver/commit/908b0c3e9e1723fc983d5782b6c...
Allow "resolve" to take in Collection<String> and
Collection<MavenDependency>
-----------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Assignee: Andrew Rubinger
Labels: starter
Fix For: 2.0.0-alpha-5
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4937
days inactive
4945
days old
shrinkwrap-issues@lists.jboss.org
7 comments
2 participants
participants (2)
-
Andrew Rubinger (JIRA) -
Karel Piwko (JIRA)