[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Andrew Rubinger commented on SHRINKDESC-54: ------------------------------------------- Notes for topic development are noted in the pull request: https://github.com/shrinkwrap/descriptors/pull/26 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Andrew Rubinger updated SHRINKDESC-54: -------------------------------------- Description: This task to track the extensive refactoring and reworking of Descriptors as done through the POC offered by Ralf Battenfield. (was: This task to track the extensive refactoring and reworking of Descriptors as done by Ralf Battenfield.) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Andrew Rubinger updated SHRINKDESC-54: -------------------------------------- Description: This task to track the extensive refactoring and reworking of Descriptors as done through the POC offered by Ralf Battenfeld. (was: This task to track the extensive refactoring and reworking of Descriptors as done through the POC offered by Ralf Battenfield.) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Aslak Knutsen edited comment on SHRINKDESC-54 at 8/21/11 3:18 PM: ------------------------------------------------------------------ Just a few comments from the latest build: * WebApp30Descriptor vs WebAppDescriptor We have version in the PackageName already, org.jboss.shrinkwrap.descriptor.api.webapp30 * getAllServlet() removeAllServlet() vs getAllServlets() removeAllServlets() Since we can remove multiple, the API should reflect that in plural form * unset distributable() Boolean distributable can be set and read(isDistributable), but not unset * WebAppVersionType._3_0 vs WebAppVersionType.3_0 Why the extra underscore? And if we have one generated 'package' pr version, do we need to set the version at all ? * Missing some xml escape in javadoc comments See the Example: http://jboss.hudson.alrubinger.com/job/Descriptors_1.2.0-X/javadoc/org/jb... * getOrCreate on elements that support multiple ? getOrCreateFilter() get a previous created Filter if any or create one? was (Author: aslak): Just a few comments from the latest build: * WebApp30Descriptor vs WebAppDescriptor We have version in the PackageName already, org.jboss.shrinkwrap.descriptor.api.webapp30 * getAllServlet() removeAllServlet() vs getAllServlets() removeAllServlets() Since we can remove multiple, the API should reflect that in plural form * unset distributable() Boolean distributable can be set and read(isDistributable), but not unset * WebAppVersionType._3_0 vs WebAppVersionType.3_0 Why the extra underscore? And if we have one generated 'package' pr version, do we need to set the version at all ? * Missing some xml escape in javadoc comments See the Example: http://jboss.hudson.alrubinger.com/job/Descriptors_1.2.0-X/javadoc/org/jb... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Aslak Knutsen edited comment on SHRINKDESC-54 at 8/22/11 5:58 AM: ------------------------------------------------------------------ * WebAppVersionType._3_0 vs WebAppVersionType.3_0 --> The extra underscore is related to some of the defined enums which cannot be transfered 100% to java enums. They start for example with numbers like 1.x or 2.x. I wanted to have a procedure that works for all enums. But if you wish, I can check if the enum name starts with a number and only then a underscore will be added. -->--> Sorry, of course java does not allow numbers to start names. Didn't cross my mind at the time. :) * Missing some xml escape in javadoc comments --> I am not sure what the problem is here. Looking at the original documentation, it should be one to one the same. Is it the '[' character? -->--> The XML tags are not shown in the rendered HTML. I guess it should be written within a <pre> or by escaping the xml tags in the example &lt;xml&gt; * getOrCreate on elements that support multiple ? --> Yes, in case of a multiple element, if returns the first one, if already created or creates a new one, if no element was defined before. -->--> To me getOrCreate only makes sense if only one element is supported. Maybe single elements should have, getX, getOrCreateX, removeX While multiple has: getAllXs, createX, removeAllXs, and possible for removing single instances removeX(XType) was (Author: aslak): * WebAppVersionType._3_0 vs WebAppVersionType.3_0 --> The extra underscore is related to some of the defined enums which cannot be transfered 100% to java enums. They start for example with numbers like 1.x or 2.x. I wanted to have a procedure that works for all enums. But if you wish, I can check if the enum name starts with a number and only then a underscore will be added. -->--> Sorry, of course java does not allow numbers to start names. Didn't cross my mind at the time. :) Missing some xml escape in javadoc comments --> I am not sure what the problem is here. Looking at the original documentation, it should be one to one the same. Is it the '[' character? -->--> The XML tags are not shown in the rendered HTML. I guess it should be written within a <pre> or by escaping the xml tags in the example &lt;xml&gt; getOrCreate on elements that support multiple ? --> Yes, in case of a multiple element, if returns the first one, if already created or creates a new one, if no element was defined before. -->--> To me getOrCreate only makes sense if only one element is supported. Maybe single elements should have, getX, getOrCreateX, removeX While multiple has: getAllXs, createX, removeAllXs, and possible for removing single instances removeX(XType) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Aslak Knutsen edited comment on SHRINKDESC-54 at 8/22/11 5:59 AM: ------------------------------------------------------------------ * WebAppVersionType._3_0 vs WebAppVersionType.3_0 ** The extra underscore is related to some of the defined enums which cannot be transfered 100% to java enums. They start for example with numbers like 1.x or 2.x. I wanted to have a procedure that works for all enums. But if you wish, I can check if the enum name starts with a number and only then a underscore will be added. *** Sorry, of course java does not allow numbers to start names. Didn't cross my mind at the time. :) * Missing some xml escape in javadoc comments ** I am not sure what the problem is here. Looking at the original documentation, it should be one to one the same. Is it the '[' character? *** The XML tags are not shown in the rendered HTML. I guess it should be written within a <pre> or by escaping the xml tags in the example &lt;xml&gt; * getOrCreate on elements that support multiple ? ** Yes, in case of a multiple element, if returns the first one, if already created or creates a new one, if no element was defined before. *** To me getOrCreate only makes sense if only one element is supported. Maybe single elements should have, getX, getOrCreateX, removeX, while multiple has: getAllXs, createX, removeAllXs, and possible for removing single instances removeX(XType) was (Author: aslak): * WebAppVersionType._3_0 vs WebAppVersionType.3_0 --> The extra underscore is related to some of the defined enums which cannot be transfered 100% to java enums. They start for example with numbers like 1.x or 2.x. I wanted to have a procedure that works for all enums. But if you wish, I can check if the enum name starts with a number and only then a underscore will be added. -->--> Sorry, of course java does not allow numbers to start names. Didn't cross my mind at the time. :) * Missing some xml escape in javadoc comments --> I am not sure what the problem is here. Looking at the original documentation, it should be one to one the same. Is it the '[' character? -->--> The XML tags are not shown in the rendered HTML. I guess it should be written within a <pre> or by escaping the xml tags in the example &lt;xml&gt; * getOrCreate on elements that support multiple ? --> Yes, in case of a multiple element, if returns the first one, if already created or creates a new one, if no element was defined before. -->--> To me getOrCreate only makes sense if only one element is supported. Maybe single elements should have, getX, getOrCreateX, removeX While multiple has: getAllXs, createX, removeAllXs, and possible for removing single instances removeX(XType) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Aslak Knutsen edited comment on SHRINKDESC-54 at 8/22/11 6:01 AM: ------------------------------------------------------------------ * WebAppVersionType._3_0 vs WebAppVersionType.3_0 ** The extra underscore is related to some of the defined enums which cannot be transfered 100% to java enums. They start for example with numbers like 1.x or 2.x. I wanted to have a procedure that works for all enums. But if you wish, I can check if the enum name starts with a number and only then a underscore will be added. *** Sorry, of course java does not allow numbers to start names. Didn't cross my mind at the time. :) * Missing some xml escape in javadoc comments ** I am not sure what the problem is here. Looking at the original documentation, it should be one to one the same. Is it the '[' character? *** The XML tags are not shown in the rendered HTML. I guess it should be written within a <pre> or by escaping the xml tags in the example \&\l\t\;xml\&\g\t\; (without the escape \ mixed in there for this view to render it.. ) * getOrCreate on elements that support multiple ? ** Yes, in case of a multiple element, if returns the first one, if already created or creates a new one, if no element was defined before. *** To me getOrCreate only makes sense if only one element is supported. Maybe single elements should have, getX, getOrCreateX, removeX, while multiple has: getAllXs, createX, removeAllXs, and possible for removing single instances removeX(XType) was (Author: aslak): * WebAppVersionType._3_0 vs WebAppVersionType.3_0 ** The extra underscore is related to some of the defined enums which cannot be transfered 100% to java enums. They start for example with numbers like 1.x or 2.x. I wanted to have a procedure that works for all enums. But if you wish, I can check if the enum name starts with a number and only then a underscore will be added. *** Sorry, of course java does not allow numbers to start names. Didn't cross my mind at the time. :) * Missing some xml escape in javadoc comments ** I am not sure what the problem is here. Looking at the original documentation, it should be one to one the same. Is it the '[' character? *** The XML tags are not shown in the rendered HTML. I guess it should be written within a <pre> or by escaping the xml tags in the example &lt;xml&gt; * getOrCreate on elements that support multiple ? ** Yes, in case of a multiple element, if returns the first one, if already created or creates a new one, if no element was defined before. *** To me getOrCreate only makes sense if only one element is supported. Maybe single elements should have, getX, getOrCreateX, removeX, while multiple has: getAllXs, createX, removeAllXs, and possible for removing single instances removeX(XType) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu... ] Andrew Rubinger resolved SHRINKDESC-54. --------------------------------------- Resolution: Done Resolving by linked issues and commits. Future development to have more fine-grained issues opened against a new version, starting at 1.2.0-alpha-2 and up. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira