[JBoss JIRA] (SHRINKRES-64) Fix cyclic dependency in PluginIntegrationTestCase.strictlyLoadTestDependencies
11:10 p.m.
Andrew Rubinger created SHRINKRES-64:
----------------------------------------
Summary: Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Andrew Rubinger
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:43 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-64?page=com.atlassian.jira.plug...
]
Karel Piwko reassigned SHRINKRES-64:
------------------------------------
Assignee: Karel Piwko (was: Andrew Rubinger)
Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
-------------------------------------------------------------------------------
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Karel Piwko
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:43 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-64?page=com.atlassian.jira.plug...
]
Karel Piwko edited comment on SHRINKRES-64 at 10/29/12 3:42 PM:
----------------------------------------------------------------
The whole idea of having plugin tests as a part of impl-maven is wrong. It would be much
better to execute test as a part of maven-invoker-plugin configuration in plugin module
itself.
Current setup break importing the project into IDE (JBDS) when no version is installed in
local repository.
was (Author: kpiwko):
The whole idea of having plugin tests a part of impl-maven is wrong. It would be much
better to execute test as a part of maven-invoker-plugin configuration in plugin
implementation itself.
Current setup break importing the project into IDE (JBDS) when no version is installed in
local repository.
Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
-------------------------------------------------------------------------------
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Karel Piwko
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:43 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-64?page=com.atlassian.jira.plug...
]
Karel Piwko commented on SHRINKRES-64:
--------------------------------------
The whole idea of having plugin tests a part of impl-maven is wrong. It would be much
better to execute test as a part of maven-invoker-plugin configuration in plugin
implementation itself.
Current setup break importing the project into IDE (JBDS) when no version is installed in
local repository.
Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
-------------------------------------------------------------------------------
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Andrew Rubinger
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-64?page=com.atlassian.jira.plug...
]
Karel Piwko updated SHRINKRES-64:
---------------------------------
Fix Version/s: 2.0.0-alpha-5
Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
-------------------------------------------------------------------------------
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Karel Piwko
Fix For: 2.0.0-alpha-5
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-64?page=com.atlassian.jira.plug...
]
Karel Piwko updated SHRINKRES-64:
---------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/shrinkwrap/resolver/pull/20
Added a pull request which should solve the issue.
Note: Invoker plugin prepares a local repository. This needs to access internet and thus
plugin tests take ~ 1 minute. If we want to reduce the time, we can move invoker execution
into separate profile and execute it only in CI builds.
Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
-------------------------------------------------------------------------------
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Karel Piwko
Fix For: 2.0.0-alpha-5
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 p.m.
[
https://issues.jboss.org/browse/SHRINKRES-64?page=com.atlassian.jira.plug...
]
Andrew Rubinger updated SHRINKRES-64:
-------------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Upstream:
https://github.com/shrinkwrap/resolver/commit/e6c57aafae2e0207c91926362ef...
Fix cyclic dependency in
PluginIntegrationTestCase.strictlyLoadTestDependencies
-------------------------------------------------------------------------------
Key: SHRINKRES-64
URL: https://issues.jboss.org/browse/SHRINKRES-64
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2
Reporter: Andrew Rubinger
Assignee: Karel Piwko
Fix For: 2.0.0-alpha-5
This test will attempt to load *current* versions, which are not in place during a
release:
{code}$ ls -l
/home/alr/.m2/repository/org/jboss/shrinkwrap/resolver/shrinkwrap-resolver-api-maven/2.0.0-alpha-2/
total 12
-rw-rw-r-- 1 alr alr 164 2012-09-13 00:01 m2e-lastUpdated.properties
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.jar.lastUpdated
-rw-rw-r-- 1 alr alr 235 2012-09-13 00:01
shrinkwrap-resolver-api-maven-2.0.0-alpha-2.pom.lastUpdated{code}
For now the test will be @Ignore'd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4897
days inactive
4951
days old
shrinkwrap-issues@lists.jboss.org
6 comments
2 participants
participants (2)
-
Andrew Rubinger (JIRA) -
Karel Piwko (JIRA)