Ladies and Gentlemen, As I imported gatein-portal into my Eclipse workspace, my m2e (an Eclipse plugin) has by itself inserted the following two lines into the two *.launch files under gatein-portal/testsuite/selenium-snifftests/src/eclipse: <stringAttribute key="org.eclipse.jdt.launching.CLASSPATH_PROVIDER" value="org.eclipse.m2e.launchconfig.classpathProvider"/> <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.m2e.launchconfig.sourcepathProvider"/> I would like to learn what should happen with these changes. Yes, I could surely tell git to never commit it somehow but generally, would it not be better not to have IDE-specific files commited to scm? Thanks, Peter _______________________________________________ gatein-dev mailing list gatein-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/gatein-dev

Bolek, the *.launch files have nothing to do with maven or project-level settings. They are just launch configurations which allow Eclipse users to run something. I guess these particular can be used to run a main method of org.openqa.selenium.server.SeleniumServer and org.exoplatform.portal.selenium.SeleniumTestCaseGenerator. Just .gitignore-ing them would be OK for me, but if there is noone who actually uses them, they could be removed altogether. So, please raise your hand, everyone who uses those launch configurations! Best, Peter On 2012-06-11 10:31, Boleslaw Dawidowicz wrote: > I'm not an Eclipse user myself (IntelliJ IDEA FTW) so I cannot comment on those settings. > However we agreed quite a long time ago that we don't want to keep IDE related files in source control. There is always additional maintenance related to this. > > I personally don't see the benefit as IDEA has first class maven support and I just import project by pointing to pom. Does it make that much sense for Eclipse project files actually? > > Bolek > > On Jun 8, 2012, at 3:41 PM, Peter Palaga wrote: > >> Ladies and Gentlemen, >> >> As I imported gatein-portal into my Eclipse workspace, my m2e (an >> Eclipse plugin) has by itself inserted the following two lines into the >> two *.launch files under >> gatein-portal/testsuite/selenium-snifftests/src/eclipse: >> >> <stringAttribute key="org.eclipse.jdt.launching.CLASSPATH_PROVIDER" >> value="org.eclipse.m2e.launchconfig.classpathProvider"/> >> <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" >> value="org.eclipse.m2e.launchconfig.sourcepathProvider"/> >> >> I would like to learn what should happen with these changes. Yes, I >> could surely tell git to never commit it somehow but generally, would it >> not be better not to have IDE-specific files commited to scm? >> >> Thanks, >> >> Peter >> _______________________________________________ >> gatein-dev mailing list >> gatein-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/gatein-dev

Hi all, there are 2 ways to run selenium tests: use maven or run as JUnit test in Eclipse (details in testsuite/selenium-snifftests/Readme.txt) If you want to run it in eclipse: gatein-selenium-GenerateSniffTests.launch --> is used to run SeleniumTestCaseGenerator class to generate SeleneseTestCase gatein-selenium-StartSeleniumServer.launch --> is used to run SeleniumServer Those files : *.launch are eclipse's configuration files, they was created for sharing configurations purpose. People using Eclipse can create theirself those *.launch files (Choose Run As --> Run Configuration...). So we can remove them, and update the Readme.txt file (guide how to create launch for running selenium in Eclipse) Problem with m2e eclipse plugin with *.laungh files can be found here : http://www.subshell.com/en/subshell/blog/article-Changing-from-m2eclipse-... On Fri, Jun 8, 2012 at 8:41 PM, Peter Palaga <ppalaga(a)redhat.com&gt; wrote: > Ladies and Gentlemen, > > As I imported gatein-portal into my Eclipse workspace, my m2e (an > Eclipse plugin) has by itself inserted the following two lines into the > two *.launch files under > gatein-portal/testsuite/selenium-snifftests/src/eclipse: > > <stringAttribute key="org.eclipse.jdt.launching.CLASSPATH_PROVIDER" > value="org.eclipse.m2e.launchconfig.classpathProvider"/> > <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" > value="org.eclipse.m2e.launchconfig.sourcepathProvider"/> > > I would like to learn what should happen with these changes. Yes, I > could surely tell git to never commit it somehow but generally, would it > not be better not to have IDE-specific files commited to scm? > > Thanks, > > Peter > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/gatein-dev >

Thank you for the thorough statement, Vu. I personally would not mind ignoring the files but through pushing this, I am actually trying to improve the experience of all newcoming Eclipse users. It is much easier for them to submit patches when there are no such unexpected changes immediately after the import. Anyway, thank you for being ready to resolve it. Best, Peter P.S.: Are there eclipse users at eXo? On 2012-06-13 11:04, Phuong Viet VU wrote: > @Peter : I mean you can ignore changes made by eclipse on those *.laungh files. We will remove them and update doc soon > > On Wed, Jun 13, 2012 at 3:39 PM, Phuong Viet VU <phuongvv(a)exoplatform.com (mailto:phuongvv@exoplatform.com)> wrote: > > Hi all, there are 2 ways to run selenium tests: use maven or run as JUnit test in Eclipse (details in testsuite/selenium-snifftests/Readme.txt) > > > > If you want to run it in eclipse: > > gatein-selenium-GenerateSniffTests.launch --> is used to run SeleniumTestCaseGenerator class to generate SeleneseTestCase > > gatein-selenium-StartSeleniumServer.launch --> is used to run SeleniumServer > > > > Those files : *.launch are eclipse's configuration files, they was created for sharing configurations purpose. People using Eclipse can create theirself those *.launch files (Choose Run As --> Run Configuration...). So we can remove them, and update the Readme.txt file (guide how to create launch for running selenium in Eclipse) > > > > Problem with m2e eclipse plugin with *.laungh files can be found here : http://www.subshell.com/en/subshell/blog/article-Changing-from-m2eclipse-... > > > > > > On Fri, Jun 8, 2012 at 8:41 PM, Peter Palaga <ppalaga(a)redhat.com (mailto:ppalaga@redhat.com)> wrote: > > > Ladies and Gentlemen, > > > > > > As I imported gatein-portal into my Eclipse workspace, my m2e (an > > > Eclipse plugin) has by itself inserted the following two lines into the > > > two *.launch files under > > > gatein-portal/testsuite/selenium-snifftests/src/eclipse: > > > > > > <stringAttribute key="org.eclipse.jdt.launching.CLASSPATH_PROVIDER" > > > value="org.eclipse.m2e.launchconfig.classpathProvider"/> > > > <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" > > > value="org.eclipse.m2e.launchconfig.sourcepathProvider"/> > > > > > > I would like to learn what should happen with these changes. Yes, I > > > could surely tell git to never commit it somehow but generally, would it > > > not be better not to have IDE-specific files commited to scm? > > > > > > Thanks, > > > > > > Peter > > > _______________________________________________ > > > gatein-dev mailing list > > > gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org) > > > https://lists.jboss.org/mailman/listinfo/gatein-dev > > > _______________________________________________ gatein-dev mailing list gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org) https://lists.jboss.org/mailman/listinfo/gatein-dev