11:31 a.m.
Hi All,
I am trying to get the remember me functionality running having the problem that my
sessions are expired by keycloak - in my eyes - prematurely. I started digging through
keycloak code and stumbled over the following:
class UserSessionPredicate, method 'test':
...
if (entity.isRememberMe()) {
if (expiredRememberMe != null && expiredRefreshRememberMe != null
&& entity.getStarted() > ###expiredRefreshRememberMe### &&
entity.getLastSessionRefresh() > expiredRefreshRememberMe) {
return false;
}
}
else {
if (expired != null && expiredRefresh != null &&
entity.getStarted() > expired && entity.getLastSessionRefresh() >
expiredRefresh) {
return false;
}
}
...
The marked (###) 'expiredRefreshRememberMe' in the second if statement, should
that not be 'expiredRememberMe'?
Thanks & Regards,
Alex
1:22 p.m.
Yes, you are absolutely right, that expression should be using the
expiredRememberMe value in that spot. I'll work on the fix.
Best regards,
Stefan
On Tue, Jan 15, 2019 at 8:33 AM Alex Chatziparaskewas <
alex.chatziparaskewas(a)trapezegroup.com> wrote:
Hi All,
I am trying to get the remember me functionality running having the
problem that my sessions are expired by keycloak - in my eyes -
prematurely. I started digging through keycloak code and stumbled over the
following:
class UserSessionPredicate, method 'test':
...
if (entity.isRememberMe()) {
if (expiredRememberMe != null && expiredRefreshRememberMe !=
null && entity.getStarted() > ###expiredRefreshRememberMe### &&
entity.getLastSessionRefresh() > expiredRefreshRememberMe) {
return false;
}
}
else {
if (expired != null && expiredRefresh != null &&
entity.getStarted() > expired && entity.getLastSessionRefresh() >
expiredRefresh) {
return false;
}
}
...
The marked (###) 'expiredRefreshRememberMe' in the second if statement,
should that not be 'expiredRememberMe'?
Thanks & Regards,
Alex
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
--
STEFAN GUILHEN
PRINCIPAL SOFTWARE ENGINEER
Red Hat <https://www.redhat.com/>
sguilhen(a)redhat.com M: +55-11-98117-7332
<https://red.ht/sig>
@RedHat <https://twitter.com/redhat> Red Hat
<https://www.linkedin.com/company/red-hat> Red Hat
<https://www.facebook.com/RedHatInc>
3:38 p.m.
Many thanks!
From: Stefan Guilhen [mailto:sguilhen@redhat.com]
Sent: 15 January 2019 13:22
To: Alex Chatziparaskewas <alex.chatziparaskewas(a)trapezegroup.com>
Cc: keycloak-dev(a)lists.jboss.org
Subject: Re: [keycloak-dev] Session Expiry & Remember Me
Yes, you are absolutely right, that expression should be using the expiredRememberMe value
in that spot. I'll work on the fix.
Best regards,
Stefan
On Tue, Jan 15, 2019 at 8:33 AM Alex Chatziparaskewas
<alex.chatziparaskewas@trapezegroup.com<mailto:alex.chatziparaskewas@trapezegroup.com>>
wrote:
Hi All,
I am trying to get the remember me functionality running having the problem that my
sessions are expired by keycloak - in my eyes - prematurely. I started digging through
keycloak code and stumbled over the following:
class UserSessionPredicate, method 'test':
...
if (entity.isRememberMe()) {
if (expiredRememberMe != null && expiredRefreshRememberMe != null
&& entity.getStarted() > ###expiredRefreshRememberMe### &&
entity.getLastSessionRefresh() > expiredRefreshRememberMe) {
return false;
}
}
else {
if (expired != null && expiredRefresh != null &&
entity.getStarted() > expired && entity.getLastSessionRefresh() >
expiredRefresh) {
return false;
}
}
...
The marked (###) 'expiredRefreshRememberMe' in the second if statement, should
that not be 'expiredRememberMe'?
Thanks & Regards,
Alex
_______________________________________________
keycloak-dev mailing list
keycloak-dev@lists.jboss.org<mailto:keycloak-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/keycloak-dev
--
STEFAN GUILHEN
PRINCIPAL SOFTWARE ENGINEER
Red Hat<https://www.redhat.com/>
sguilhen@redhat.com<mailto:sguilhen@redhat.com> M:
+55-11-98117-7332<tel:+55-11-98117-7332>
[https://www.redhat.com/files/brand/email/sig-redhat.png]<https://red.h...
@RedHat<https://twitter.com/redhat> Red
Hat<https://www.linkedin.com/company/red-hat> Red
Hat<https://www.facebook.com/RedHatInc>
![https://www.redhat.com/files/brand/email/sig-redhat.png]<https://red.h...](https://www.redhat.com/files/brand/email/sig-redhat.png]%3Chttps://red.ht/sig%3E){kind=link}
6:11 p.m.
Alex, I've created a Jira (https://issues.jboss.org/browse/KEYCLOAK-9371)
to track this. PR has been opened and once it is reviewed/merged I will
update the Jira.
On Tue, Jan 15, 2019 at 12:38 PM Alex Chatziparaskewas <
alex.chatziparaskewas(a)trapezegroup.com> wrote:
Many thanks!
*From:* Stefan Guilhen [mailto:sguilhen@redhat.com]
*Sent:* 15 January 2019 13:22
*To:* Alex Chatziparaskewas <alex.chatziparaskewas(a)trapezegroup.com>
*Cc:* keycloak-dev(a)lists.jboss.org
*Subject:* Re: [keycloak-dev] Session Expiry & Remember Me
Yes, you are absolutely right, that expression should be using the
expiredRememberMe value in that spot. I'll work on the fix.
Best regards,
Stefan
On Tue, Jan 15, 2019 at 8:33 AM Alex Chatziparaskewas <
alex.chatziparaskewas(a)trapezegroup.com> wrote:
Hi All,
I am trying to get the remember me functionality running having the
problem that my sessions are expired by keycloak - in my eyes -
prematurely. I started digging through keycloak code and stumbled over the
following:
class UserSessionPredicate, method 'test':
...
if (entity.isRememberMe()) {
if (expiredRememberMe != null && expiredRefreshRememberMe !=
null && entity.getStarted() > ###expiredRefreshRememberMe### &&
entity.getLastSessionRefresh() > expiredRefreshRememberMe) {
return false;
}
}
else {
if (expired != null && expiredRefresh != null &&
entity.getStarted() > expired && entity.getLastSessionRefresh() >
expiredRefresh) {
return false;
}
}
...
The marked (###) 'expiredRefreshRememberMe' in the second if statement,
should that not be 'expiredRememberMe'?
Thanks & Regards,
Alex
_______________________________________________
keycloak-dev mailing list
keycloak-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev
--
*STEFAN GUILHEN*
PRINCIPAL SOFTWARE ENGINEER
Red Hat <https://www.redhat.com/>
sguilhen(a)redhat.com M: +55-11-98117-7332
<https://red.ht/sig>
@RedHat <https://twitter.com/redhat> Red Hat
<https://www.linkedin.com/company/red-hat> Red Hat
<https://www.facebook.com/RedHatInc>
--
STEFAN GUILHEN
PRINCIPAL SOFTWARE ENGINEER
Red Hat <https://www.redhat.com/>
sguilhen(a)redhat.com M: +55-11-98117-7332
<https://red.ht/sig>
@RedHat <https://twitter.com/redhat> Red Hat
<https://www.linkedin.com/company/red-hat> Red Hat
<https://www.facebook.com/RedHatInc>
1926
days inactive
1928
days old
3 comments
2 participants
participants (2)
-
Alex Chatziparaskewas -
Stefan Guilhen