Good afternoon, Alex is working on https://issues.jboss.org/browse/KEYCLOAK-11293 and I would like to double-check if we're ok with the requirements described below. What The new account console needs to be built from Maven. The build also needs to be able to build the RH-SSO version. Why There's no way to build the new account console from Maven and that's a requirement that has an impact on testing and distribution. How - Build the new account console as part of the default distribution (Keycloak and RHSSO build) - The Maven build should be based on the steps described in the README Acceptance Criteria - Have all the artifacts from the new account console in the same Keycloak/RHSSO server distribution Additional information This Jira can also incorporate https://issues.jboss.org/browse/KEYCLOAK-5392 if possible, but that's not mandatory Comments are welcome, in the same Jira or here. -- - abstractj _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

On 10/29/2019 11:12 AM, Stian Thorgersen wrote: > Is the plan to checking npm modules like we do for other things? Or > actually pull npm modules from NPM? I want the approach here to be > consistent and not continue having two separate ways for new and old. It's my understanding that the plan is to do it the same way we do for the admin console (check 'em in).  When something better comes along (probably from PNC), then we will switch everything to use the new tools. > One problem with node_modules is that they include a lot of files that > should not be included in the distribution. We have a somewhat working > approach for the old stuff where we use a filter in Maven when copying > resources from node_modules directory created by Maven npm-update > profile. > This is a requirement for new account console resources as well, as > otherwise we would significantly increase the size of the dist. Yes, that needs to be part of the requirements. > One issue with new account console is that it has some node_modules > the old > stuff uses, but are different versions. Ideally we'd just have a single > package.json file for everything, but I don't think that's possible. > Ideally node_modules should all be in the common bundle and not > directly in > the account theme, so they can be re-used by other things. I don't think we have time to address that before tech preview. But we should definitely take a hard look before final release. > When we have a working build of the account console that addresses the > above (and anything else) it should be included in a default build (and > release) and shouldn't be a separate Maven profile to enable. We also > need > to move it from experimental to preview. I'm not sure it even needs to be a separate profile any longer.  I can't think of any reason to keep it in a separate profile once the npm libraries are checked in to github. > > On Tue, 29 Oct 2019 at 16:05, Bruno Oliveira <bruno(a)abstractj.org&gt; > wrote: > >> Good afternoon, >> >> Alex is working on https://issues.jboss.org/browse/KEYCLOAK-11293 and >> I would like to double-check if we're ok with the requirements >> described below. >> >> What >> >> The new account console needs to be built from Maven. The build also >> needs to be able to build the RH-SSO version. >> >> Why >> >> There's no way to build the new account console from Maven and that's >> a requirement that has an impact on testing and distribution. >> >> How >> >> - Build the new account console as part of the default distribution >> (Keycloak and RHSSO build) >> - The Maven build should be based on the steps described in the README >> >> Acceptance Criteria >> >> - Have all the artifacts from the new account console in the same >> Keycloak/RHSSO server distribution >> >> Additional information >> >> This Jira can also incorporate >> https://issues.jboss.org/browse/KEYCLOAK-5392 if possible, but that's >> not mandatory >> >> Comments are welcome, in the same Jira or here. >> >> -- >> - abstractj >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev >> > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev

I believe that part of what you guys mentioned is reflected into https://issues.jboss.org/browse/KEYCLOAK-5392. Maybe we should merge these Jiras, so that all the requirements will be in a single place. On Tue, Oct 29, 2019 at 3:19 PM Stan Silvert <ssilvert(a)redhat.com&gt; wrote: > On 10/29/2019 11:12 AM, Stian Thorgersen wrote: >> Is the plan to checking npm modules like we do for other things? Or >> actually pull npm modules from NPM? I want the approach here to be >> consistent and not continue having two separate ways for new and old. > It's my understanding that the plan is to do it the same way we do for > the admin console (check 'em in). When something better comes along > (probably from PNC), then we will switch everything to use the new tools. >> One problem with node_modules is that they include a lot of files that >> should not be included in the distribution. We have a somewhat working >> approach for the old stuff where we use a filter in Maven when copying >> resources from node_modules directory created by Maven npm-update profile. >> This is a requirement for new account console resources as well, as >> otherwise we would significantly increase the size of the dist. > Yes, that needs to be part of the requirements. >> One issue with new account console is that it has some node_modules the old >> stuff uses, but are different versions. Ideally we'd just have a single >> package.json file for everything, but I don't think that's possible. >> Ideally node_modules should all be in the common bundle and not directly in >> the account theme, so they can be re-used by other things. > I don't think we have time to address that before tech preview. But we > should definitely take a hard look before final release. >> When we have a working build of the account console that addresses the >> above (and anything else) it should be included in a default build (and >> release) and shouldn't be a separate Maven profile to enable. We also need >> to move it from experimental to preview. > I'm not sure it even needs to be a separate profile any longer. I can't > think of any reason to keep it in a separate profile once the npm > libraries are checked in to github. >> On Tue, 29 Oct 2019 at 16:05, Bruno Oliveira <bruno(a)abstractj.org&gt; wrote: >> >>> Good afternoon, >>> >>> Alex is working on https://issues.jboss.org/browse/KEYCLOAK-11293 and >>> I would like to double-check if we're ok with the requirements >>> described below. >>> >>> What >>> >>> The new account console needs to be built from Maven. The build also >>> needs to be able to build the RH-SSO version. >>> >>> Why >>> >>> There's no way to build the new account console from Maven and that's >>> a requirement that has an impact on testing and distribution. >>> >>> How >>> >>> - Build the new account console as part of the default distribution >>> (Keycloak and RHSSO build) >>> - The Maven build should be based on the steps described in the README >>> >>> Acceptance Criteria >>> >>> - Have all the artifacts from the new account console in the same >>> Keycloak/RHSSO server distribution >>> >>> Additional information >>> >>> This Jira can also incorporate >>> https://issues.jboss.org/browse/KEYCLOAK-5392 if possible, but that's >>> not mandatory >>> >>> Comments are welcome, in the same Jira or here. >>> >>> -- >>> - abstractj >>> _______________________________________________ >>> keycloak-dev mailing list >>> keycloak-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/keycloak-dev >>> >> _______________________________________________ >> keycloak-dev mailing list >> keycloak-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/keycloak-dev > > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev

I've been looking at this for a while now, and I'm thinking that it'd be best to split the src/main/resources/theme/keycloak-preview/account/resources/package.json and its associated files into a new maven pom. It would help this build to work more elegantly, but it is possible for me to maintain it in the current structure, if moving files around would be too disruptive to development at this stage. It's all a bit of a mess at the moment because account2 is assumed to be non-compiled like the rest of the "themes", and it isn't. It has its own package.json that needs to be used at build time. Thoughts? Alex _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

The problem with moving it is pretty much what you said. New account console is just another theme. So during development, you got to standalone.xml and set your theme directory to something like /GitHub/keycloak/themes/src/main/resources/theme. If the files for new account console were in a different spot then you wouldn't be able to use them with the other pre-defined themes. On 11/5/2019 9:24 AM, Alex Szczuczko wrote: > I've been looking at this for a while now, and I'm thinking that it'd be > best to split the > > src/main/resources/theme/keycloak-preview/account/resources/package.json > > and its associated files into a new maven pom. It would help this build to > work more elegantly, but it is possible for me to maintain it in the > current structure, if moving files around would be too disruptive to > development at this stage. > > It's all a bit of a mess at the moment because account2 is assumed to be > non-compiled like the rest of the "themes", and it isn't. It has its own > package.json that needs to be used at build time. > > Thoughts? > > Alex > _______________________________________________ > keycloak-dev mailing list > keycloak-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/keycloak-dev _______________________________________________ keycloak-dev mailing list keycloak-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/keycloak-dev

Alex, can you answer why you are doing anything different to what we already have for the older stuff?

The new account console has its own package.json. Additionally, it must be complied due to being written with Typescript. These two things are unique to the new account console and are why it has to be handled differently. The other themes are non-compiled, and just get their javascript libraries from the global node_modules store, populated by the global package.json in src/main/package.json. Their files just get copied at build time, and that's not sufficient for account2.

Alex On Thu, Nov 7, 2019 at 5:50 AM Stian Thorgersen <sthorger(a)redhat.com&gt; wrote: > Alex, can you answer why you are doing anything different to what we > already have for the older stuff? >